ccan
7 years agoMakefile: don't separate all modules with external dependencies.
Rusty Russell [Mon, 1 Apr 2013 03:22:55 +0000 (13:52 +1030)]
Makefile: don't separate all modules with external dependencies.

Using ccanlint's --deps-fail-ignore, we can just test every module
with "make check".  Still exclude them from the 'libccan.a' build
though.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agonfs: add licenses into generated files.
Rusty Russell [Mon, 1 Apr 2013 03:22:35 +0000 (13:52 +1030)]
nfs: add licenses into generated files.

Otherwise ccanlint complains about missing license comments.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoccanlint: --deps-fail-ignore.
Rusty Russell [Mon, 1 Apr 2013 02:44:00 +0000 (13:14 +1030)]
ccanlint: --deps-fail-ignore.

Useful for bulk testing modules, where some might not have required
external (non-CCAN) dependencies.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoogg_to_pcm: fix compilation of example in _info.
Rusty Russell [Mon, 1 Apr 2013 00:00:30 +0000 (10:30 +1030)]
ogg_to_pcm: fix compilation of example in _info.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoccanlint: don't crash if given bad directory name.
Rusty Russell [Sun, 31 Mar 2013 06:40:50 +0000 (17:10 +1030)]
ccanlint: don't crash if given bad directory name.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoAdd a set of simple version comparison helpers
Peter Hutterer [Wed, 27 Mar 2013 23:38:48 +0000 (09:38 +1000)]
Add a set of simple version comparison helpers

These version helpers help to compare major.minor style version numbers,
without the need for open-coded and error-prone bitshifting, multiplication,
and similar.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agonet: add server support.
Rusty Russell [Sun, 17 Mar 2013 04:48:10 +0000 (15:18 +1030)]
net: add server support.

Creating a server for IPv4 and IPv6 has similar issues to clients,
with some novel twists.  Slightly different arguments need to be given
to getaddrinfo(), but worse, some platforms (Linux without
/proc/sys/net/ipv6/bindv6only set) automatically bind IPv6 sockets to IPv4
ports as well.

Thus we need a function which can bind (and listen) to one or two fds.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agolist: list_pop
Rusty Russell [Sun, 17 Mar 2013 04:42:14 +0000 (15:12 +1030)]
list: list_pop

list_top + list_del, as suggested by Ben Herrenschmidt.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agolist: list_append_list / list_prepend_list
Rusty Russell [Sun, 17 Mar 2013 04:41:48 +0000 (15:11 +1030)]
list: list_append_list / list_prepend_list

Operations for moving the entire contents of a list.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoautodata: make note about not being generally useful for shared libraries.
Rusty Russell [Sun, 17 Mar 2013 03:56:31 +0000 (14:26 +1030)]
autodata: make note about not being generally useful for shared libraries.

If you have sections, it might still work for some cases though: on x86
Ubuntu it worked once I changed the section name from autodata to xautodata.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoiscsi, ttxml: fix warning [-Wunused-but-set-variable]
Tinggong [Fri, 8 Mar 2013 15:11:23 +0000 (23:11 +0800)]
iscsi, ttxml: fix warning [-Wunused-but-set-variable]

hi all,

here is a trival path to fix warning [-Wunused-but-set-variable].

Thanks.
Tinggong

Signed-off-by: Tinggong <wangtinggong@gmail.com>
7 years agofailtest: fix warning [-Wformat]
Tinggong [Fri, 8 Mar 2013 15:09:02 +0000 (23:09 +0800)]
failtest: fix warning [-Wformat]

hi rusty,

here is a trival path to fix warning [-Wformat].

Thanks.
Tinggong

Signed-off-by: Tinggong <wangtinggong@gmail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agonet: make tests more robust.
Rusty Russell [Thu, 7 Feb 2013 00:42:27 +0000 (11:12 +1030)]
net: make tests more robust.

Andreas Schlick reports failure on systems without IPv6 support (in particular
ones with no IPv6 addresses for localhost).  We should be more robust in
these cases, and also where IPv4 support is missing.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoforeach: fix overzealous test.
Rusty Russell [Thu, 7 Feb 2013 00:25:01 +0000 (10:55 +1030)]
foreach: fix overzealous test.

Andreas Schlick reported a failure on 64-bit systems; we should simply
test that the number of iterators does not grow on second iteration,
rather than assuming an explicit limit as compilers may vary.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoMakefile: Add hacks for the nested modules for make check.
Andreas Schlick [Tue, 5 Feb 2013 19:05:35 +0000 (20:05 +0100)]
Makefile: Add hacks for the nested modules for make check.

7 years agoMerge commit 'add31d8'
Rusty Russell [Sat, 2 Feb 2013 04:15:34 +0000 (14:45 +1030)]
Merge commit 'add31d8'

7 years agosparse_bsearch: fixed the no ssize_t defined error.
Riceball LEE [Thu, 24 Jan 2013 01:01:14 +0000 (09:01 +0800)]
sparse_bsearch: fixed the no ssize_t defined error.

7 years agosiphash: Use uint64_t directly, remove typedef
Ulrik Sverdrup [Fri, 25 Jan 2013 19:48:35 +0000 (20:48 +0100)]
siphash: Use uint64_t directly, remove typedef

7 years agosiphash: Simplify helper function W64's signature
Ulrik Sverdrup [Fri, 25 Jan 2013 19:48:35 +0000 (20:48 +0100)]
siphash: Simplify helper function W64's signature

7 years agosiphash: Use ~7 correctly
Ulrik Sverdrup [Fri, 25 Jan 2013 19:48:35 +0000 (20:48 +0100)]
siphash: Use ~7 correctly

7 in ~7 needs to be size_t for it to be correct when len > INT_MAX.

7 years agosiphash: Write siphash_epilogue in nicer style
Ulrik Sverdrup [Mon, 14 Jan 2013 22:11:56 +0000 (23:11 +0100)]
siphash: Write siphash_epilogue in nicer style

7 years agosiphash: Use simple but misalignment-correct implementation of W64
Ulrik Sverdrup [Sun, 13 Jan 2013 15:24:11 +0000 (16:24 +0100)]
siphash: Use simple but misalignment-correct implementation of W64

A simple implementation compiles very well with gcc and clang on ppc and
x86, and will handle any-aligned input.

7 years agosiphash: A keyed hash designed by Aumasson and djb
Ulrik Sverdrup [Sun, 13 Jan 2013 15:24:11 +0000 (16:24 +0100)]
siphash: A keyed hash designed by Aumasson and djb

7 years agoccanlint: fix stack smash.
Rusty Russell [Mon, 14 Jan 2013 07:40:59 +0000 (18:10 +1030)]
ccanlint: fix stack smash.

"engla" on IRC reported that ccanlint on linux/powerpc would loop
infinitely calling dep_failed after all tests are run and the score is
output.

Reproduced, and discovered that cannot_run() takes a container_of(),
except our top node is not a struct ccanlint.  The result was harmless on
x86, but set dep_failed to the return address on powerpc, causing that
to be called repeatedly.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agodgraph: add dgraph_check and CCAN_DGRAPH_DEBUG
Rusty Russell [Mon, 14 Jan 2013 07:35:14 +0000 (18:05 +1030)]
dgraph: add dgraph_check and CCAN_DGRAPH_DEBUG

This is good form for datastructures, so caller can track weird bugs.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoccanlint: handle when _info doesn't compile.
Rusty Russell [Sat, 12 Jan 2013 05:34:58 +0000 (16:04 +1030)]
ccanlint: handle when _info doesn't compile.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoMerge branch 'rfc822'
Rusty Russell [Thu, 3 Jan 2013 01:06:59 +0000 (11:36 +1030)]
Merge branch 'rfc822'

7 years agorfc822: switch to ccan/tal. origin/rfc822
Rusty Russell [Thu, 3 Jan 2013 01:06:55 +0000 (11:36 +1030)]
rfc822: switch to ccan/tal.

We use TAL_USE_TALLOC to use libtalloc as the backend: you can test that with
ccanlint --compiler="cc -DTAL_USE_TALLOC".

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agotal/str: use tal/talloc backend #ifdef TAL_USE_TALLOC.
Rusty Russell [Thu, 3 Jan 2013 01:06:55 +0000 (11:36 +1030)]
tal/str: use tal/talloc backend #ifdef TAL_USE_TALLOC.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoccanlint: ignore "unused" non-ccan dependencies.
Rusty Russell [Thu, 3 Jan 2013 01:06:48 +0000 (11:36 +1030)]
ccanlint: ignore "unused" non-ccan dependencies.

We can't really tell if non-ccan dependencies are used, so don't try.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agotal/talloc: new module for backending tal onto talloc.
Rusty Russell [Thu, 3 Jan 2013 01:04:22 +0000 (11:34 +1030)]
tal/talloc: new module for backending tal onto talloc.

David Gibson points out that a project may already be using talloc, so
this gives a simple adapter if one module uses tal.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agotal: don't automatically register cleanup function.
Rusty Russell [Mon, 17 Dec 2012 03:25:42 +0000 (13:55 +1030)]
tal: don't automatically register cleanup function.

It may interfere with other at_exit() calls, so let them call it manually.
Also, use memset to zero, which really does make valgrind notice any leaks.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agoconfigurator: fix single-arg case.
Rusty Russell [Mon, 17 Dec 2012 03:24:15 +0000 (13:54 +1030)]
configurator: fix single-arg case.

In this case, CCAN_CFLAGS should be "".

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agotal: append the length property to the initial allocation.
Rusty Russell [Mon, 17 Dec 2012 03:23:25 +0000 (13:53 +1030)]
tal: append the length property to the initial allocation.

Since we never post-add a length property, we can save some cycles by
allocating it together with the object itself:

Before:
$ ./samba-allocs talloc.dump --tal
Tal time:                6058997-6215211(6102645)ns
Tal_free time:           4791112-4968964(4824814)ns
Single tal_free time:    3173647-3331584(3200183)ns
$ ./samba-allocs talloc.dump --tal-size
Virtual size = 9809920, RSS = 3952640

After:
$ ./samba-allocs talloc.dump --tal
Tal time:                5911994-6043808(5956914)ns
Tal_free time:           4676026-4834598(4719908)ns
Single tal_free time:    2888195-3067365(2922298)ns
$ ./samba-allocs talloc.dump --tal-size
Virtual size = 9809920, RSS = 3948544

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agotal: don't always allocate an array in the samba benchmark.
Rusty Russell [Fri, 14 Dec 2012 21:02:06 +0000 (07:32 +1030)]
tal: don't always allocate an array in the samba benchmark.

Since we added the length property, this penalizes us with an extra
alloc.  Unfortunately, we can't tell from the talloc.dump which are
array tallocs and which are single tallocs, but grepping the sources
gives a rate of 1 in 27.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agotal: fix skipping tal in samba-allocs benchmark.
Rusty Russell [Fri, 14 Dec 2012 20:57:50 +0000 (07:27 +1030)]
tal: fix skipping tal in samba-allocs benchmark.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
7 years agotal: fix compilation of speed benchmark.
Rusty Russell [Fri, 14 Dec 2012 20:57:19 +0000 (07:27 +1030)]
tal: fix compilation of speed benchmark.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agorfc822: fix sigaction test, wean off ccan-specific talloc_set_allocator()
Rusty Russell [Fri, 7 Dec 2012 05:56:37 +0000 (16:26 +1030)]
rfc822: fix sigaction test, wean off ccan-specific talloc_set_allocator()

The first ok() line was actually failing, because sigaction returns 0
on success, but because the program exit(0) out the abort handler,
that wasn't being seen.

So remove tap and just abort and assert our way through the test,
which I think is clearer.

We use macros to mug the talloc entry points, since talloc_set_allocator()
is not in mainline talloc.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agorfc822: beef up _info example.
Rusty Russell [Fri, 7 Dec 2012 05:56:37 +0000 (16:26 +1030)]
rfc822: beef up _info example.

Now it's a useful little command line utility, with tests.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoccanlint: fix --compiler and --cflags options to apply to _info files as well.
Rusty Russell [Fri, 7 Dec 2012 05:56:07 +0000 (16:26 +1030)]
ccanlint: fix --compiler and --cflags options to apply to _info files as well.

We weren't using the compiler and cflags options in tools/compile.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotools: manifest.c should use path_canon.
Rusty Russell [Mon, 3 Dec 2012 11:36:40 +0000 (22:06 +1030)]
tools: manifest.c should use path_canon.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoccanlint: remove redundant num_lines in struct ccan_file.
Rusty Russell [Mon, 3 Dec 2012 11:36:40 +0000 (22:06 +1030)]
ccanlint: remove redundant num_lines in struct ccan_file.

We can use tal_count.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoccanlint: print module name properly for nested modules.
Rusty Russell [Mon, 3 Dec 2012 11:36:40 +0000 (22:06 +1030)]
ccanlint: print module name properly for nested modules.

eg:
tal/str: Module's tests cover all the code (tests_coverage): PASS (+3/6)
tal/str: Total score: 55/58

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotools: use tal/path instead of opencoding most paths.
Rusty Russell [Mon, 3 Dec 2012 11:36:40 +0000 (22:06 +1030)]
tools: use tal/path instead of opencoding most paths.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotools: use tal/path instead of writing own path handlers.
Rusty Russell [Mon, 3 Dec 2012 11:36:40 +0000 (22:06 +1030)]
tools: use tal/path instead of writing own path handlers.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotools: use tal instead of talloc.
Rusty Russell [Mon, 3 Dec 2012 11:36:40 +0000 (22:06 +1030)]
tools: use tal instead of talloc.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotools: use rbuf instead of grab_file.
Rusty Russell [Mon, 3 Dec 2012 11:36:40 +0000 (22:06 +1030)]
tools: use rbuf instead of grab_file.

Slowly removing the talloc dependency.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agorbuf: new module.
Rusty Russell [Mon, 3 Dec 2012 11:36:40 +0000 (22:06 +1030)]
rbuf: new module.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal/link: new module for reference-count style coding for tal.
Rusty Russell [Mon, 3 Dec 2012 11:36:38 +0000 (22:06 +1030)]
tal/link: new module for reference-count style coding for tal.

Tests and example copied from talloc_link, which I also wrote.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal/str: add tal_append_fmt() and tal_append_vfmt() helpers.
Rusty Russell [Mon, 3 Dec 2012 08:59:39 +0000 (19:29 +1030)]
tal/str: add tal_append_fmt() and tal_append_vfmt() helpers.

They are far too convenient, despite their inefficiency.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal/str: rename tal_asprintf/tal_vasprintf to tal_fmt/tal_vfmt.
Rusty Russell [Mon, 3 Dec 2012 08:59:39 +0000 (19:29 +1030)]
tal/str: rename tal_asprintf/tal_vasprintf to tal_fmt/tal_vfmt.

Shorter, sweeter, and less legacy.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal/str: add tal_strcat().
Rusty Russell [Mon, 3 Dec 2012 08:59:39 +0000 (19:29 +1030)]
tal/str: add tal_strcat().

Useful for joining two strings.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: add tal_expand().
Rusty Russell [Mon, 3 Dec 2012 08:59:39 +0000 (19:29 +1030)]
tal: add tal_expand().

Helper to reallocate and append to an array.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal/str: move tal string functions here from tal.
Rusty Russell [Mon, 3 Dec 2012 08:59:39 +0000 (19:29 +1030)]
tal/str: move tal string functions here from tal.

They don't need anything internal to tal, they're just helpers.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal/str: use tal_ prefix.
Rusty Russell [Mon, 3 Dec 2012 08:59:39 +0000 (19:29 +1030)]
tal/str: use tal_ prefix.

It's short, and much clearer.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal/str: make tal_count() work for strsplit.
Rusty Russell [Mon, 3 Dec 2012 08:59:39 +0000 (19:29 +1030)]
tal/str: make tal_count() work for strsplit.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: add tal_count() and length properties for arrays.
Rusty Russell [Mon, 3 Dec 2012 08:59:39 +0000 (19:29 +1030)]
tal: add tal_count() and length properties for arrays.

Unlike talloc, we don't have a count on everything, just on array
allocations.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: adding or removing a notifier/destructor can be const.
Rusty Russell [Mon, 3 Dec 2012 08:59:38 +0000 (19:29 +1030)]
tal: adding or removing a notifier/destructor can be const.

You don't need write access to the context to attach a destructor;
it's meta.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: optimize case where no (non-destructor) notifiers are used.
Rusty Russell [Mon, 3 Dec 2012 08:59:38 +0000 (19:29 +1030)]
tal: optimize case where no (non-destructor) notifiers are used.

$ for i in `seq 10`; do ./samba-allocs talloc.dump --tal; done | stats.c --trim-outliers
Before:
Read 25998 nodes
Tal time:                2857988-2981158(2904324)ns
Tal_free time:           2417170-2582088(2470931)ns
Single tal_free time:    1551654-1609583(1575984)ns

After:
Read 25998 nodes
Tal time:                2780974-2901323(2839352)ns
Tal_free time:           2241725-2355309(2285165)ns
Single tal_free time:    1549908-1612485(1566609)ns

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: use notifier infrastructure for destructors.
Rusty Russell [Mon, 3 Dec 2012 08:59:38 +0000 (19:29 +1030)]
tal: use notifier infrastructure for destructors.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: add general notifiers.
Rusty Russell [Mon, 3 Dec 2012 08:59:38 +0000 (19:29 +1030)]
tal: add general notifiers.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: add del_destructor().
Rusty Russell [Mon, 3 Dec 2012 08:59:38 +0000 (19:29 +1030)]
tal: add del_destructor().

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: check headers more carefully.
Rusty Russell [Mon, 3 Dec 2012 08:59:38 +0000 (19:29 +1030)]
tal: check headers more carefully.

We sanity check tal headers by ensuring that the pointers are in the
bounds of things we've allocated.  But the first one we check is the
prop ptr, which may also be a literal: this is_literal() dereferences
the pointer, which means we usually crash here if it's not a tal
object.

Move that last, and we have far more success with our sanity checking.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: simplify.
Rusty Russell [Mon, 3 Dec 2012 08:59:38 +0000 (19:29 +1030)]
tal: simplify.

All the effort trying to keep the header size down to 2 pointers turns
out to be wasted.  In addition, getting the parent of a tal pointer is
now much faster.

./samba-allocs talloc.dump --tal-size:
Before:
Virtual size = 9633792, RSS = 3952640
After:
Virtual size = 9793536, RSS = 3948544

And we're much faster now, esp. on free.

./samba-allocs talloc.dump --tal:
Before:
Tal time:                2718068ns
Tal_free time:           3360258ns
Single tal_free time:    1667412ns
After:
Tal time:                2788287ns
Tal_free time:           2290167ns
Single tal_free time:    1566998ns

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Header from folded patch 'tal-fix-set-destroying-bit.patch':

tal: fix destroying bit usage.

Actually looking at a destroying contexts' parent didn't work, and a couple
of places didn't filter out the destroying bit.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoccanlint: handle nested modules when mentioned in examples.
Rusty Russell [Mon, 3 Dec 2012 08:59:23 +0000 (19:29 +1030)]
ccanlint: handle nested modules when mentioned in examples.

If we see an ccan include line in an example, we add that to the
dependencies to try to build the example, but we didn't handle nested
modules.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotools: don't abort on malformed documentation lines.
Rusty Russell [Mon, 3 Dec 2012 07:55:41 +0000 (18:25 +1030)]
tools: don't abort on malformed documentation lines.

ccanlint would abort with 'Malformed line 53' if there was a bad header.
That's very poor, and deeply unhelpful.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoMakefile: score nested modules.
Rusty Russell [Mon, 3 Dec 2012 07:54:41 +0000 (18:24 +1030)]
Makefile: score nested modules.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: fix benchmark/Makefile
Rusty Russell [Thu, 22 Nov 2012 10:07:01 +0000 (20:37 +1030)]
tal: fix benchmark/Makefile

We need ccan/take here.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal/path: new module
Rusty Russell [Thu, 22 Nov 2012 01:12:25 +0000 (11:42 +1030)]
tal/path: new module

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Header from folded patch 'path-talloc-take.patch':

tal/path: accept take() for arguments.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoconfigurator: test for HAVE_FCHDIR
Rusty Russell [Thu, 22 Nov 2012 01:12:25 +0000 (11:42 +1030)]
configurator: test for HAVE_FCHDIR

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal/str: accept take() for arguments.
Rusty Russell [Thu, 22 Nov 2012 01:12:25 +0000 (11:42 +1030)]
tal/str: accept take() for arguments.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal/str: new module.
Rusty Russell [Thu, 22 Nov 2012 01:12:22 +0000 (11:42 +1030)]
tal/str: new module.

Tal-enhanced string routines, copied from str_talloc (which I also wrote).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoalloc: move into antithread/alloc.
Rusty Russell [Thu, 22 Nov 2012 01:12:11 +0000 (11:42 +1030)]
alloc: move into antithread/alloc.

Our first nested module; easy because noone else relies on it.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoweb: generate correct pages for submodules.
Rusty Russell [Thu, 22 Nov 2012 00:32:21 +0000 (11:02 +1030)]
web: generate correct pages for submodules.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotools: don't assume modules are immediately below ccan/ dir.
Rusty Russell [Thu, 22 Nov 2012 00:32:19 +0000 (11:02 +1030)]
tools: don't assume modules are immediately below ccan/ dir.

Removing this assumption should allow nested modules.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoMakefile: remove FASTTIMEOUT
Rusty Russell [Thu, 22 Nov 2012 00:32:17 +0000 (11:02 +1030)]
Makefile: remove FASTTIMEOUT

Far more effective to just skip valgrind and gcov if you want fast
results; that's what we do for the summary already.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoMakefile: list modules explicitly.
Rusty Russell [Thu, 22 Nov 2012 00:32:15 +0000 (11:02 +1030)]
Makefile: list modules explicitly.

Clumsier than using wildcards, but that breaks down with nested modules
anyway.  In the longer term, we want ccantool to do the building, but for
the moment make is a necessary evil.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotools: fix dependencies.
Rusty Russell [Wed, 21 Nov 2012 23:38:53 +0000 (10:08 +1030)]
tools: fix dependencies.

In particular, we might need the C files for foreach and err.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoccanlint: fix _info documentation addition.
Rusty Russell [Wed, 21 Nov 2012 23:38:53 +0000 (10:08 +1030)]
ccanlint: fix _info documentation addition.

Firstly, we should always ask before altering files.  Secondly, we are
not in the module directory: we need to use m->info_file->fullname.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoMakefile: generate config.h more carefully
Rusty Russell [Wed, 21 Nov 2012 23:38:53 +0000 (10:08 +1030)]
Makefile: generate config.h more carefully

Don't risk reading partially-constructed files.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoMakefile: add -Wundef to the default CFLAGS
Rusty Russell [Wed, 21 Nov 2012 23:38:53 +0000 (10:08 +1030)]
Makefile: add -Wundef to the default CFLAGS

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agoTAGS: new Makefile target.
Rusty Russell [Wed, 21 Nov 2012 23:38:53 +0000 (10:08 +1030)]
TAGS: new Makefile target.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: make tal_free() return NULL
Rusty Russell [Wed, 21 Nov 2012 23:38:50 +0000 (10:08 +1030)]
tal: make tal_free() return NULL

This makes it convenient to do:

ptr = tal_free(ptr);

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: take implies NULL passthrough.
Rusty Russell [Wed, 21 Nov 2012 23:37:50 +0000 (10:07 +1030)]
tal: take implies NULL passthrough.

This makes error handling much more convenient, since take is usually
used for chaining functions.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: remove TAL_TAKE in favor of ccan/take.
Rusty Russell [Wed, 21 Nov 2012 23:35:27 +0000 (10:05 +1030)]
tal: remove TAL_TAKE in favor of ccan/take.

TAL_TAKE is awkward to use, particularly on functions which take multiple
arguments.  Instead, record annotations for pointers due to be freed in
the callee.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotake: new module for parameter ownership.
Rusty Russell [Wed, 21 Nov 2012 23:28:31 +0000 (09:58 +1030)]
take: new module for parameter ownership.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: tal_dup()
Rusty Russell [Wed, 21 Nov 2012 03:02:06 +0000 (13:32 +1030)]
tal: tal_dup()

Sometimes you want to duplicate and enlarge in one step: particularly with
TAL_TAKE.  It's also typesafe, unlike tal_memdup().

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: Make tal_resize() easier to use.
Rusty Russell [Tue, 20 Nov 2012 05:17:30 +0000 (15:47 +1030)]
tal: Make tal_resize() easier to use.

Instead of trying to force people to use the return value, pass a pointer.
This makes it easier if you want to handle failure: no overwriting the old
pointer!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: make sure tal_free() preserves errno.
Rusty Russell [Mon, 19 Nov 2012 02:22:41 +0000 (12:52 +1030)]
tal: make sure tal_free() preserves errno.

Always good form to have cleanup functions preserve errno.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: add test for group growth.
Rusty Russell [Mon, 19 Nov 2012 00:28:25 +0000 (10:58 +1030)]
tal: add test for group growth.

Rusty forgets a git add.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: tal_steal() fix.
Rusty Russell [Mon, 19 Nov 2012 00:23:57 +0000 (10:53 +1030)]
tal: tal_steal() fix.

We call remove_node() in tal_steal, then re-use the node.  So it's important
that we always unlink the group property from the node for that case.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: tal_parent(NULL) should be NULL.
Rusty Russell [Mon, 19 Nov 2012 00:23:09 +0000 (10:53 +1030)]
tal: tal_parent(NULL) should be NULL.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: neaten child property initialization.
Rusty Russell [Mon, 19 Nov 2012 00:14:29 +0000 (10:44 +1030)]
tal: neaten child property initialization.

Don't open-code the list_head_init: left over from performance
debugging.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: bounds checking fixes.
Rusty Russell [Mon, 19 Nov 2012 00:13:29 +0000 (10:43 +1030)]
tal: bounds checking fixes.

First, we need to update the bounds for the group property allocated
with the children property, just in case it's at the end of the
allocations.

Second, we need to allow the tal_check() code to accept the pointer to
the null parent's group property.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: add benchmark based on Samba4's talloc usage.
Rusty Russell [Sun, 18 Nov 2012 03:45:53 +0000 (14:15 +1030)]
tal: add benchmark based on Samba4's talloc usage.

This is based on a very simple dump of S4's talloc tree, which we try
to duplicate using tal.  The benchmarks are simply to allocate all the
nodes, free all the nodes individually, and a top-level free.

Size results (32-bit x86):
$ ./samba-allocs talloc.dump --talloc-size
Read 25998 nodes
Virtual size = 10469376, RSS = 4759552
$ ./samba-allocs talloc.dump --tal-size
Read 25998 nodes
Virtual size = 9629696, RSS = 3948544

Speed results:
$ ./samba-allocs talloc.dump
Read 25998 nodes
Malloc time:             1912082ns
Free time:               1384892ns
Talloc time:             2851531ns
talloc_free time:        2133801ns
Single talloc_free time: 1696298ns
Tal time:                2686952ns
Tal_free time:           3316153ns
Single tal_free time:    1639407ns

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: add talloc's speed benchmark.
Rusty Russell [Sun, 18 Nov 2012 03:37:37 +0000 (14:07 +1030)]
tal: add talloc's speed benchmark.

We modify it a bit (to do more allocations before freeing).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: add typenames by default.
Rusty Russell [Sun, 18 Nov 2012 03:37:36 +0000 (14:07 +1030)]
tal: add typenames by default.

The really size-conscious can override them, but it's great for
debugging to have names on the nodes.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: add TAL_TAKE.
Rusty Russell [Sun, 18 Nov 2012 03:37:35 +0000 (14:07 +1030)]
tal: add TAL_TAKE.

TAL_TAKE provides a magic context meaning "consume my args and return
a replacement".  This is useful for writing convenience functions,
though not so useful in the standard routines here.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agotal: new module.
Rusty Russell [Sun, 18 Nov 2012 03:37:17 +0000 (14:07 +1030)]
tal: new module.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
8 years agolikely: relicense to CC0.
Rusty Russell [Thu, 15 Nov 2012 02:28:34 +0000 (12:58 +1030)]
likely: relicense to CC0.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>