]> git.ozlabs.org Git - patchwork/blob - apps/patchwork/tests/bundles.py
[views] Check count() for duplicate bundle patches, rather than try/except
[patchwork] / apps / patchwork / tests / bundles.py
1 # Patchwork - automated patch tracking system
2 # Copyright (C) 2009 Jeremy Kerr <jk@ozlabs.org>
3 #
4 # This file is part of the Patchwork package.
5 #
6 # Patchwork is free software; you can redistribute it and/or modify
7 # it under the terms of the GNU General Public License as published by
8 # the Free Software Foundation; either version 2 of the License, or
9 # (at your option) any later version.
10 #
11 # Patchwork is distributed in the hope that it will be useful,
12 # but WITHOUT ANY WARRANTY; without even the implied warranty of
13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
14 # GNU General Public License for more details.
15 #
16 # You should have received a copy of the GNU General Public License
17 # along with Patchwork; if not, write to the Free Software
18 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
19
20 import unittest
21 from django.test import TestCase
22 from django.test.client import Client
23 from patchwork.models import Patch, Bundle, BundlePatch, Person
24 from patchwork.tests.utils import defaults, create_user, find_in_context
25
26 class BundleListTest(TestCase):
27     def setUp(self):
28         self.user = create_user()
29         self.client.login(username = self.user.username,
30                 password = self.user.username)
31
32     def testNoBundles(self):
33         response = self.client.get('/user/bundles/')
34         self.failUnlessEqual(response.status_code, 200)
35         self.failUnlessEqual(
36                 len(find_in_context(response.context, 'bundles')), 0)
37
38     def testSingleBundle(self):
39         defaults.project.save()
40         bundle = Bundle(owner = self.user, project = defaults.project)
41         bundle.save()
42         response = self.client.get('/user/bundles/')
43         self.failUnlessEqual(response.status_code, 200)
44         self.failUnlessEqual(
45                 len(find_in_context(response.context, 'bundles')), 1)
46
47     def tearDown(self):
48         self.user.delete()
49
50 class BundleTestBase(TestCase):
51     def setUp(self):
52         patch_names = ['testpatch1', 'testpatch2', 'testpatch3']
53         self.user = create_user()
54         self.client.login(username = self.user.username,
55                 password = self.user.username)
56         defaults.project.save()
57         self.bundle = Bundle(owner = self.user, project = defaults.project,
58                 name = 'testbundle')
59         self.bundle.save()
60         self.patches = []
61
62         for patch_name in patch_names:
63             patch = Patch(project = defaults.project,
64                                msgid = patch_name, name = patch_name,
65                                submitter = Person.objects.get(user = self.user),
66                                content = '')
67             patch.save()
68             self.patches.append(patch)
69
70     def tearDown(self):
71         for patch in self.patches:
72             patch.delete()
73         self.bundle.delete()
74         self.user.delete()
75
76 class BundleViewTest(BundleTestBase):
77
78     def testEmptyBundle(self):
79         response = self.client.get('/user/bundle/%d/' % self.bundle.id)
80         self.failUnlessEqual(response.status_code, 200)
81         page = find_in_context(response.context, 'page')
82         self.failUnlessEqual(len(page.object_list), 0)
83
84     def testNonEmptyBundle(self):
85         self.bundle.append_patch(self.patches[0])
86
87         response = self.client.get('/user/bundle/%d/' % self.bundle.id)
88         self.failUnlessEqual(response.status_code, 200)
89         page = find_in_context(response.context, 'page')
90         self.failUnlessEqual(len(page.object_list), 1)
91
92     def testBundleOrder(self):
93         for patch in self.patches:
94             self.bundle.append_patch(patch)
95
96         response = self.client.get('/user/bundle/%d/' % self.bundle.id)
97
98         pos = 0
99         for patch in self.patches:
100             next_pos = response.content.find(patch.name)
101             # ensure that this patch is after the previous
102             self.failUnless(next_pos > pos)
103             pos = next_pos
104
105         # reorder and recheck
106         i = 0
107         for patch in self.patches.__reversed__():
108             bundlepatch = BundlePatch.objects.get(bundle = self.bundle,
109                     patch = patch)
110             bundlepatch.order = i
111             bundlepatch.save()
112             i += 1
113
114         response = self.client.get('/user/bundle/%d/' % self.bundle.id)
115         pos = len(response.content)
116         for patch in self.patches:
117             next_pos = response.content.find(patch.name)
118             # ensure that this patch is now *before* the previous
119             self.failUnless(next_pos < pos)
120             pos = next_pos
121
122 class BundleCreateFromListTest(BundleTestBase):
123     def testCreateEmptyBundle(self):
124         newbundlename = 'testbundle-new'
125         params = {'form': 'patchlistform',
126                   'bundle_name': newbundlename,
127                   'action': 'Create',
128                   'project': defaults.project.id}
129
130         response = self.client.post(
131                 '/project/%s/list/' % defaults.project.linkname,
132                 params)
133
134         self.assertContains(response, 'Bundle %s created' % newbundlename)
135
136     def testCreateNonEmptyBundle(self):
137         newbundlename = 'testbundle-new'
138         patch = self.patches[0]
139
140         params = {'form': 'patchlistform',
141                   'bundle_name': newbundlename,
142                   'action': 'Create',
143                   'project': defaults.project.id,
144                   'patch_id:%d' % patch.id: 'checked'}
145
146         response = self.client.post(
147                 '/project/%s/list/' % defaults.project.linkname,
148                 params)
149
150         self.assertContains(response, 'Bundle %s created' % newbundlename)
151         self.assertContains(response, 'added to bundle %s' % newbundlename,
152             count = 1)
153
154         bundle = Bundle.objects.get(name = newbundlename)
155         self.failUnlessEqual(bundle.patches.count(), 1)
156         self.failUnlessEqual(bundle.patches.all()[0], patch)
157
158     def testCreateNonEmptyBundleEmptyName(self):
159         newbundlename = 'testbundle-new'
160         patch = self.patches[0]
161
162         n_bundles = Bundle.objects.count()
163
164         params = {'form': 'patchlistform',
165                   'bundle_name': '',
166                   'action': 'Create',
167                   'project': defaults.project.id,
168                   'patch_id:%d' % patch.id: 'checked'}
169
170         response = self.client.post(
171                 '/project/%s/list/' % defaults.project.linkname,
172                 params)
173
174         self.assertContains(response, 'No bundle name was specified',
175                 status_code = 200)
176
177         # test that no new bundles are present
178         self.failUnlessEqual(n_bundles, Bundle.objects.count())
179
180 class BundleCreateFromPatchTest(BundleTestBase):
181     def testCreateNonEmptyBundle(self):
182         newbundlename = 'testbundle-new'
183         patch = self.patches[0]
184
185         params = {'name': newbundlename,
186                   'action': 'createbundle'}
187
188         response = self.client.post('/patch/%d/' % patch.id, params)
189
190         self.assertContains(response,
191                 'Bundle %s created' % newbundlename)
192
193         bundle = Bundle.objects.get(name = newbundlename)
194         self.failUnlessEqual(bundle.patches.count(), 1)
195         self.failUnlessEqual(bundle.patches.all()[0], patch)
196
197
198 class BundleAddFromListTest(BundleTestBase):
199     def testAddToEmptyBundle(self):
200         patch = self.patches[0]
201         params = {'form': 'patchlistform',
202                   'action': 'Add',
203                   'project': defaults.project.id,
204                   'bundle_id': self.bundle.id,
205                   'patch_id:%d' % patch.id: 'checked'}
206
207         response = self.client.post(
208                 '/project/%s/list/' % defaults.project.linkname,
209                 params)
210
211         self.assertContains(response, 'added to bundle %s' % self.bundle.name,
212             count = 1)
213
214         self.failUnlessEqual(self.bundle.patches.count(), 1)
215         self.failUnlessEqual(self.bundle.patches.all()[0], patch)
216
217     def testAddToNonEmptyBundle(self):
218         self.bundle.append_patch(self.patches[0])
219         patch = self.patches[1]
220         params = {'form': 'patchlistform',
221                   'action': 'Add',
222                   'project': defaults.project.id,
223                   'bundle_id': self.bundle.id,
224                   'patch_id:%d' % patch.id: 'checked'}
225
226         response = self.client.post(
227                 '/project/%s/list/' % defaults.project.linkname,
228                 params)
229
230         self.assertContains(response, 'added to bundle %s' % self.bundle.name,
231             count = 1)
232
233         self.failUnlessEqual(self.bundle.patches.count(), 2)
234         self.failUnless(self.patches[0] in self.bundle.patches.all())
235         self.failUnless(self.patches[1] in self.bundle.patches.all())
236
237         # check order
238         bps = [ BundlePatch.objects.get(bundle = self.bundle,
239                                         patch = self.patches[i]) \
240                 for i in [0, 1] ]
241         self.failUnless(bps[0].order < bps[1].order)
242
243     def testAddDuplicate(self):
244         self.bundle.append_patch(self.patches[0])
245         count = self.bundle.patches.count()
246         patch = self.patches[0]
247
248         params = {'form': 'patchlistform',
249                   'action': 'Add',
250                   'project': defaults.project.id,
251                   'bundle_id': self.bundle.id,
252                   'patch_id:%d' % patch.id: 'checked'}
253
254         response = self.client.post(
255                 '/project/%s/list/' % defaults.project.linkname,
256                 params)
257
258         self.assertContains(response, 'Patch &#39;%s&#39; already in bundle' \
259                             % patch.name, count = 1, status_code = 200)
260
261         self.assertEquals(count, self.bundle.patches.count())
262
263     def testAddNewAndDuplicate(self):
264         self.bundle.append_patch(self.patches[0])
265         count = self.bundle.patches.count()
266         patch = self.patches[0]
267
268         params = {'form': 'patchlistform',
269                   'action': 'Add',
270                   'project': defaults.project.id,
271                   'bundle_id': self.bundle.id,
272                   'patch_id:%d' % patch.id: 'checked',
273                   'patch_id:%d' % self.patches[1].id: 'checked'}
274
275         response = self.client.post(
276                 '/project/%s/list/' % defaults.project.linkname,
277                 params)
278
279         self.assertContains(response, 'Patch &#39;%s&#39; already in bundle' \
280                             % patch.name, count = 1, status_code = 200)
281         self.assertContains(response, 'Patch &#39;%s&#39; added to bundle' \
282                             % self.patches[1].name, count = 1,
283                             status_code = 200)
284         self.assertEquals(count + 1, self.bundle.patches.count())
285
286 class BundleAddFromPatchTest(BundleTestBase):
287     def testAddToEmptyBundle(self):
288         patch = self.patches[0]
289         params = {'action': 'addtobundle',
290                   'bundle_id': self.bundle.id}
291
292         response = self.client.post('/patch/%d/' % patch.id, params)
293
294         self.assertContains(response,
295                 'added to bundle &quot;%s&quot;' % self.bundle.name,
296                 count = 1)
297
298         self.failUnlessEqual(self.bundle.patches.count(), 1)
299         self.failUnlessEqual(self.bundle.patches.all()[0], patch)
300
301     def testAddToNonEmptyBundle(self):
302         self.bundle.append_patch(self.patches[0])
303         patch = self.patches[1]
304         params = {'action': 'addtobundle',
305                   'bundle_id': self.bundle.id}
306
307         response = self.client.post('/patch/%d/' % patch.id, params)
308
309         self.assertContains(response,
310                 'added to bundle &quot;%s&quot;' % self.bundle.name,
311                 count = 1)
312
313         self.failUnlessEqual(self.bundle.patches.count(), 2)
314         self.failUnless(self.patches[0] in self.bundle.patches.all())
315         self.failUnless(self.patches[1] in self.bundle.patches.all())
316
317         # check order
318         bps = [ BundlePatch.objects.get(bundle = self.bundle,
319                                         patch = self.patches[i]) \
320                 for i in [0, 1] ]
321         self.failUnless(bps[0].order < bps[1].order)
322
323 class BundleReorderTest(BundleTestBase):
324     def setUp(self):
325         super(BundleReorderTest, self).setUp()
326         self.bundle.append_patch(self.patches[0])
327         self.bundle.append_patch(self.patches[1])
328         self.bundle.append_patch(self.patches[2])
329
330     def testBundleReorder(self):
331         bundlepatch = BundlePatch.objects.get(bundle = self.bundle,
332                 patch = self.patches[0])
333
334         neworder = [self.patches[2], self.patches[0], self.patches[1]]
335         neworder_ids = [ p.id for p in neworder ]
336
337         params = {'form': 'reorderform',
338                   'order_start': bundlepatch.order,
339                   'neworder': neworder_ids}
340
341         response = self.client.post('/user/bundle/%d/' % self.bundle.id,
342                                     params)
343
344         self.failUnlessEqual(response.status_code, 200)
345
346         bundle_ids = [ bp.patch.id for bp in \
347                         BundlePatch.objects.filter(bundle = self.bundle) \
348                         .order_by('order') ]
349
350         self.failUnlessEqual(neworder_ids, bundle_ids)
351
352