ccanlint: Report failures with --summary
authorDavid Gibson <david@gibson.dropbear.id.au>
Mon, 1 Feb 2016 11:50:45 +0000 (22:50 +1100)
committerDavid Gibson <david@gibson.dropbear.id.au>
Wed, 3 Feb 2016 06:10:12 +0000 (17:10 +1100)
When run in --summary mode ccanlint doesn't actually report whether it
passed or failed in the message .  In particular this means that when make
check is run with -j, it can be hard to tell which modules failed.

This adds a more obvious failure message.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
tools/ccanlint/ccanlint.c

index 1e5cf2759c0236a2b329c0a5f00e4ebe35584649..e2a687e06c410751996235e82192405726baa654 100644 (file)
@@ -577,6 +577,8 @@ static bool run_tests(struct dgraph_node *all,
        if (deps_fail_ignore && non_ccan_deps && build_failed) {
                comment = " (missing non-ccan dependencies?)";
                run.pass = true;
+       } else if (!run.pass) {
+               comment = " FAIL!";
        }
        printf("%sTotal score: %u/%u%s\n",
               prefix, run.score, run.total, comment);