From: David Gibson <david@gibson.dropbear.id.au>
Date: Mon, 1 Feb 2016 11:50:45 +0000 (+1100)
Subject: ccanlint: Report failures with --summary
X-Git-Url: http://git.ozlabs.org/?p=ccan;a=commitdiff_plain;h=55e9c20591323bc8d197394d78169e0347d583f1

ccanlint: Report failures with --summary

When run in --summary mode ccanlint doesn't actually report whether it
passed or failed in the message .  In particular this means that when make
check is run with -j, it can be hard to tell which modules failed.

This adds a more obvious failure message.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---

diff --git a/tools/ccanlint/ccanlint.c b/tools/ccanlint/ccanlint.c
index 1e5cf275..e2a687e0 100644
--- a/tools/ccanlint/ccanlint.c
+++ b/tools/ccanlint/ccanlint.c
@@ -577,6 +577,8 @@ static bool run_tests(struct dgraph_node *all,
 	if (deps_fail_ignore && non_ccan_deps && build_failed) {
 		comment = " (missing non-ccan dependencies?)";
 		run.pass = true;
+	} else if (!run.pass) {
+		comment = " FAIL!";
 	}
 	printf("%sTotal score: %u/%u%s\n",
 	       prefix, run.score, run.total, comment);