1 #include <tools/ccanlint/ccanlint.h>
2 #include <tools/tools.h>
3 #include <ccan/talloc/talloc.h>
4 #include <ccan/str/str.h>
5 #include <ccan/foreach/foreach.h>
6 #include <ccan/str_talloc/str_talloc.h>
7 #include "tests_pass.h"
20 /* Note: we already test safe_mode in run_tests.c */
21 static const char *can_run_vg(struct manifest *m)
24 return talloc_asprintf(m, "No valgrind support");
28 static void do_leakcheck_vg(struct manifest *m,
29 unsigned int *timeleft,
32 static struct ccanlint tests_pass_valgrind_noleaks = {
33 .key = "tests_pass_valgrind_noleaks",
34 .name = "Module's run and api tests have no memory leaks",
35 .check = do_leakcheck_vg,
36 .takes_options = true,
37 .needs = "tests_pass_valgrind"
39 REGISTER_TEST(tests_pass_valgrind_noleaks);
43 ==2749== Conditional jump or move depends on uninitialised value(s)
44 ==2749== at 0x4026C60: strnlen (mc_replace_strmem.c:263)
45 ==2749== by 0x40850E3: vfprintf (vfprintf.c:1614)
46 ==2749== by 0x408EACF: printf (printf.c:35)
47 ==2749== by 0x8048465: main (in /tmp/foo)
49 ==2749== 1 bytes in 1 blocks are definitely lost in loss record 1 of 1
50 ==2749== at 0x4025BD3: malloc (vg_replace_malloc.c:236)
51 ==2749== by 0x8048444: main (in /tmp/foo)
55 static bool blank_line(const char *line)
57 return line[strspn(line, "=0123456789 ")] == '\0';
60 /* Removes matching lines from lines array, returns them. FIXME: Hacky. */
61 static char **extract_matching(const char *prefix, char *lines[])
63 unsigned int i, num_ret = 0;
64 char **ret = talloc_array(lines, char *, talloc_array_length(lines));
66 for (i = 0; i < talloc_array_length(lines) - 1; i++) {
67 if (strstarts(lines[i], prefix)) {
68 ret[num_ret++] = talloc_steal(ret, lines[i]);
69 lines[i] = (char *)"";
72 ret[num_ret++] = NULL;
74 /* Make sure length is correct! */
75 return talloc_realloc(NULL, ret, char *, num_ret);
78 static char *get_leaks(char *lines[], char **errs)
80 char *leaks = talloc_strdup(lines, "");
83 for (i = 0; i < talloc_array_length(lines) - 1; i++) {
84 if (strstr(lines[i], " lost ")) {
86 if (strstr(lines[i], " definitely lost ")) {
87 /* Definite leak, report. */
88 while (lines[i] && !blank_line(lines[i])) {
89 leaks = talloc_append_string(leaks,
91 leaks = talloc_append_string(leaks,
96 /* Not definite, ignore. */
97 while (lines[i] && !blank_line(lines[i]))
101 while (lines[i] && !blank_line(lines[i])) {
102 *errs = talloc_append_string(*errs, lines[i]);
103 *errs = talloc_append_string(*errs, "\n");
111 /* Returns leaks, and sets errs[] */
112 static char *analyze_output(const char *output, char **errs)
114 char *leaks = talloc_strdup(output, "");
116 char **lines = strsplit(output, output, "\n");
118 *errs = talloc_strdup(output, "");
119 for (i = 0; i < talloc_array_length(lines) - 1; i++) {
120 unsigned int preflen = strspn(lines[i], "=0123456789");
121 char *prefix, **sublines;
123 /* Ignore erased lines, or weird stuff. */
127 prefix = talloc_strndup(output, lines[i], preflen);
128 sublines = extract_matching(prefix, lines);
130 leaks = talloc_append_string(leaks, get_leaks(sublines, errs));
144 static const char *concat(struct score *score, char *bits[])
147 char *ret = talloc_strdup(score, "");
149 for (i = 0; bits[i]; i++) {
151 ret = talloc_append_string(ret, " ");
152 ret = talloc_append_string(ret, bits[i]);
157 /* FIXME: Run examples, too! */
158 static void do_run_tests_vg(struct manifest *m,
159 unsigned int *timeleft,
163 struct list_head *list;
165 /* This is slow, so we run once but grab leak info. */
168 foreach_ptr(list, &m->run_tests, &m->api_tests) {
169 list_for_each(list, i, list) {
174 options = concat(score,
175 per_file_options(&tests_pass_valgrind,
177 if (streq(options, "FAIL")) {
182 output = talloc_grab_file(i, i->valgrind_log, NULL);
183 /* No valgrind errors? */
184 if (!output || output[0] == '\0') {
188 i->leak_info = analyze_output(output, &err);
191 score_file_error(score, i, 0, "%s", err);
199 static void do_leakcheck_vg(struct manifest *m,
200 unsigned int *timeleft,
204 struct list_head *list;
208 foreach_ptr(list, &m->run_tests, &m->api_tests) {
209 list_for_each(list, i, list) {
210 options = per_file_options(&tests_pass_valgrind_noleaks,
213 if (streq(options[0], "FAIL")) {
217 errx(1, "Unknown leakcheck options '%s'",
222 score_file_error(score, i, 0, "%s",
229 /* FIXME: We don't fail for this, since many tests leak. */
236 /* Gcc's warn_unused_result is fascist bullshit. */
237 #define doesnt_matter()
239 static void run_under_debugger_vg(struct manifest *m, struct score *score)
241 struct file_error *first;
244 /* Don't ask anything if they suppressed tests. */
248 if (!ask("Should I run the first failing test under the debugger?"))
251 first = list_top(&score->per_file_errors, struct file_error, list);
252 command = talloc_asprintf(m, "valgrind --leak-check=full --db-attach=yes%s %s",
254 per_file_options(&tests_pass_valgrind,
256 first->file->compiled[COMPILE_NORMAL]);
261 struct ccanlint tests_pass_valgrind = {
262 .key = "tests_pass_valgrind",
263 .name = "Module's run and api tests succeed under valgrind",
264 .can_run = can_run_vg,
265 .check = do_run_tests_vg,
266 .handle = run_under_debugger_vg,
267 .takes_options = true,
268 .needs = "tests_pass"
270 REGISTER_TEST(tests_pass_valgrind);