]> git.ozlabs.org Git - ppp.git/commit
pppd/Makefile.linux: Fix reproducibility issue with differing make versions (#234)
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 8 Jan 2021 01:41:42 +0000 (01:41 +0000)
committerGitHub <noreply@github.com>
Fri, 8 Jan 2021 01:41:42 +0000 (12:41 +1100)
commitb4430f7092ececdff2504d5f3393a4c6528c3686
treedafd1b11e56048a4aad43d1e36ef8fa63d087e9f
parent4fb319056f168bb8379865b91b4fd3e1ada73f1e
pppd/Makefile.linux: Fix reproducibility issue with differing make versions (#234)

We were seeing reproducibility issues where one host would use the internal
logwtmp wrapper, another would use the one in libutil. The issue was that in
some cases the "\#include" was making it to CC, in others, "#include". The
issue seems to be related to shell escaping.

The root cause looks to be:
http://git.savannah.gnu.org/cgit/make.git/commit/?id=c6966b323811c37acedff05b576b907b06aea5f4

Instead of relying on shell quoting, use make to indirect the variable
and avoid the problem.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
pppd/Makefile.linux