]> git.ozlabs.org Git - ppp.git/commit
projects / ppp.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 93fd8a0) | patch
plugins/radius: Use snprintf in rc_mksid
authorPaul Mackerras <paulus@ozlabs.org>
Sat, 10 Jul 2021 00:29:55 +0000 (10:29 +1000)
committerPaul Mackerras <paulus@ozlabs.org>
Sat, 10 Jul 2021 00:29:55 +0000 (10:29 +1000)
commit301230f8fde94b5b80e9dfba51816ede340e6b64
tree50c712e404d146f97cb96921e05fa7d9a6cbc6c6tree | snapshot (tar.gz zip)
parent93fd8a0916ef6bc2a33b76bf165a847355343693commit | diff
plugins/radius: Use snprintf in rc_mksid

Commit 858976b1fc31 ("radius: Prevent buffer overflow in rc_mksid()")
changed sprintf to slprintf to avoid a possible buffer overflow.
However, this introduced a bug because slprintf does not currently
handle the %lX and %hX formats.  Use snprintf instead, which does, as
we are not using any of the custom formats that slprintf handles in
this instance.

Reported-by: Adrian Ban <devel@easynet.dev>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
pppd/plugins/radius/util.c diff | blob | history
PPP (Point-to-Point Protocol) implementation for Linux and Solaris