]> git.ozlabs.org Git - ppp.git/blobdiff - pppd/lcp.c
Fix the rcsid's for non-ansi compilers
[ppp.git] / pppd / lcp.c
index 48c1b5168b64f687d5e06cc5315b47485b4147ad..95b13b33572f2cd5120dc1c927e8670bae77137c 100644 (file)
@@ -17,9 +17,7 @@
  * WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE.
  */
 
-#ifndef lint
-static char rcsid[] = "$Id: lcp.c,v 1.30 1997/04/30 05:52:59 paulus Exp $";
-#endif
+#define RCSID  "$Id: lcp.c,v 1.44 1999/08/13 06:46:14 paulus Exp $";
 
 /*
  * TODO:
@@ -27,13 +25,7 @@ static char rcsid[] = "$Id: lcp.c,v 1.30 1997/04/30 05:52:59 paulus Exp $";
 
 #include <stdio.h>
 #include <string.h>
-#include <syslog.h>
-#include <assert.h>
-#include <sys/ioctl.h>
-#include <sys/types.h>
-#include <sys/socket.h>
-#include <sys/time.h>
-#include <netinet/in.h>
+#include <stdlib.h>
 
 #include "pppd.h"
 #include "fsm.h"
@@ -41,6 +33,83 @@ static char rcsid[] = "$Id: lcp.c,v 1.30 1997/04/30 05:52:59 paulus Exp $";
 #include "chap.h"
 #include "magic.h"
 
+static const char rcsid[] = RCSID;
+
+/*
+ * LCP-related command-line options.
+ */
+int    lcp_echo_interval = 0;  /* Interval between LCP echo-requests */
+int    lcp_echo_fails = 0;     /* Tolerance to unanswered echo-requests */
+bool   lax_recv = 0;           /* accept control chars in asyncmap */
+
+static int setescape __P((char **));
+
+static option_t lcp_option_list[] = {
+    /* LCP options */
+    { "noaccomp", o_bool, &lcp_wantoptions[0].neg_accompression,
+      "Disable address/control compression",
+      OPT_A2COPY, &lcp_allowoptions[0].neg_accompression },
+    { "-ac", o_bool, &lcp_wantoptions[0].neg_accompression,
+      "Disable address/control compression",
+      OPT_A2COPY, &lcp_allowoptions[0].neg_accompression },
+    { "default-asyncmap", o_bool, &lcp_wantoptions[0].neg_asyncmap,
+      "Disable asyncmap negotiation",
+      OPT_A2COPY, &lcp_allowoptions[0].neg_asyncmap },
+    { "-am", o_bool, &lcp_wantoptions[0].neg_asyncmap,
+      "Disable asyncmap negotiation",
+      OPT_A2COPY, &lcp_allowoptions[0].neg_asyncmap },
+    { "asyncmap", o_uint32, &lcp_wantoptions[0].asyncmap,
+      "Set asyncmap (for received packets)",
+      OPT_OR, &lcp_wantoptions[0].neg_asyncmap },
+    { "-as", o_uint32, &lcp_wantoptions[0].asyncmap,
+      "Set asyncmap (for received packets)",
+      OPT_OR, &lcp_wantoptions[0].neg_asyncmap },
+    { "nomagic", o_bool, &lcp_wantoptions[0].neg_magicnumber,
+      "Disable magic number negotiation (looped-back line detection)",
+      OPT_A2COPY, &lcp_allowoptions[0].neg_magicnumber },
+    { "-mn", o_bool, &lcp_wantoptions[0].neg_magicnumber,
+      "Disable magic number negotiation (looped-back line detection)",
+      OPT_A2COPY, &lcp_allowoptions[0].neg_magicnumber },
+    { "default-mru", o_bool, &lcp_wantoptions[0].neg_mru,
+      "Disable MRU negotiation (use default 1500)",
+      OPT_A2COPY, &lcp_allowoptions[0].neg_mru },
+    { "-mru", o_bool, &lcp_wantoptions[0].neg_mru,
+      "Disable MRU negotiation (use default 1500)",
+      OPT_A2COPY, &lcp_allowoptions[0].neg_mru },
+    { "mru", o_int, &lcp_wantoptions[0].mru,
+      "Set MRU (maximum received packet size) for negotiation",
+      0, &lcp_wantoptions[0].neg_mru },
+    { "nopcomp", o_bool, &lcp_wantoptions[0].neg_pcompression,
+      "Disable protocol field compression",
+      OPT_A2COPY, &lcp_allowoptions[0].neg_pcompression },
+    { "-pc", o_bool, &lcp_wantoptions[0].neg_pcompression,
+      "Disable protocol field compression",
+      OPT_A2COPY, &lcp_allowoptions[0].neg_pcompression },
+    { "-p", o_bool, &lcp_wantoptions[0].passive,
+      "Set passive mode", 1 },
+    { "passive", o_bool, &lcp_wantoptions[0].passive,
+      "Set passive mode", 1 },
+    { "silent", o_bool, &lcp_wantoptions[0].silent,
+      "Set silent mode", 1 },
+    { "escape", o_special, setescape,
+      "List of character codes to escape on transmission" },
+    { "lcp-echo-failure", o_int, &lcp_echo_fails,
+      "Set number of consecutive echo failures to indicate link failure" },
+    { "lcp-echo-interval", o_int, &lcp_echo_interval,
+      "Set time in seconds between LCP echo requests" },
+    { "lcp-restart", o_int, &lcp_fsm[0].timeouttime,
+      "Set time in seconds between LCP retransmissions" },
+    { "lcp-max-terminate", o_int, &lcp_fsm[0].maxtermtransmits,
+      "Set maximum number of LCP terminate-request transmissions" },
+    { "lcp-max-configure", o_int, &lcp_fsm[0].maxconfreqtransmits,
+      "Set maximum number of LCP configure-request transmissions" },
+    { "lcp-max-failure", o_int, &lcp_fsm[0].maxnakloops,
+      "Set limit on number of LCP configure-naks" },
+    { "receive-all", o_bool, &lax_recv,
+      "Accept all received control characters", 1 },
+    {NULL}
+};
+
 /* global vars */
 fsm lcp_fsm[NUM_PPP];                  /* LCP fsm structure (global)*/
 lcp_options lcp_wantoptions[NUM_PPP];  /* Options that we want to request */
@@ -51,7 +120,7 @@ u_int32_t xmit_accm[NUM_PPP][8];             /* extended transmit ACCM */
 
 static u_int32_t lcp_echos_pending = 0;        /* Number of outstanding echo msgs */
 static u_int32_t lcp_echo_number   = 0;        /* ID number of next echo frame */
-static u_int32_t lcp_echo_timer_running = 0;  /* TRUE if a timer is running */
+static u_int32_t lcp_echo_timer_running = 0;  /* set if a timer is running */
 
 static u_char nak_buffer[PPP_MRU];     /* where we construct a nak packet */
 
@@ -127,6 +196,8 @@ struct protent lcp_protent = {
     1,
     "LCP",
     NULL,
+    lcp_option_list,
+    NULL,
     NULL,
     NULL
 };
@@ -148,6 +219,37 @@ int lcp_loopbackfail = DEFLOOPBACKFAIL;
                         (x) == CONFNAK ? "NAK" : "REJ")
 
 
+/*
+ * setescape - add chars to the set we escape on transmission.
+ */
+static int
+setescape(argv)
+    char **argv;
+{
+    int n, ret;
+    char *p, *endp;
+
+    p = *argv;
+    ret = 1;
+    while (*p) {
+       n = strtol(p, &endp, 16);
+       if (p == endp) {
+           option_error("escape parameter contains invalid hex number '%s'",
+                        p);
+           return 0;
+       }
+       p = endp;
+       if (n < 0 || n == 0x5E || n > 0xFF) {
+           option_error("can't escape character 0x%x", n);
+           ret = 0;
+       } else
+           xmit_accm[0][n >> 5] |= 1 << (n & 0x1F);
+       while (*p == ',' || *p == ' ')
+           ++p;
+    }
+    return ret;
+}
+
 /*
  * lcp_init - Initialize LCP.
  */
@@ -171,7 +273,7 @@ lcp_init(unit)
                                           implementations */
     wo->neg_mru = 1;
     wo->mru = DEFMRU;
-    wo->neg_asyncmap = 0;
+    wo->neg_asyncmap = 1;
     wo->asyncmap = 0;
     wo->neg_chap = 0;                  /* Set to 1 on server */
     wo->neg_upap = 0;                  /* Set to 1 on server */
@@ -266,7 +368,7 @@ lcp_lowerup(unit)
      */
     ppp_set_xaccm(unit, xmit_accm[unit]);
     ppp_send_config(unit, PPP_MRU, 0xffffffff, 0, 0);
-    ppp_recv_config(unit, PPP_MRU, 0x00000000,
+    ppp_recv_config(unit, PPP_MRU, (lax_recv? 0: 0xffffffff),
                    wo->neg_pcompression, wo->neg_accompression);
     peer_mru[unit] = PPP_MRU;
     lcp_allowoptions[unit].asyncmap = xmit_accm[unit][0];
@@ -321,7 +423,6 @@ lcp_extcode(f, code, id, inp, len)
     case ECHOREQ:
        if (f->state != OPENED)
            break;
-       LCPDEBUG((LOG_INFO, "lcp: Echo-Request, Rcvd id %d", id));
        magp = inp;
        PUTLONG(lcp_gotoptions[f->unit].magicnumber, magp);
        fsm_sdata(f, ECHOREP, id, inp, len);
@@ -356,27 +457,19 @@ lcp_rprotrej(f, inp, len)
     struct protent *protp;
     u_short prot;
 
-    LCPDEBUG((LOG_INFO, "lcp_rprotrej."));
-
     if (len < sizeof (u_short)) {
-       LCPDEBUG((LOG_INFO,
-                 "lcp_rprotrej: Rcvd short Protocol-Reject packet!"));
+       LCPDEBUG(("lcp_rprotrej: Rcvd short Protocol-Reject packet!"));
        return;
     }
 
     GETSHORT(prot, inp);
 
-    LCPDEBUG((LOG_INFO,
-             "lcp_rprotrej: Rcvd Protocol-Reject packet for %x!",
-             prot));
-
     /*
      * Protocol-Reject packets received in any state other than the LCP
      * OPENED state SHOULD be silently discarded.
      */
     if( f->state != OPENED ){
-       LCPDEBUG((LOG_INFO, "Protocol-Reject discarded: LCP in state %d",
-                 f->state));
+       LCPDEBUG(("Protocol-Reject discarded: LCP in state %d", f->state));
        return;
     }
 
@@ -389,8 +482,7 @@ lcp_rprotrej(f, inp, len)
            return;
        }
 
-    syslog(LOG_WARNING, "Protocol-Reject for unsupported protocol 0x%x",
-          prot);
+    warn("Protocol-Reject for unsupported protocol 0x%x", prot);
 }
 
 
@@ -405,8 +497,7 @@ lcp_protrej(unit)
     /*
      * Can't reject LCP!
      */
-    LCPDEBUG((LOG_WARNING,
-             "lcp_protrej: Received Protocol-Reject for LCP!"));
+    error("Received Protocol-Reject for LCP!");
     fsm_protreject(&lcp_fsm[unit]);
 }
 
@@ -541,7 +632,7 @@ lcp_addci(f, ucp, lenp)
 
     if (ucp - start_ucp != *lenp) {
        /* this should never happen, because peer_mtu should be 1500 */
-       syslog(LOG_ERR, "Bug in lcp_addci: wrong length");
+       error("Bug in lcp_addci: wrong length");
     }
 }
 
@@ -670,7 +761,7 @@ lcp_ackci(f, p, len)
        goto bad;
     return (1);
 bad:
-    LCPDEBUG((LOG_WARNING, "lcp_acki: received bad Ack!"));
+    LCPDEBUG(("lcp_acki: received bad Ack!"));
     return (0);
 }
 
@@ -785,7 +876,7 @@ lcp_nakci(f, p, len)
      */
     if (go->neg_mru && go->mru != DEFMRU) {
        NAKCISHORT(CI_MRU, neg_mru,
-                  if (cishort <= wo->mru || cishort < DEFMRU)
+                  if (cishort <= wo->mru || cishort <= DEFMRU)
                       try.mru = cishort;
                   );
     }
@@ -956,18 +1047,16 @@ lcp_nakci(f, p, len)
        p = next;
     }
 
-    /* If there is still anything left, this packet is bad. */
-    if (len != 0)
-       goto bad;
-
     /*
      * OK, the Nak is good.  Now we can update state.
+     * If there are any options left we ignore them.
      */
     if (f->state != OPENED) {
        if (looped_back) {
            if (++try.numloops >= lcp_loopbackfail) {
-               syslog(LOG_NOTICE, "Serial line is looped back.");
+               notice("Serial line is looped back.");
                lcp_close(f->unit, "Loopback detected");
+               status = EXIT_LOOPBACK;
            }
        } else
            try.numloops = 0;
@@ -977,7 +1066,7 @@ lcp_nakci(f, p, len)
     return 1;
 
 bad:
-    LCPDEBUG((LOG_WARNING, "lcp_nakci: received bad Nak!"));
+    LCPDEBUG(("lcp_nakci: received bad Nak!"));
     return 0;
 }
 
@@ -1018,7 +1107,6 @@ lcp_rejci(f, p, len)
        len -= CILEN_VOID; \
        INCPTR(CILEN_VOID, p); \
        try.neg = 0; \
-       LCPDEBUG((LOG_INFO, "lcp_rejci rejected void opt %d", opt)); \
     }
 #define REJCISHORT(opt, neg, val) \
     if (go->neg && \
@@ -1032,7 +1120,6 @@ lcp_rejci(f, p, len)
        if (cishort != val) \
            goto bad; \
        try.neg = 0; \
-       LCPDEBUG((LOG_INFO,"lcp_rejci rejected short opt %d", opt)); \
     }
 #define REJCICHAP(opt, neg, val, digest) \
     if (go->neg && \
@@ -1048,7 +1135,6 @@ lcp_rejci(f, p, len)
            goto bad; \
        try.neg = 0; \
        try.neg_upap = 0; \
-       LCPDEBUG((LOG_INFO,"lcp_rejci rejected chap opt %d", opt)); \
     }
 #define REJCILONG(opt, neg, val) \
     if (go->neg && \
@@ -1062,7 +1148,6 @@ lcp_rejci(f, p, len)
        if (cilong != val) \
            goto bad; \
        try.neg = 0; \
-       LCPDEBUG((LOG_INFO,"lcp_rejci rejected long opt %d", opt)); \
     }
 #define REJCILQR(opt, neg, val) \
     if (go->neg && \
@@ -1077,7 +1162,6 @@ lcp_rejci(f, p, len)
        if (cishort != PPP_LQR || cilong != val) \
            goto bad; \
        try.neg = 0; \
-       LCPDEBUG((LOG_INFO,"lcp_rejci rejected LQR opt %d", opt)); \
     }
 #define REJCICBCP(opt, neg, val) \
     if (go->neg && \
@@ -1091,7 +1175,6 @@ lcp_rejci(f, p, len)
        if (cichar != val) \
            goto bad; \
        try.neg = 0; \
-       LCPDEBUG((LOG_INFO,"lcp_rejci rejected Callback opt %d", opt)); \
     }
 
     REJCISHORT(CI_MRU, neg_mru, go->mru);
@@ -1119,7 +1202,7 @@ lcp_rejci(f, p, len)
     return 1;
 
 bad:
-    LCPDEBUG((LOG_WARNING, "lcp_rejci: received bad Reject!"));
+    LCPDEBUG(("lcp_rejci: received bad Reject!"));
     return 0;
 }
 
@@ -1169,7 +1252,7 @@ lcp_reqci(f, inp, lenp, reject_if_disagree)
        if (l < 2 ||                    /* Not enough data for CI header or */
            p[1] < 2 ||                 /*  CI length too small or */
            p[1] > l) {                 /*  CI length too big? */
-           LCPDEBUG((LOG_WARNING, "lcp_reqci: bad CI length!"));
+           LCPDEBUG(("lcp_reqci: bad CI length!"));
            orc = CONFREJ;              /* Reject bad CI */
            cilen = l;                  /* Reject till end of packet */
            l = 0;                      /* Don't loop again */
@@ -1183,14 +1266,12 @@ lcp_reqci(f, inp, lenp, reject_if_disagree)
 
        switch (citype) {               /* Check CI type */
        case CI_MRU:
-           LCPDEBUG((LOG_INFO, "lcp_reqci: rcvd MRU"));
            if (!ao->neg_mru ||         /* Allow option? */
                cilen != CILEN_SHORT) { /* Check CI length */
                orc = CONFREJ;          /* Reject CI */
                break;
            }
            GETSHORT(cishort, p);       /* Parse MRU */
-           LCPDEBUG((LOG_INFO, "(%d)", cishort));
 
            /*
             * He must be able to receive at least our minimum.
@@ -1209,14 +1290,12 @@ lcp_reqci(f, inp, lenp, reject_if_disagree)
            break;
 
        case CI_ASYNCMAP:
-           LCPDEBUG((LOG_INFO, "lcp_reqci: rcvd ASYNCMAP"));
            if (!ao->neg_asyncmap ||
                cilen != CILEN_LONG) {
                orc = CONFREJ;
                break;
            }
            GETLONG(cilong, p);
-           LCPDEBUG((LOG_INFO, "(%x)", (unsigned int) cilong));
 
            /*
             * Asyncmap must have set at least the bits
@@ -1234,7 +1313,6 @@ lcp_reqci(f, inp, lenp, reject_if_disagree)
            break;
 
        case CI_AUTHTYPE:
-           LCPDEBUG((LOG_INFO, "lcp_reqci: rcvd AUTHTYPE"));
            if (cilen < CILEN_SHORT ||
                !(ao->neg_upap || ao->neg_chap)) {
                /*
@@ -1244,7 +1322,6 @@ lcp_reqci(f, inp, lenp, reject_if_disagree)
                break;
            }
            GETSHORT(cishort, p);
-           LCPDEBUG((LOG_INFO, "(%x)", cishort));
 
            /*
             * Authtype must be UPAP or CHAP.
@@ -1260,8 +1337,7 @@ lcp_reqci(f, inp, lenp, reject_if_disagree)
            if (cishort == PPP_PAP) {
                if (ho->neg_chap ||     /* we've already accepted CHAP */
                    cilen != CILEN_SHORT) {
-                   LCPDEBUG((LOG_WARNING,
-                             "lcp_reqci: rcvd AUTHTYPE PAP, rejecting..."));
+                   LCPDEBUG(("lcp_reqci: rcvd AUTHTYPE PAP, rejecting..."));
                    orc = CONFREJ;
                    break;
                }
@@ -1279,8 +1355,7 @@ lcp_reqci(f, inp, lenp, reject_if_disagree)
            if (cishort == PPP_CHAP) {
                if (ho->neg_upap ||     /* we've already accepted PAP */
                    cilen != CILEN_CHAP) {
-                   LCPDEBUG((LOG_INFO,
-                             "lcp_reqci: rcvd AUTHTYPE CHAP, rejecting..."));
+                   LCPDEBUG(("lcp_reqci: rcvd AUTHTYPE CHAP, rejecting..."));
                    orc = CONFREJ;
                    break;
                }
@@ -1327,7 +1402,6 @@ lcp_reqci(f, inp, lenp, reject_if_disagree)
            break;
 
        case CI_QUALITY:
-           LCPDEBUG((LOG_INFO, "lcp_reqci: rcvd QUALITY"));
            if (!ao->neg_lqr ||
                cilen != CILEN_LQR) {
                orc = CONFREJ;
@@ -1336,7 +1410,6 @@ lcp_reqci(f, inp, lenp, reject_if_disagree)
 
            GETSHORT(cishort, p);
            GETLONG(cilong, p);
-           LCPDEBUG((LOG_INFO, "(%x %x)", cishort, (unsigned int) cilong));
 
            /*
             * Check the protocol and the reporting period.
@@ -1353,14 +1426,12 @@ lcp_reqci(f, inp, lenp, reject_if_disagree)
            break;
 
        case CI_MAGICNUMBER:
-           LCPDEBUG((LOG_INFO, "lcp_reqci: rcvd MAGICNUMBER"));
            if (!(ao->neg_magicnumber || go->neg_magicnumber) ||
                cilen != CILEN_LONG) {
                orc = CONFREJ;
                break;
            }
            GETLONG(cilong, p);
-           LCPDEBUG((LOG_INFO, "(%x)", (unsigned int) cilong));
 
            /*
             * He must have a different magic number.
@@ -1380,7 +1451,6 @@ lcp_reqci(f, inp, lenp, reject_if_disagree)
 
 
        case CI_PCOMPRESSION:
-           LCPDEBUG((LOG_INFO, "lcp_reqci: rcvd PCOMPRESSION"));
            if (!ao->neg_pcompression ||
                cilen != CILEN_VOID) {
                orc = CONFREJ;
@@ -1390,7 +1460,6 @@ lcp_reqci(f, inp, lenp, reject_if_disagree)
            break;
 
        case CI_ACCOMPRESSION:
-           LCPDEBUG((LOG_INFO, "lcp_reqci: rcvd ACCOMPRESSION"));
            if (!ao->neg_accompression ||
                cilen != CILEN_VOID) {
                orc = CONFREJ;
@@ -1400,14 +1469,12 @@ lcp_reqci(f, inp, lenp, reject_if_disagree)
            break;
 
        default:
-           LCPDEBUG((LOG_INFO, "lcp_reqci: rcvd unknown option %d",
-                     citype));
+           LCPDEBUG(("lcp_reqci: rcvd unknown option %d", citype));
            orc = CONFREJ;
            break;
        }
 
 endswitch:
-       LCPDEBUG((LOG_INFO, " (%s)", CODENAME(orc)));
        if (orc == CONFACK &&           /* Good CI */
            rc != CONFACK)              /*  but prior CI wasnt? */
            continue;                   /* Don't send this one */
@@ -1453,7 +1520,7 @@ endswitch:
        break;
     }
 
-    LCPDEBUG((LOG_INFO, "lcp_reqci: returning CONF%s.", CODENAME(rc)));
+    LCPDEBUG(("lcp_reqci: returning CONF%s.", CODENAME(rc)));
     return (rc);                       /* Return final code */
 }
 
@@ -1484,13 +1551,8 @@ lcp_up(f)
     ppp_send_config(f->unit, MIN(ao->mru, (ho->neg_mru? ho->mru: PPP_MRU)),
                    (ho->neg_asyncmap? ho->asyncmap: 0xffffffff),
                    ho->neg_pcompression, ho->neg_accompression);
-    /*
-     * If the asyncmap hasn't been negotiated, we really should
-     * set the receive asyncmap to ffffffff, but we set it to 0
-     * for backwards contemptibility.
-     */
     ppp_recv_config(f->unit, (go->neg_mru? MAX(wo->mru, go->mru): PPP_MRU),
-                   (go->neg_asyncmap? go->asyncmap: 0x00000000),
+                   (lax_recv? 0: go->neg_asyncmap? go->asyncmap: 0xffffffff),
                    go->neg_pcompression, go->neg_accompression);
 
     if (ho->neg_mru)
@@ -1519,7 +1581,7 @@ lcp_down(f)
 
     ppp_send_config(f->unit, PPP_MRU, 0xffffffff, 0, 0);
     ppp_recv_config(f->unit, PPP_MRU,
-                   (go->neg_asyncmap? go->asyncmap: 0x00000000),
+                   (go->neg_asyncmap? go->asyncmap: 0xffffffff),
                    go->neg_pcompression, go->neg_accompression);
     peer_mru[f->unit] = PPP_MRU;
 }
@@ -1625,6 +1687,20 @@ lcp_printpkt(p, plen, printer, arg)
                        break;
                    case PPP_CHAP:
                        printer(arg, "chap");
+                       if (p < optend) {
+                           switch (*p) {
+                           case CHAP_DIGEST_MD5:
+                               printer(arg, " MD5");
+                               ++p;
+                               break;
+#ifdef CHAPMS
+                           case CHAP_MICROSOFT:
+                               printer(arg, " m$oft");
+                               ++p;
+                               break;
+#endif
+                           }
+                       }
                        break;
                    default:
                        printer(arg, "0x%x", cishort);
@@ -1649,7 +1725,7 @@ lcp_printpkt(p, plen, printer, arg)
                if (olen >= CILEN_CHAR) {
                    p += 2;
                    printer(arg, "callback ");
-                   GETSHORT(cishort, p);
+                   GETCHAR(cishort, p);
                    switch (cishort) {
                    case CBCP_OPT:
                        printer(arg, "CBCP");
@@ -1727,9 +1803,10 @@ void LcpLinkFailure (f)
     fsm *f;
 {
     if (f->state == OPENED) {
-       syslog(LOG_INFO, "No response to %d echo-requests", lcp_echos_pending);
-        syslog(LOG_NOTICE, "Serial link appears to be disconnected.");
+       info("No response to %d echo-requests", lcp_echos_pending);
+        notice("Serial link appears to be disconnected.");
         lcp_close(f->unit, "Peer not responding");
+       status = EXIT_PEER_DEAD;
     }
 }
 
@@ -1742,11 +1819,14 @@ LcpEchoCheck (f)
     fsm *f;
 {
     LcpSendEchoRequest (f);
+    if (f->state != OPENED)
+       return;
 
     /*
      * Start the timer for the next interval.
      */
-    assert (lcp_echo_timer_running==0);
+    if (lcp_echo_timer_running)
+       warn("assertion lcp_echo_timer_running==0 failed");
     TIMEOUT (LcpEchoTimeout, f, lcp_echo_interval);
     lcp_echo_timer_running = 1;
 }
@@ -1778,13 +1858,13 @@ lcp_received_echo_reply (f, id, inp, len)
 
     /* Check the magic number - don't count replies from ourselves. */
     if (len < 4) {
-       syslog(LOG_DEBUG, "lcp: received short Echo-Reply, length %d", len);
+       dbglog("lcp: received short Echo-Reply, length %d", len);
        return;
     }
     GETLONG(magic, inp);
     if (lcp_gotoptions[f->unit].neg_magicnumber
        && magic == lcp_gotoptions[f->unit].magicnumber) {
-       syslog(LOG_WARNING, "appear to have received our own echo-reply!");
+       warn("appear to have received our own echo-reply!");
        return;
     }
 
@@ -1807,7 +1887,7 @@ LcpSendEchoRequest (f)
      * Detect the failure of the peer at this point.
      */
     if (lcp_echo_fails != 0) {
-        if (lcp_echos_pending++ >= lcp_echo_fails) {
+        if (lcp_echos_pending >= lcp_echo_fails) {
             LcpLinkFailure(f);
            lcp_echos_pending = 0;
        }
@@ -1821,6 +1901,7 @@ LcpSendEchoRequest (f)
        pktp = pkt;
        PUTLONG(lcp_magic, pktp);
         fsm_sdata(f, ECHOREQ, lcp_echo_number++ & 0xFF, pkt, pktp - pkt);
+       ++lcp_echos_pending;
     }
 }