fix random signals blocking in kill_my_pg()

[ppp.git] / pppd / fsm.c

diff --git a/pppd/fsm.c b/pppd/fsm.c
index 6385fa7c3418cda10299d004de4feadcdb6d6194..043f7f0709192818138d082e536694400e971b5a 100644 (file)
--- a/pppd/fsm.c
+++ b/pppd/fsm.c
@@ -40,7 +40,7 @@
  * OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
  */
 
-#define RCSID  "$Id: fsm.c,v 1.19 2002/12/04 23:03:32 paulus Exp $"
+#define RCSID  "$Id: fsm.c,v 1.22 2004/02/02 03:57:19 carlsonj Exp $"
 
 /*
  * TODO:
@@ -201,6 +201,44 @@ fsm_open(f)
     }
 }
 
+/*
+ * terminate_layer - Start process of shutting down the FSM
+ *
+ * Cancel any timeout running, notify upper layers we're done, and
+ * send a terminate-request message as configured.
+ */
+static void
+terminate_layer(f, nextstate)
+    fsm *f;
+    int nextstate;
+{
+    if( f->state != OPENED )
+       UNTIMEOUT(fsm_timeout, f);      /* Cancel timeout */
+    else if( f->callbacks->down )
+       (*f->callbacks->down)(f);       /* Inform upper layers we're down */
+
+    /* Init restart counter and send Terminate-Request */
+    f->retransmits = f->maxtermtransmits;
+    fsm_sdata(f, TERMREQ, f->reqid = ++f->id,
+             (u_char *) f->term_reason, f->term_reason_len);
+
+    if (f->retransmits == 0) {
+       /*
+        * User asked for no terminate requests at all; just close it.
+        * We've already fired off one Terminate-Request just to be nice
+        * to the peer, but we're not going to wait for a reply.
+        */
+       f->state = nextstate == CLOSING ? CLOSED : STOPPED;
+       if( f->callbacks->finished )
+           (*f->callbacks->finished)(f);
+       return;
+    }
+
+    TIMEOUT(fsm_timeout, f, f->timeouttime);
+    --f->retransmits;
+
+    f->state = nextstate;
+}
 
 /*
  * fsm_close - Start closing connection.
@@ -230,19 +268,7 @@ fsm_close(f, reason)
     case ACKRCVD:
     case ACKSENT:
     case OPENED:
-       if( f->state != OPENED )
-           UNTIMEOUT(fsm_timeout, f);  /* Cancel timeout */
-       else if( f->callbacks->down )
-           (*f->callbacks->down)(f);   /* Inform upper layers we're down */
-
-       /* Init restart counter, send Terminate-Request */
-       f->retransmits = f->maxtermtransmits;
-       fsm_sdata(f, TERMREQ, f->reqid = ++f->id,
-                 (u_char *) f->term_reason, f->term_reason_len);
-       TIMEOUT(fsm_timeout, f, f->timeouttime);
-       --f->retransmits;
-
-       f->state = CLOSING;
+       terminate_layer(f, CLOSING);
        break;
     }
 }
@@ -406,6 +432,7 @@ fsm_rconfreq(f, id, inp, len)
        if( f->callbacks->down )
            (*f->callbacks->down)(f);   /* Inform upper layers */
        fsm_sconfreq(f, 0);             /* Send initial Configure-Request */
+       f->state = REQSENT;
        break;
 
     case STOPPED:
@@ -626,6 +653,7 @@ fsm_rtermack(f)
        if (f->callbacks->down)
            (*f->callbacks->down)(f);   /* Inform upper layers */
        fsm_sconfreq(f, 0);
+       f->state = REQSENT;
        break;
     }
 }
@@ -687,17 +715,7 @@ fsm_protreject(f)
        break;
 
     case OPENED:
-       if( f->callbacks->down )
-           (*f->callbacks->down)(f);
-
-       /* Init restart counter, send Terminate-Request */
-       f->retransmits = f->maxtermtransmits;
-       fsm_sdata(f, TERMREQ, f->reqid = ++f->id,
-                 (u_char *) f->term_reason, f->term_reason_len);
-       TIMEOUT(fsm_timeout, f, f->timeouttime);
-       --f->retransmits;
-
-       f->state = STOPPING;
+       terminate_layer(f, STOPPING);
        break;
 
     default: