discover/network: Mark interfaces configured once configured

In some cases additional netlink messages can be received for an
already-configured interface without any relevant changes. This can
result in multiple DHCP requests for the same interface.
Once an interface has been configured mark it as IFSTATE_CONFIGURED
to avoid configuring it again.

Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>

diff --git a/discover/network.c b/discover/network.c
index c072eece9627408ac7bbebab2d227d968a8f9fbf..4b79015c24a2ec52dc83db86a5e2b633729ca449 100644 (file)
--- a/discover/network.c
+++ b/discover/network.c
@@ -398,8 +398,11 @@ static void configure_interface(struct network *network,
                        interface->state = IFSTATE_NEW;
                else if (!link)
                        interface->state = IFSTATE_UP_WAITING_LINK;
                        interface->state = IFSTATE_NEW;
                else if (!link)
                        interface->state = IFSTATE_UP_WAITING_LINK;

-               else
+               else {
+                       pb_debug("network: skipping configured interface %s\n",
+                                       interface->name);

                        return;
                        return;

+               }

        }
 
        /* always up the lookback, no other handling required */
        }
 
        /* always up the lookback, no other handling required */


@@ -451,6 +454,8 @@ static void configure_interface(struct network *network,
        } else if (config->method == CONFIG_METHOD_STATIC) {
                configure_interface_static(network, interface, config);
        }
        } else if (config->method == CONFIG_METHOD_STATIC) {
                configure_interface_static(network, interface, config);
        }

+
+       interface->state = IFSTATE_CONFIGURED;

 }
 
 static int network_handle_nlmsg(struct network *network, struct nlmsghdr *nlmsg)
 }
 
 static int network_handle_nlmsg(struct network *network, struct nlmsghdr *nlmsg)