discover: pxe: Avoid dereferencing null pointer

When result is null, we may end up in the error handling path where we
try to dereference null to call cleanup_local. This adds a check for
result.

Found with scan-build.

Signed-off-by: Joel Stanley <joel@jms.id.au>
Reviewed-by: Cyril Bur <cyrilbur@gmail.com>
Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
	[Fixed up commit message typo]

diff --git a/discover/pxe-parser.c b/discover/pxe-parser.c
index 5c80b1399973813f47db0f705fb4a3d0fba41ebd..d2ebaab0e8a0f07f2f1aeef8bd262762301980b8 100644 (file)
--- a/discover/pxe-parser.c
+++ b/discover/pxe-parser.c
@@ -324,7 +324,7 @@ static void pxe_conf_parse_cb(struct load_url_result *result, void *data)
 
        talloc_free(buf);
 out_clean:
 
        talloc_free(buf);
 out_clean:

-       if (result->cleanup_local)
+       if (result && result->cleanup_local)

                unlink(result->local);
        talloc_free(conf);
 }
                unlink(result->local);
        talloc_free(conf);
 }