ccanlint: don't ever used pre-built modules as dependencies.
authorRusty Russell <rusty@rustcorp.com.au>
Thu, 17 Mar 2011 11:42:22 +0000 (22:12 +1030)
committerRusty Russell <rusty@rustcorp.com.au>
Thu, 17 Mar 2011 11:42:22 +0000 (22:12 +1030)
They're often out-of-date, and we're about to do special things to the
str module compile flags, so we don't *ever* want the default.

It doesn't add much to build times, and it eliminates a nasty source
of weird errors.

tools/ccanlint/compulsory_tests/depends_build.c

index 00f75b3733301f75083a74bda1b128f2c909ed2f..8bce5544832aa630c2ef93a838019a07d0da2c7d 100644 (file)
@@ -53,7 +53,6 @@ static char *build_subdir_objs(struct manifest *m)
 char *build_submodule(struct manifest *m)
 {
        char *errstr;
-       struct stat st;
 
        if (m->compiled)
                return NULL;
@@ -61,10 +60,6 @@ char *build_submodule(struct manifest *m)
        if (!expect_obj_file(m))
                return NULL;
 
-       m->compiled = talloc_asprintf(m, "%s.o", m->dir);
-       if (stat(m->compiled, &st) == 0)
-               return NULL;
-
        if (verbose >= 2)
                printf("  Building dependency %s\n", m->dir);