ccanlint: fix use-after-free in verbose mode.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

diff --git a/tools/read_config_header.c b/tools/read_config_header.c
index da9ed0a3fad62bdd3330285ae67751ef8084c7d2..da3e00cd73ba7088981d7a40ad3b995c4ad48e2b 100644 (file)
--- a/tools/read_config_header.c
+++ b/tools/read_config_header.c
@@ -96,10 +96,11 @@ char *read_config_header(const char *ccan_dir, bool verbose)
        char *config_header;
 
        config_header = grab_file(NULL, fname);
-       tal_free(fname);
 
-       if (!config_header)
+       if (!config_header) {
+               tal_free(fname);
                return NULL;
+       }
 
        lines = tal_strsplit(config_header, config_header, "\n", STR_EMPTY_OK);
        for (i = 0; i < tal_count(lines) - 1; i++) {
@@ -129,5 +130,6 @@ char *read_config_header(const char *ccan_dir, bool verbose)
                                       fname, cflags);
                }
        }
+       tal_free(fname);
        return config_header;
 }