]> git.ozlabs.org Git - ccan/commitdiff
configurator: warnings count as failures too.
authorRusty Russell <rusty@rustcorp.com.au>
Wed, 8 Dec 2010 00:44:21 +0000 (11:14 +1030)
committerRusty Russell <rusty@rustcorp.com.au>
Wed, 8 Dec 2010 00:44:21 +0000 (11:14 +1030)
Unfortunately, gcc only warns if it sees an unknown attribute (in this case, gcc 4.1 vs "cold").

tools/configurator/configurator.c

index 426a2ad7862f04b1997f9d61f6c3af4658581607..ffa188d77bb539eba3b647c6a8dbf9232a8c9191 100644 (file)
@@ -267,9 +267,10 @@ static bool run_test(const char *cmd, struct test *test)
                if (system("cat " INPUT_FILE) == -1);
 
        output = run(cmd, &status);
                if (system("cat " INPUT_FILE) == -1);
 
        output = run(cmd, &status);
-       if (status != 0) {
+       if (status != 0 || strstr(output, "warning")) {
                if (verbose)
                if (verbose)
-                       printf("Compile fail for %s, status %i: %s\n",
+                       printf("Compile %s for %s, status %i: %s\n",
+                              status ? "fail" : "warning",
                               test->name, status, output);
                if (test->style == EXECUTE)
                        errx(1, "Test for %s did not compile:\n%s",
                               test->name, status, output);
                if (test->style == EXECUTE)
                        errx(1, "Test for %s did not compile:\n%s",