io: fix maybe-uninitialized warning in test (-O2)

/home/rusty/devel/cvs/ccan/ccan/io/test/run-01-start-finish.c: In function ‘main’:
/home/rusty/devel/cvs/ccan/ccan/io/test/run-01-start-finish.c:89:7: warning: ‘addrinfo’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   if (connect(fd, addrinfo->ai_addr, addrinfo->ai_addrlen) != 0)

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

diff --git a/ccan/io/io.h b/ccan/io/io.h
index 9316dd180a9895adc2f60fdb6cdaeff6d77deb4a..68dd56876333293989411ccbb7206acf6001e766 100644 (file)
--- a/ccan/io/io.h
+++ b/ccan/io/io.h
@@ -47,7 +47,8 @@ struct io_conn;
  *     int fd[2];
  *     struct io_conn *conn;
  *
- *     pipe(fd);
+ *     if (pipe(fd) != 0)
+ *             exit(1);
  *     conn = io_new_conn(NULL, fd[0], conn_init, (const char *)"hi!");
  *     if (!conn)
  *             exit(1);

diff --git a/ccan/io/test/run-01-start-finish.c b/ccan/io/test/run-01-start-finish.c
index eb12e9488aea2eaca1dc445fb1cff6c46bddbbfc..04952db88e5ce9e3d65c9cadb57fee5e4730e001 100644 (file)
--- a/ccan/io/test/run-01-start-finish.c
+++ b/ccan/io/test/run-01-start-finish.c
@@ -69,7 +69,7 @@ static int make_listen_fd(const char *port, struct addrinfo **info)
 int main(void)
 {
        int state = 0;
-       struct addrinfo *addrinfo;
+       struct addrinfo *addrinfo = NULL;
        struct io_listener *l;
        int fd;
 

diff --git a/ccan/io/test/run-02-read.c b/ccan/io/test/run-02-read.c
index e25bbbb49cc5ee8e4ad4af8856e36e62608a751e..74cb2f021d87393c1dd0110a10a110ad1d52f09a 100644 (file)
--- a/ccan/io/test/run-02-read.c
+++ b/ccan/io/test/run-02-read.c
@@ -71,7 +71,7 @@ static int make_listen_fd(const char *port, struct addrinfo **info)
 int main(void)
 {
        struct data *d = malloc(sizeof(*d));
-       struct addrinfo *addrinfo;
+       struct addrinfo *addrinfo = NULL;
        struct io_listener *l;
        int fd, status;
 

diff --git a/ccan/time/test/run-check.c b/ccan/time/test/run-check.c
index 3c2e282fd4b4b40e47962066b6c45d6ef018ffc7..11bcc57642b911ca90f00c177809293dc12f3256 100644 (file)
--- a/ccan/time/test/run-check.c
+++ b/ccan/time/test/run-check.c
@@ -156,7 +156,8 @@ int main(void)
        ok1(t3.ts.tv_sec == 2);
        ok1(t3.ts.tv_nsec == 147483648);
 
-       pipe(fds);
+       if (pipe(fds) != 0)
+               exit(1);
 
        fflush(stdout);
        switch (fork()) {