1 #include <tools/ccanlint/ccanlint.h>
2 #include <tools/tools.h>
3 #include <ccan/str/str.h>
4 #include <ccan/take/take.h>
5 #include <ccan/foreach/foreach.h>
18 static bool has_dep(struct manifest *m, char **deps, bool *used,
23 /* We can include ourselves, of course. */
24 if (strstarts(depname + strlen("ccan/"), m->modname)) {
25 const char *p = depname + strlen("ccan/") + strlen(m->modname);
26 /* And our own tests! */
27 if (streq(p, "/test") || streq(p, ""))
29 /* But not any submodules; they need an explicit dep */
32 for (i = 0; deps[i]; i++) {
33 if (streq(deps[i], depname)) {
41 static bool check_dep_includes(struct manifest *m,
42 char **deps, bool *used,
47 char **lines = get_ccan_file_lines(f);
48 struct line_info *li = get_ccan_line_info(f);
51 for (i = 0; lines[i]; i++) {
53 if (!tal_strreg(f, lines[i],
54 "^[ \t]*#[ \t]*include[ \t]*[<\"]"
55 "(ccan/+.+)/+[^/]+\\.[ch][\">]", &mod))
58 if (has_dep(m, deps, used, mod))
61 /* FIXME: we can't be sure about conditional includes,
62 * so don't complain (handle common case of idempotent wrap) */
63 if (!li[i].cond || li[i].cond == f->idempotent_cond) {
64 score_file_error(score, f, i+1,
65 "%s not listed in _info", mod);
72 static void check_depends_accurate(struct manifest *m,
73 unsigned int *timeleft, struct score *score)
75 struct list_head *list;
76 unsigned int i, core_deps, test_deps;
81 /* Get the *direct* dependencies. */
83 deps = get_safe_ccan_deps(m, m->dir, "depends", false);
84 tdeps = get_safe_ccan_deps(m, m->dir, "testdepends", false);
86 deps = get_deps(m, m->dir, "depends", false,
88 tdeps = get_deps(m, m->dir, "testdepends", false,
92 core_deps = tal_count(deps) - 1;
93 test_deps = tal_count(tdeps) - 1;
95 used = tal_arrz(m, bool, core_deps + test_deps + 1);
97 foreach_ptr(list, &m->c_files, &m->h_files) {
100 list_for_each(list, f, list)
101 ok &= check_dep_includes(m, deps, used, score, f);
104 for (i = 0; i < core_deps; i++) {
105 if (!used[i] && strstarts(deps[i], "ccan/"))
106 score_file_error(score, m->info_file, 0,
107 "%s is an unused dependency",
111 /* Now remove NUL and append test dependencies to deps. */
112 deps = tal_dup_arr(m, char *, take(deps), core_deps, test_deps + 2);
113 memcpy(deps + core_deps, tdeps, sizeof(tdeps[0]) * test_deps);
114 /* ccan/tap is given a free pass. */
115 deps[core_deps + test_deps] = (char *)"ccan/tap";
116 deps[core_deps + test_deps + 1] = NULL;
118 foreach_ptr(list, &m->run_tests, &m->api_tests,
119 &m->compile_ok_tests, &m->compile_fail_tests,
120 &m->other_test_c_files) {
123 list_for_each(list, f, list)
124 ok &= check_dep_includes(m, deps, used, score, f);
127 for (i = core_deps; i < test_deps; i++) {
129 score_file_error(score, m->info_file, 0,
130 "%s is an unused test dependency",
135 score->score = score->total;
137 /* We don't count unused dependencies as an error (yet!) */
141 struct ccanlint depends_accurate = {
142 .key = "depends_accurate",
143 .name = "Module's CCAN dependencies are the only CCAN files #included",
144 .check = check_depends_accurate,
145 .needs = "depends_exist info_compiles test_depends_exist headers_idempotent"
148 REGISTER_TEST(depends_accurate);