]>
git.ozlabs.org Git - patchwork/log
Ralf Baechle [Wed, 22 Sep 2010 15:17:30 +0000 (16:17 +0100)]
parser: Recognize X-list list header
Ecartis inserts X-list list headers.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 3 Sep 2010 04:40:43 +0000 (12:40 +0800)]
tests/updates: Add delegate clear test
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 3 Sep 2010 03:29:28 +0000 (11:29 +0800)]
forms: change MultiplePatchForm from a ModelForm to a Form
ModelForm was causing validation issues, especially with no-change
fields on required model fields.
Add a test for updating a required field (state) through
MultiplePatchForm.
Change it to a normal form, and call instance.setattr manually. This
makes the new test pass.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 2 Sep 2010 11:11:53 +0000 (19:11 +0800)]
tests/updates: Add multiple invalid state change test
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 2 Sep 2010 10:51:20 +0000 (18:51 +0800)]
views/patch: remove unused code
The number of times I've edited this code and wondered why nothing
changes...
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 2 Sep 2010 10:47:38 +0000 (18:47 +0800)]
forms.MultiplePatchForm: remove no-change fields on clean()
We need to remove no-change fields, as newer versions of django are
checking for proper types on validation.
Fixes MultipleUpdateTest.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 2 Sep 2010 10:46:37 +0000 (18:46 +0800)]
tests: Add multiple patch update test
Add a test for updating mulitple patches. Currently fails with django
1.1.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 11 Aug 2010 08:28:25 +0000 (16:28 +0800)]
views/user: don't refer to request.POST for non-POST requests
We're ending up wth form errors due to using request.POST, which is
empty.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Aug 2010 04:22:20 +0000 (12:22 +0800)]
css: specify a sans-serif font
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Aug 2010 04:17:03 +0000 (12:17 +0800)]
templates: remove "beta"
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Aug 2010 04:11:40 +0000 (12:11 +0800)]
views: implement CSRF protection
Since we've got the csrf token present, we may as well check it for
requests.
We're using RequestContext already (via PatchworkRequestContext), so we
just need to switch it on in the settings, and add an exemption on the
xmlrpc interface.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
John 'Warthog9' Hawley [Thu, 24 Jun 2010 16:38:06 +0000 (09:38 -0700)]
templates: Add CSRF (cross-site request forgery) values to form posts
This is a fairly simple patch, basically it does what the error message
told me to do:
"add In the template, there is a {% csrf_token %} template tag inside each POST form that targets an internal URL."
Signed-off-by: John 'Warthog9' Hawley <warthog9@kernel.org>
Jeremy Kerr [Tue, 10 Aug 2010 03:55:57 +0000 (11:55 +0800)]
parser: decode stdin from utf-8
We need to decode stdin from the patch parser as UTF-8, rather than
python assuming ascii.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Aug 2010 03:41:58 +0000 (11:41 +0800)]
tests/utils: Specify content encoding on MIMEText() construction
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Aug 2010 03:33:35 +0000 (11:33 +0800)]
tools: add simple patchwork-update-commits script
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Aug 2010 03:22:01 +0000 (11:22 +0800)]
sql: Add uncommitted migration scripts
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Aug 2010 03:18:50 +0000 (11:18 +0800)]
docs: fix apache2 references
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Aug 2010 02:40:24 +0000 (10:40 +0800)]
Remove broken registration symlink
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Martin Krafft [Sun, 31 Jan 2010 01:32:45 +0000 (02:32 +0100)]
lib/apache2: Add WSGI Handler
Patchwork/Django can be run directly with WSGI, which is bound to be
faster and less complex than FastCGI. This patch provides the necessary
Apache configuration and the WSGI handler, as well as an update to the
docs.
Since python-flup is deprecated and WSGI supersedes FastCGI, it should
be(come) the preferred method. Hence I documented it first.
For the xmlrpc interface to work with WSGI, the HTTP authorization
information needs to be passed to the WSGI handler. This is done by
setting WSGIPassAuthorization On in the apache2 config file snippet.
Ref: http://www.arnebrodowski.de/blog/508-Django,-mod_wsgi-and-HTTP-Authentication.html
Signed-off-by: martin f. krafft <madduck@madduck.net>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Martin Krafft [Sun, 31 Jan 2010 02:03:10 +0000 (03:03 +0100)]
docs: Document password-based pgsql login
As an alternative to ident-based authentication for PostgreSQL, one can
use password-based authentication. This patch adds the alternative to
the docs.
Signed-off-by: martin f. krafft <madduck@madduck.net>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Aug 2010 02:20:06 +0000 (10:20 +0800)]
docs: reformat INSTALL
Fix up some tabs.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Aug 2010 02:17:58 +0000 (10:17 +0800)]
docs: elaborate on lib/ dirs in INSTALL
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Aug 2010 02:16:31 +0000 (10:16 +0800)]
docs: update INSTALL for commonly-available packages
We probably don't need to download django or django-registration
anymore.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Martin Krafft [Fri, 29 Jan 2010 21:03:52 +0000 (22:03 +0100)]
Registration framework maintained on bitbucket
The django-registration framework is now maintained on bitbucket, which
requires some changes to the in-tree symlink and the documentation.
Signed-off-by: martin f. krafft <madduck@madduck.net>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Aug 2010 01:19:05 +0000 (09:19 +0800)]
tools: Update license for post-receive hook.
Martin has allowed distribution under the GPL.
http://lists.ozlabs.org/pipermail/patchwork/2010-June/000263.html
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Martin Krafft [Thu, 4 Feb 2010 17:33:14 +0000 (17:33 +0000)]
tools: Add a simple sample Git post-receive hook
This patch adds a post-receive hook to lib/git, which can be used to
update Patchwork following a push to the Git repository.
Surely, it can be improved. One thing to do would be to export the state
map to git-config somehow.
Signed-off-by: martin f. krafft <madduck@madduck.net>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Martin Krafft [Thu, 4 Feb 2010 16:18:54 +0000 (16:18 +0000)]
tools: De-hyphenate Git commands in update-patchwork-status.py
Even though update-patchwork-status.py doesn't really do anything yet,
it uses the ancient way to call Git commands, so this patch fixes that.
Signed-off-by: martin f. krafft <madduck@madduck.net>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Aug 2010 00:58:12 +0000 (08:58 +0800)]
templates/patch-list: add default text for patches with no name
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 19 Jul 2010 06:17:35 +0000 (08:17 +0200)]
views/bundle/public: Lookup on user
Currently, the public bundle view is only looking up bundles by their
name. This may return multiple bundles if two users have bundles with
the same name.
This change adds the user to the bundle lookup.
Reported-by: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 27 Apr 2010 02:41:04 +0000 (10:41 +0800)]
Add TODO item: changing primary email addresses
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 19 Mar 2010 07:56:04 +0000 (15:56 +0800)]
views: Use request scheme in sample pwclientrc file.
Adapt the pwclientrc file to suit the current scheme in use.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 19 Mar 2010 07:20:47 +0000 (15:20 +0800)]
pwclient: allow authenticated https connections
If the xmlrpc server is using HTTPS, we need to adapt our custom
transport to use SafeTransport.make_connection
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Tested-by: Paul Mundt <lethal@linux-sh.org>
Paul Menzel [Sun, 24 Jan 2010 20:06:57 +0000 (21:06 +0100)]
pwclient get: fix for handling messages encoded in UTF-8
Trying `pwclient get` with a message containing UTF-8 characters you
would get the following error.
$ python -v pwclient get ID
[...]
# trying /usr/lib/python2.5/encodings/ascii.so
# trying /usr/lib/python2.5/encodings/asciimodule.so
# trying /usr/lib/python2.5/encodings/ascii.py
# /usr/lib/python2.5/encodings/ascii.pyc matches /usr/lib/python2.5/encodings/ascii.py
import encodings.ascii # precompiled from /usr/lib/python2.5/encodings/ascii.pyc
Failed to write to subject.patch
[...]
You can reproduce it with
$ pwclient get http://patchwork.openembedded.org/patch/1440/
and the fix is the same as in
4fc6a16910e595401e919abde28cca436193e0dd
by Mauro Carvalho Chehab.
Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
Jeremy Kerr [Tue, 24 Nov 2009 22:19:29 +0000 (09:19 +1100)]
pwclient: fallback to patch_get_by_hash
patch_get_by_project_hash isn't in older xmlrpc interfaces, so
fall back to patch_get_by_hash if we see an xmlrpc fault when
calling this function.
Reported-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Junio C Hamano [Tue, 3 Nov 2009 17:17:06 +0000 (09:17 -0800)]
Adjust postgres "grant all" script to new name of bundle table
Since
c105cb0 (Initial bundle reordering support, 2009-01-29), the
patchwork_bundle_patches table and its associated id sequence does not
exist. The script to grant appropriate privileges was not updated when
this change was made, and causes the set-up procedure described in
docs/INSTALL to fail.
This change adjust the script to grant appropriate access rights to
match the change in the DB schema.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 23 Oct 2009 14:31:21 +0000 (10:31 -0400)]
models: Add Reported-By to parsed comment fields
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 23 Oct 2009 14:30:06 +0000 (10:30 -0400)]
docs: Fix typo in INSTALL
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 22 Oct 2009 21:46:46 +0000 (17:46 -0400)]
pwclient,xmlrpc: Specify project for patch hash lookups
We may see the same hash for two patches if one is sent to two lists
tracked by patchwork.
This change adds a new xmlrpc method, patch_get_by_project_hash, which
adds the linkname parameter to the lookup. We need to add a new method
instead of replacing patch_get_by_hash, to avoid breaking existing
pwclient apps.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 22 Oct 2009 21:30:05 +0000 (17:30 -0400)]
pwclient: Add newline to 'no hash' message
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 30 Sep 2009 07:18:05 +0000 (17:18 +1000)]
Copy headers from original mail into patch mbox output
Preserve the Cc and To headers in the mbox output by parsing the saved
original headers, and adding them to the mail object.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 30 Sep 2009 07:17:19 +0000 (17:17 +1000)]
Use psycopg2 as default DB engine
As the 'postgres' engine seems to have been deprecated, use the
postgres_psycopg2 engine instead
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 18 Sep 2009 02:24:42 +0000 (10:24 +0800)]
Add pwclient items to TODO
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Thomas Gleixner [Thu, 17 Sep 2009 11:23:09 +0000 (13:23 +0200)]
Add Message-Id to xmlrpc patch_get_mbox headers
While trying to utilize patchwork for my daily workflow I noticed that
the xmlrpc patch_get_mbox function does not add the original message
id to the headers. That forces me to look it up with the browser which
is a major PITA.
Add Message-Id to the headers.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Mauro Carvalho Chehab [Tue, 17 Feb 2009 10:34:51 +0000 (07:34 -0300)]
pwclient fix for handling messages with UTF-8
pwclient works fine viewing utf-8 messages, if you don't try to redirect stdout.
However, if you do things like pwclient view 5063 >/tmp/patch, it fails
due to the weird character handling logic in python:
Traceback (most recent call last):
File "/usr/local/bin/pwclient", line 446, in ?
main()
File "/usr/local/bin/pwclient", line 411, in main
print s
UnicodeEncodeError: 'ascii' codec can't encode character u'\xe1' in position 249: ordinal not in range(128)
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Abhishek Kulkarni [Fri, 14 Aug 2009 18:03:56 +0000 (12:03 -0600)]
xmlrpc: Remove duplicated "name" field
Remove duplicated "name" field from the list of allowed
fields for a patch list filter in the XML RPC interface.
Signed-off-by: Abhishek Kulkarni <adkulkar@umail.iu.edu>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Eduardo Habkost [Thu, 13 Aug 2009 21:09:17 +0000 (18:09 -0300)]
tests: check some edge cases in bundle reordering tests
While testing BundleReorderTest, I felt like adding more test cases to
check if reordering is touching only the right patches on the bundle.
This increases the number of patches on the test bundle to 5, and
changes the code to do the following tests:
- Reorder all patches
- Reorder only the first 3 patches
- Reorder only the last 3 patches
- Reorder only the middle 3 patches
- On all above tests, check if the 'order' field on the BundlePatch
objects is still consistent
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Eduardo Habkost [Thu, 13 Aug 2009 20:21:23 +0000 (17:21 -0300)]
tests: Fix 'order_start' on BundleReorderTest unit test
The 'order_start' parameter on the reorder form should be a patch ID,
not the 'order' field of BundlePatch.
This fixes the following test failure:
> ======================================================================
> FAIL: testBundleReorder (patchwork.tests.bundles.BundleReorderTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/mnt/common/code/admin/rh-patchwork/apps/patchwork/tests/bundles.py", line 358, in testBundleReorder
> self.failUnlessEqual(response.status_code, 200)
> AssertionError: 404 != 200
>
> ----------------------------------------------------------------------
> Ran 123 tests in 4.527s
>
> FAILED (failures=1)
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 1 Aug 2009 06:05:37 +0000 (16:05 +1000)]
parser: allow short-form List-Id headers
Some lists (eg, nongnu.org) have short-form List-Id headers. For
example:
List-Id: qemu-devel.nongnu.org
Although RFC 2919 prescribes that:
list-id-header = "List-ID:" [phrase] "<" list-id ">" CRLF
we should allow for these headers anyway.
Based on an original patch from "J.H." <warthog9@kernel.org>.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 11 Jul 2009 02:03:55 +0000 (12:03 +1000)]
docs: add note about -pass-header Authorization' to INSTALL
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Carl-Daniel Hailfinger [Wed, 8 Jul 2009 02:49:32 +0000 (12:49 +1000)]
Fix unarchive action
We want to un-archive, not re-archive.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 8 Jul 2009 02:39:37 +0000 (12:39 +1000)]
Add nacked-by tag
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 9 Jun 2009 05:49:32 +0000 (15:49 +1000)]
views: order bundle correctly
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 2 Apr 2009 06:16:42 +0000 (17:16 +1100)]
templates: close table cell in project maintainer list
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 2 Apr 2009 06:23:45 +0000 (17:23 +1100)]
views: separate project views into separate file
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 27 Feb 2009 06:31:02 +0000 (17:31 +1100)]
docs: remove completed todo items
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 27 Feb 2009 06:28:19 +0000 (17:28 +1100)]
docs: add items to todo
Additions to pwclient.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 27 Feb 2009 02:43:08 +0000 (13:43 +1100)]
tests: test creating bundles with existing names
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 27 Feb 2009 02:41:26 +0000 (13:41 +1100)]
migration: fix whitespace
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 27 Feb 2009 02:40:49 +0000 (13:40 +1100)]
migration: reset bundlepatch sequence on setup
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Mauro Carvalho Chehab [Tue, 30 Dec 2008 22:46:16 +0000 (20:46 -0200)]
Add extra patch meta tags (Tested/Reviewed/Nacked-by)
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Mauro Carvalho Chehab [Wed, 19 Nov 2008 01:00:32 +0000 (23:00 -0200)]
Fix non-ascii character encodings on xmlrpc interface
The current xmlrpc interface dies when trying to retrieve patches
that contain non-ascii characters.
This change uses unicode() rather than str().
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 13 Feb 2009 02:52:19 +0000 (13:52 +1100)]
[views] Check count() for duplicate bundle patches, rather than try/except
If the exception is raised, the transaction will still be in a bad
state, due to the foreign key constraint.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 13 Feb 2009 01:02:48 +0000 (12:02 +1100)]
[views] Don't create bundles with no name
Check to see that we have a valid name before creating.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 12 Feb 2009 11:17:55 +0000 (22:17 +1100)]
[docs] Remove done things from TODO
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 12 Feb 2009 11:11:48 +0000 (22:11 +1100)]
[mbox] Add extra newline after patch comment
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 12 Feb 2009 11:01:09 +0000 (22:01 +1100)]
[mbox] Put ACKs before '---' updates
Update the Patch's mbox() function to split into '--- update'
sections, allowing us to add Acks and Signoffs in the right place
Add tests too.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Feb 2009 03:30:38 +0000 (14:30 +1100)]
[sql] Fix up bundle-reorder migration script
We need to add grants for the new table, and drop the old to
prevent reference constraint errors.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 10 Feb 2009 00:47:40 +0000 (11:47 +1100)]
[tests] Add initial bundle tests
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sun, 8 Feb 2009 10:40:17 +0000 (21:40 +1100)]
Bundle reordering support
Bundles can now be reordered and saved.
Add dependency on jquery in INSTALL.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sun, 8 Feb 2009 03:00:11 +0000 (14:00 +1100)]
[views] Allow Order class to be user-editable
This can be enabled with the editable_order parameter to
generic_list
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sun, 8 Feb 2009 02:28:22 +0000 (13:28 +1100)]
[sql] Perserve bundle ordering in bundle reorder migration script
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 7 Feb 2009 04:48:37 +0000 (15:48 +1100)]
Normalise order numbers in bundle-ordering migration SQL
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Sat, 7 Feb 2009 04:44:07 +0000 (15:44 +1100)]
Complete bundle ordering migration script
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 29 Jan 2009 06:38:46 +0000 (17:38 +1100)]
Initial bundle reordering support
todo:
* implement ajax reorder api
* finish migration script
* order patches in bundle view
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 27 Jan 2009 22:31:35 +0000 (09:31 +1100)]
Add per-user default filters to TODO
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 27 Jan 2009 02:26:49 +0000 (13:26 +1100)]
[models] use case-insensitve lookup when creating confirmation
We were getting multiple entries when the case-sensitive lookup
failed.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 8 Jan 2009 07:23:26 +0000 (16:23 +0900)]
Add TODO
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 18 Dec 2008 23:50:16 +0000 (08:50 +0900)]
Use 'from' import for urlresolvers
Some python installs can't seem to find the fully-qualified module,
so use the 'from'-style import instead.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 29 Oct 2008 00:21:05 +0000 (11:21 +1100)]
[models] Make patches unique on (msgid, project), not just (msgid)
On patchwork.ozlabs.org, we may see multiple patches for different
projects, but with the same message-id.
We want these patches to show up on both projects, so we need to change
the current UNIQUE contstraint on msgid.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 23 Oct 2008 03:56:18 +0000 (14:56 +1100)]
[views] Use standard UserAdmin for admin site
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Nate Case [Mon, 20 Oct 2008 16:31:11 +0000 (11:31 -0500)]
[parser] Handle special case of "New newline at end of file"
If a file doesn't have a newline at the end, diff will insert a "\ No
newline at end of file" line in the middle of the last hunk. parser.py
was counting this line as part of the hunk line count. This had the side
effect of putting the last line of the hunk in the patch comment, and
truncating out the last line of the diff.
Handle this special case by not including this line in the internal line
counter. This appears to be the only case where diff will insert a
string like this within a hunk.
Signed-off-by: Nate Case <ncase@xes-inc.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 23 Oct 2008 03:22:33 +0000 (14:22 +1100)]
[parser] Handle patches with no content charset defined
If we don't have an incoming charset defined, assume utf-8.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 14 Oct 2008 02:30:05 +0000 (13:30 +1100)]
[parser] Convert patch content to unicode before parsing
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 10 Oct 2008 08:27:24 +0000 (19:27 +1100)]
[packages] Fix bug with django 1.0
We needed an extra to_field_name
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 10 Oct 2008 07:08:08 +0000 (18:08 +1100)]
[parser] Accept x-diff patches
We should accept x-diff attachments as well as x-patch.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 10 Oct 2008 07:01:50 +0000 (18:01 +1100)]
[packages] update to django 1.0
With a minor code change, and a small workaround.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Fri, 10 Oct 2008 01:00:56 +0000 (12:00 +1100)]
[docs] Create python and packages directories
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 9 Oct 2008 11:50:49 +0000 (22:50 +1100)]
[models] Fix exception on mbox view with non-ascii submitter name
We need to unicode the name instead of str-ing it.
Add test.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Thu, 9 Oct 2008 11:49:18 +0000 (22:49 +1100)]
[sql] use separate grant-all scripts for postgresql and mysql
Mysql doesn't support granting to multiple tables, and requires a
different username format.
Would be nice to code the permissions somewhere, then generate the
grant statements as required.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Tue, 7 Oct 2008 02:32:27 +0000 (13:32 +1100)]
[encoding] Don't output patch mbox as quoted-printable
git-am doesn't like quoted-printable, so output mbox files as raw 7- or
8-bit mbox files. This means we have to create a new MIMEText class, so
that the content isn't automatically QP-encoded on __init__().
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 29 Sep 2008 13:29:37 +0000 (23:29 +1000)]
[models] Create patch mbox with utf-8 encoding
We were getting exceptions on the mbox view when looking at a
non-ascii patch.
Add test to suit.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 29 Sep 2008 13:14:05 +0000 (23:14 +1000)]
[sql] Default data should be in fixtures, not custom SQL
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 29 Sep 2008 12:28:32 +0000 (22:28 +1000)]
[tests] Remove print from SenderCorrelationTest
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Mon, 29 Sep 2008 12:27:51 +0000 (22:27 +1000)]
[tests] Add tests for utf-8 patches
.. which expose a bug in the patch parser, so fix that.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 24 Sep 2008 23:17:00 +0000 (09:17 +1000)]
[views] Don't use bundle owner for current user
This made the top auth area show the bundle owner's details, not
the bundle owner's.
Bundle owner can still be accessed through bundle.owner in the template.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 24 Sep 2008 07:29:36 +0000 (17:29 +1000)]
[html] Fix apparently-unclosed script tag
Firefox doesn't seem to grok the <script/> notation.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 24 Sep 2008 07:27:20 +0000 (17:27 +1000)]
[html] Add select-all checkbox for patch lists
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 24 Sep 2008 06:26:16 +0000 (16:26 +1000)]
[html] Reference common.js in base template
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 24 Sep 2008 06:21:38 +0000 (16:21 +1000)]
[html] Consolidate js files
We don't need most of the stuff in htdocs/js/. Put the only function
required into a common.js, which we can add other stuff to.
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
Jeremy Kerr [Wed, 24 Sep 2008 05:13:39 +0000 (15:13 +1000)]
[views] Change default ordering to latest-first
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>