summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
553a98f)
dict().get() returns a default of None, use that to initialize our
internal variables.
Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
else:
self.d['state_id'] = id
else:
self.d['state_id'] = id
+ if self.project != None:
id = project_id_by_name(rpc, self.project)
if id == 0:
sys.stderr.write("Note: No Project found matching %s, " \
id = project_id_by_name(rpc, self.project)
if id == 0:
sys.stderr.write("Note: No Project found matching %s, " \
def action_list(rpc, filter, submitter_str, delegate_str):
filter.resolve_ids(rpc)
def action_list(rpc, filter, submitter_str, delegate_str):
filter.resolve_ids(rpc)
- if submitter_str != "":
+ if submitter_str != None:
ids = person_ids_by_name(rpc, submitter_str)
if len(ids) == 0:
sys.stderr.write("Note: Nobody found matching *%s*\n" % \
ids = person_ids_by_name(rpc, submitter_str)
if len(ids) == 0:
sys.stderr.write("Note: Nobody found matching *%s*\n" % \
list_patches(patches)
return
list_patches(patches)
return
+ if delegate_str != None:
ids = person_ids_by_name(rpc, delegate_str)
if len(ids) == 0:
sys.stderr.write("Note: Nobody found matching *%s*\n" % \
ids = person_ids_by_name(rpc, delegate_str)
if len(ids) == 0:
sys.stderr.write("Note: Nobody found matching *%s*\n" % \
sys.exit(0)
args = action_parser.parse_args()
sys.exit(0)
args = action_parser.parse_args()
+ args = dict(vars(args))
action = args.get('subcmd')
if args.get('hash') and len(args.get('id')):
action = args.get('subcmd')
if args.get('hash') and len(args.get('id')):
# set defaults
filt = Filter()
# set defaults
filt = Filter()
- submitter_str = ""
- delegate_str = ""
- project_str = ""
- commit_str = ""
- state_str = ""
- hash_str = None
- msgid_str = ""
- patch_ids = None
- if args.get('s'):
- state_str = args.get('s')
- if args.get('p'):
- project_str = args.get('p')
- if args.get('w'):
- submitter_str = args.get('w')
- if args.get('d'):
- delegate_str = args.get('d')
- if args.get('hash'):
- hash_str = args.get('hash')
- if args.get('id'):
- patch_ids = args.get('id')
+ state_str = args.get('s')
+ project_str = args.get('p')
+ submitter_str = args.get('w')
+ delegate_str = args.get('d')
+ hash_str = args.get('hash')
+ patch_ids = args.get('id')
+ msgid_str = args.get('m')
if args.get('c'):
# update multiple IDs with a single commit-hash does not make sense
if action == 'update' and patch_ids and len(patch_ids) > 1:
if args.get('c'):
# update multiple IDs with a single commit-hash does not make sense
if action == 'update' and patch_ids and len(patch_ids) > 1:
update_parser.print_help()
sys.exit(1)
commit_str = args.get('c')
update_parser.print_help()
sys.exit(1)
commit_str = args.get('c')
- if args.get('m'):
- msgid_str = args.get('m')
if args.get('n') != None:
try:
filt.add("max_count", args.get('n'))
if args.get('n') != None:
try:
filt.add("max_count", args.get('n'))
if not config.has_section(project_str):
sys.stderr.write("No section for project %s\n" % project_str)
sys.exit(1)
if not config.has_section(project_str):
sys.stderr.write("No section for project %s\n" % project_str)
sys.exit(1)
if not config.has_option(project_str, 'url'):
sys.stderr.write("No URL for project %s\n" % project_str)
sys.exit(1)
if not config.has_option(project_str, 'url'):
sys.stderr.write("No URL for project %s\n" % project_str)
sys.exit(1)