user.first_name = self.cleaned_data.get('first_name', '')
user.last_name = self.cleaned_data.get('last_name', '')
user.save()
+
+ # saving the userprofile causes the firstname/lastname to propagate
+ # to the person objects.
+ user.get_profile().save()
+
return user
def clean(self):
% name)
return name
+class DeleteBundleForm(forms.Form):
+ name = 'deletebundleform'
+ form_name = forms.CharField(initial = name, widget = forms.HiddenInput)
+ bundle_id = forms.IntegerField(widget = forms.HiddenInput)
+
class DelegateField(forms.ModelChoiceField):
def __init__(self, project, *args, **kwargs):
- queryset = User.objects.filter(userprofile__in = \
+ queryset = User.objects.filter(userprofile__in = \
UserProfile.objects \
.filter(maintainer_projects = project) \
.values('pk').query)
class PatchForm(forms.ModelForm):
def __init__(self, instance = None, project = None, *args, **kwargs):
- if (not project) and instance:
+ if (not project) and instance:
project = instance.project
if not project:
- raise Exception("meep")
+ raise Exception("meep")
super(PatchForm, self).__init__(instance = instance, *args, **kwargs)
self.fields['delegate'] = DelegateField(project, required = False)
class OptionalDelegateField(DelegateField):
no_change_choice = ('*', 'no change')
+ to_field_name = None
def __init__(self, no_change_choice = None, *args, **kwargs):
self.filter = None
class OptionalModelChoiceField(forms.ModelChoiceField):
no_change_choice = ('*', 'no change')
+ to_field_name = None
def __init__(self, no_change_choice = None, *args, **kwargs):
self.filter = None
def is_no_change(self, value):
return value == self.no_change_choice[0]
-class MultiplePatchForm(PatchForm):
+class MultiplePatchForm(forms.Form):
state = OptionalModelChoiceField(queryset = State.objects.all())
archived = MultipleBooleanField()
def __init__(self, project, *args, **kwargs):
- super(MultiplePatchForm, self).__init__(project = project,
- *args, **kwargs)
- self.fields['delegate'] = OptionalDelegateField(project = project)
+ super(MultiplePatchForm, self).__init__(*args, **kwargs)
+ self.fields['delegate'] = OptionalDelegateField(project = project,
+ required = False)
def save(self, instance, commit = True):
opts = instance.__class__._meta
raise ValueError("The %s could not be changed because the data "
"didn't validate." % opts.object_name)
data = self.cleaned_data
- # remove 'no change fields' from the data
+ # Update the instance
for f in opts.fields:
if not f.name in data:
continue
- field = getattr(self, f.name, None)
+ field = self.fields.get(f.name, None)
if not field:
continue
if field.is_no_change(data[f.name]):
- del data[f.name]
+ continue
+
+ setattr(instance, f.name, data[f.name])
- return forms.save_instance(self, instance,
- self._meta.fields, 'changed', commit)
+ if commit:
+ instance.save()
+ return instance
class UserPersonLinkForm(forms.Form):
email = forms.EmailField(max_length = 200)