]> git.ozlabs.org Git - ppp.git/commitdiff
Fix indicating failure in Linux get_if_hwaddr() function
authorPali Rohár <pali@kernel.org>
Wed, 30 Dec 2020 10:04:36 +0000 (11:04 +0100)
committerPali Rohár <pali@kernel.org>
Wed, 30 Dec 2020 10:04:36 +0000 (11:04 +0100)
This function should return negative value on error.

Signed-off-by: Pali Rohár <pali@kernel.org>
pppd/sys-linux.c

index 6e1423808458c32f61e57293fdfcd486fffaeb29..fd758da9445746f5e1a7e23f9f468b2e27b09774 100644 (file)
@@ -2087,7 +2087,7 @@ get_if_hwaddr(u_char *addr, char *name)
 
        sock_fd = socket(AF_INET, SOCK_DGRAM, 0);
        if (sock_fd < 0)
-               return 0;
+               return -1;
        memset(&ifreq.ifr_hwaddr, 0, sizeof(struct sockaddr));
        strlcpy(ifreq.ifr_name, name, sizeof(ifreq.ifr_name));
        ret = ioctl(sock_fd, SIOCGIFHWADDR, &ifreq);