]> git.ozlabs.org Git - ppp.git/commitdiff
Fixing GCC compile warning with unused result from setgid/setuid.
authorEivind Næss <eivnaes@yahoo.com>
Mon, 20 Sep 2021 17:01:55 +0000 (10:01 -0700)
committerEivind Næss <eivnaes@yahoo.com>
Mon, 20 Sep 2021 17:01:55 +0000 (10:01 -0700)
Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
pppd/plugins/passprompt.c

index dae326867fcdea9b2f6190d6e01fd24fff056352..743c087b47805ea002b026dd7cf36a6b2ef5afb4 100644 (file)
@@ -35,7 +35,7 @@ static int promptpass(char *user, char *passwd)
 {
     int p[2];
     pid_t kid;
-    int readgood, wstat;
+    int readgood, wstat, ret;
     ssize_t red;
 
     if (promptprog_refused || promptprog[0] == 0 || access(promptprog, X_OK) < 0)
@@ -60,8 +60,14 @@ static int promptpass(char *user, char *passwd)
        sys_close();
        closelog();
        close(p[0]);
-       seteuid(getuid());
-       setegid(getgid());
+       ret = seteuid(getuid());
+       if (ret != 0) {
+               warn("Couldn't set effective user id");
+       }
+       ret = setegid(getgid());
+       if (ret != 0) {
+               warn("Couldn't set effective user id");
+       }
        argv[0] = promptprog;
        argv[1] = user;
        argv[2] = remote_name;