]> git.ozlabs.org Git - patchwork/commitdiff
Remove a bunch of unused variables
authorGuilherme Salgado <guilherme.salgado@linaro.org>
Mon, 28 Feb 2011 02:40:44 +0000 (02:40 +0000)
committerJeremy Kerr <jk@ozlabs.org>
Wed, 30 Mar 2011 06:42:26 +0000 (14:42 +0800)
Signed-off-by: Guilherme Salgado <guilherme.salgado@linaro.org>
Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
apps/patchwork/models.py
apps/patchwork/views/bundle.py
apps/patchwork/views/patch.py
apps/patchwork/views/user.py
apps/patchwork/views/xmlrpc.py

index 6ad4e1ad3ff993c22a84e10ddb23ec1fe1b50047..69597318b9a1acfb86218bd998b04ef57818a3c2 100644 (file)
@@ -223,13 +223,8 @@ class Patch(models.Model):
         if self.submitter.user == user or self.delegate == user:
             return True
 
-        profile = user.get_profile()
         return self.project in user.get_profile().maintainer_projects.all()
 
-    def form(self):
-        f = PatchForm(instance = self, prefix = self.id)
-        return f
-
     def filename(self):
         fname_re = re.compile('[^-_A-Za-z0-9\.]+')
         str = fname_re.sub('-', self.name)
@@ -256,7 +251,6 @@ class Patch(models.Model):
         else:
             postscript = ''
 
-        responses = False
         for comment in Comment.objects.filter(patch = self) \
                 .exclude(msgid = self.msgid):
             body += comment.patch_responses()
index d9db49096f5b52909e4e69da6fcfa32e5ae03788..e418b3ae476c6aa4a0c94f81d6778c3640d38f12 100644 (file)
@@ -68,7 +68,7 @@ def setbundle(request):
                 try:
                     patch = Patch.objects.get(id = id)
                     bundle.append_patch(patch)
-                except ex:
+                except:
                     pass
 
             bundle.save()
index 6c9fb449328d5f49eb1a043806c693d47ee24962..15830096d55600d4b91fe9410b9eb8893c2dbd65 100644 (file)
@@ -30,7 +30,6 @@ def patch(request, patch_id):
     patch = get_object_or_404(Patch, id=patch_id)
     context.project = patch.project
     editable = patch.is_editable(request.user)
-    messages = []
 
     form = None
     createbundleform = None
index c83f0b1ec7e684c48561baa213797e8670fdefae..1ae3c2dd3843cc37c33f32dc31e9b9262dc4b3df 100644 (file)
@@ -72,7 +72,7 @@ def link(request):
                                 context),
                             settings.DEFAULT_FROM_EMAIL,
                             [form.cleaned_data['email']])
-            except Exception, ex:
+            except Exception:
                 context['confirmation'] = None
                 context['error'] = 'An error occurred during confirmation. ' + \
                                    'Please try again later'
@@ -97,7 +97,6 @@ def link_confirm(request, key):
 
 @login_required
 def unlink(request, person_id):
-    context = PatchworkRequestContext(request)
     person = get_object_or_404(Person, id = person_id)
 
     if request.method == 'POST':
index 8e8b78c1bed7a2f82a42d781b7fcd4b325ca2c96..bb9ebe15d82a9df37176d6fa42167db7efdb7073 100644 (file)
@@ -129,7 +129,7 @@ def xmlrpc(request):
     try:
         ret = dispatcher._marshaled_dispatch(request)
         response.write(ret)
-    except Exception, e:
+    except Exception:
         return HttpResponseServerError()
 
     return response