]> git.ozlabs.org Git - patchwork/commitdiff
pwclient get: fix for handling messages encoded in UTF-8
authorPaul Menzel <paulepanter@users.sourceforge.net>
Sun, 24 Jan 2010 20:06:57 +0000 (21:06 +0100)
committerJeremy Kerr <jk@ozlabs.org>
Sun, 24 Jan 2010 21:58:34 +0000 (08:58 +1100)
Trying `pwclient get` with a message containing UTF-8 characters you
would get the following error.

    $ python -v pwclient get ID
    [...]
    # trying /usr/lib/python2.5/encodings/ascii.so
    # trying /usr/lib/python2.5/encodings/asciimodule.so
    # trying /usr/lib/python2.5/encodings/ascii.py
    # /usr/lib/python2.5/encodings/ascii.pyc matches /usr/lib/python2.5/encodings/ascii.py
    import encodings.ascii # precompiled from /usr/lib/python2.5/encodings/ascii.pyc
    Failed to write to subject.patch
    [...]

You can reproduce it with

    $ pwclient get http://patchwork.openembedded.org/patch/1440/

and the fix is the same as in 4fc6a16910e595401e919abde28cca436193e0dd
by Mauro Carvalho Chehab.

Signed-off-by: Paul Menzel <paulepanter@users.sourceforge.net>
apps/patchwork/bin/pwclient

index b0bd1d175b8105464b42951ad40c9a8db1abedfa..b4804080921b0c90ebd4a4140d8751c64529b463 100755 (executable)
@@ -234,7 +234,7 @@ def action_get(rpc, patch_id):
         sys.exit(1)
 
     try:
-        f.write(s)
+        f.write(unicode(s).encode("utf-8"))
         f.close()
         print "Saved patch to %s" % fname
     except: