tools: fix up warnings with -Wwrite-strings.

[ccan] / tools / ccanlint / tests / examples_compile.c

diff --git a/tools/ccanlint/tests/examples_compile.c b/tools/ccanlint/tests/examples_compile.c
index a0a3dd64c57bf61bbde8d92ae24e140038c5f6e5..4b6f4d624be2ead86e1a66a09d8f678bad8cb627 100644 (file)
--- a/tools/ccanlint/tests/examples_compile.c
+++ b/tools/ccanlint/tests/examples_compile.c
@@ -1,6 +1,7 @@
 #include <tools/ccanlint/ccanlint.h>
 #include <tools/tools.h>
 #include <ccan/talloc/talloc.h>
+#include <ccan/cast/cast.h>
 #include <ccan/str/str.h>
 #include <sys/types.h>
 #include <sys/stat.h>
@@ -145,13 +146,13 @@ static char *start_main(char *ret, const char *why)
 static char *add_func(char *others, const char *line)
 {
        const char *p, *end = strchr(line, '(') - 1;
-       while (isspace(*end)) {
+       while (cisspace(*end)) {
                end--;
                if (end == line)
                        return others;
        }
 
-       for (p = end; isalnum(*p) || *p == '_'; p--) {
+       for (p = end; cisalnum(*p) || *p == '_'; p--) {
                if (p == line)
                        return others;
        }
@@ -188,48 +189,52 @@ static bool looks_internal(char **lines, char **why)
                const char *line = lines[i] + strspn(lines[i], " \t");
                unsigned len = strspn(line, IDENT_CHARS);
 
-               if (!line[0] || isspace(line[0]) || strstarts(line, "//"))
+               if (!line[0] || cisspace(line[0]) || strstarts(line, "//"))
                        continue;
 
                /* The winners. */
                if (strstarts(line, "if") && len == 2) {
-                       *why = "starts with if";
+                       *why = cast_const(char *, "starts with if");
                        return true;
                }
                if (strstarts(line, "for") && len == 3) {
-                       *why = "starts with for";
+                       *why = cast_const(char *, "starts with for");
                        return true;
                }
                if (strstarts(line, "while") && len == 5) {
-                       *why = "starts with while";
+                       *why = cast_const(char *, "starts with while");
                        return true;
                }
                if (strstarts(line, "do") && len == 2) {
-                       *why = "starts with do";
+                       *why = cast_const(char *, "starts with do");
                        return true;
                }
 
                /* The losers. */
                if (strstarts(line, "#include")) {
-                       *why = "starts with #include";
+                       *why = cast_const(char *, "starts with #include");
                        return false;
                }
 
                if (last_ended && strchr(line, '(')) {
                        if (strstarts(line, "static")) {
-                               *why = "starts with static and contains (";
+                               *why = cast_const(char *,
+                                                 "starts with static"
+                                                 " and contains (");
                                return false;
                        }
                        if (strends(line, ")")) {
-                               *why = "contains ( and ends with )";
+                               *why = cast_const(char *,
+                                                 "contains ( and ends with )");
                                return false;
                        }
                }
 
                /* Single identifier then operator == inside function. */
                if (last_ended && len
-                   && ispunct(line[len+strspn(line+len, " ")])) {
-                       *why = "starts with identifier then punctuation";
+                   && cispunct(line[len+strspn(line+len, " ")])) {
+                       *why = cast_const(char *, "starts with identifier"
+                                         " then punctuation");
                        return true;
                }
 
@@ -239,7 +244,7 @@ static bool looks_internal(char **lines, char **why)
        }
 
        /* No idea... Say yes? */
-       *why = "gave no clues";
+       *why = cast_const(char *, "gave no clues");
        return true;
 }
 
@@ -361,7 +366,7 @@ static char *mangle(struct manifest *m, char **lines)
                } else {
                        /* Character at start of line, with ( and no ;
                         * == function start.  Ignore comments. */
-                       if (!isspace(line[0])
+                       if (!cisspace(line[0])
                            && strchr(line, '(')
                            && !strchr(line, ';')
                            && !strstr(line, "//")) {
@@ -521,7 +526,7 @@ static void build_examples(struct manifest *m, bool keep,
                bool res[3];
                unsigned num, j;
                char **lines[3];
-               char *error;
+               const char *error;
 
                score->total++;