+#include "config.h"
#include "ccanlint.h"
#include <ccan/talloc/talloc.h>
#include <ccan/str/str.h>
#include <ccan/str_talloc/str_talloc.h>
+#include <ccan/talloc_link/talloc_link.h>
+#include <ccan/hash/hash.h>
+#include <ccan/htable/htable_type.h>
#include <ccan/grab_file/grab_file.h>
#include <ccan/noerr/noerr.h>
+#include <ccan/foreach/foreach.h>
+#include <ccan/asort/asort.h>
+#include <ccan/array_size/array_size.h>
#include "../tools.h"
#include <unistd.h>
#include <sys/types.h>
#include <errno.h>
#include <dirent.h>
#include <ctype.h>
-
-char **get_ccan_file_lines(struct ccan_file *f)
-{
- if (!f->lines) {
- char *buffer = grab_file(f, f->name, NULL);
- if (!buffer)
- err(1, "Getting file %s", f->name);
- f->lines = strsplit(f, buffer, "\n", &f->num_lines);
- }
- return f->lines;
-}
+#include <stdarg.h>
+#include <assert.h>
struct list_head *get_ccan_file_docs(struct ccan_file *f)
{
if (!f->doc_sections) {
get_ccan_file_lines(f);
- f->doc_sections = extract_doc_sections(f->lines, f->num_lines);
+ f->doc_sections = extract_doc_sections(f->lines);
}
return f->doc_sections;
}
-static void add_files(struct manifest *m, const char *dir)
-{
- DIR *d;
- struct dirent *ent;
-
- if (dir[0])
- d = opendir(dir);
- else
- d = opendir(".");
- if (!d)
- err(1, "Opening directory %s", dir[0] ? dir : ".");
-
- while ((ent = readdir(d)) != NULL) {
- struct stat st;
- struct ccan_file *f;
- struct list_head *dest;
- bool is_c_src;
-
- if (ent->d_name[0] == '.')
- continue;
-
- f = talloc(m, struct ccan_file);
- f->lines = NULL;
- f->doc_sections = NULL;
- f->name = talloc_asprintf(f, "%s%s", dir, ent->d_name);
- if (lstat(f->name, &st) != 0)
- err(1, "lstat %s", f->name);
-
- if (S_ISDIR(st.st_mode)) {
- f->name = talloc_append_string(f->name, "/");
- add_files(m, f->name);
- continue;
- }
- if (!S_ISREG(st.st_mode)) {
- talloc_free(f);
- continue;
- }
-
- if (streq(f->name, "_info.c")) {
- m->info_file = f;
- continue;
- }
-
- is_c_src = strends(f->name, ".c");
- if (!is_c_src && !strends(f->name, ".h"))
- dest = &m->other_files;
- else if (!strchr(f->name, '/')) {
- if (is_c_src)
- dest = &m->c_files;
- else
- dest = &m->h_files;
- } else if (strstarts(f->name, "test/")) {
- if (is_c_src) {
- if (strstarts(f->name, "test/api"))
- dest = &m->api_tests;
- else if (strstarts(f->name, "test/run"))
- dest = &m->run_tests;
- else if (strstarts(f->name, "test/compile_ok"))
- dest = &m->compile_ok_tests;
- else if (strstarts(f->name, "test/compile_fail"))
- dest = &m->compile_fail_tests;
- else
- dest = &m->other_test_files;
- } else
- dest = &m->other_test_files;
- } else
- dest = &m->other_files;
-
- list_add(dest, &f->list);
- }
- closedir(d);
-}
-
-char *report_on_lines(struct list_head *files,
- char *(*report)(const char *),
- char *sofar)
-{
- struct ccan_file *f;
-
- list_for_each(files, f, list) {
- unsigned int i;
- char **lines = get_ccan_file_lines(f);
-
- for (i = 0; i < f->num_lines; i++) {
- char *r = report(lines[i]);
- if (!r)
- continue;
-
- sofar = talloc_asprintf_append(sofar,
- "%s:%u:%s\n",
- f->name, i+1, r);
- talloc_free(r);
- }
- }
- return sofar;
-}
-
-struct manifest *get_manifest(void)
-{
- struct manifest *m = talloc(NULL, struct manifest);
- unsigned int len;
-
- m->info_file = NULL;
- list_head_init(&m->c_files);
- list_head_init(&m->h_files);
- list_head_init(&m->api_tests);
- list_head_init(&m->run_tests);
- list_head_init(&m->compile_ok_tests);
- list_head_init(&m->compile_fail_tests);
- list_head_init(&m->other_test_files);
- list_head_init(&m->other_files);
-
- /* *This* is why people hate C. */
- len = 32;
- m->basename = talloc_array(m, char, len);
- while (!getcwd(m->basename, len)) {
- if (errno != ERANGE)
- err(1, "Getting current directory");
- m->basename = talloc_realloc(m, m->basename, char, len *= 2);
- }
-
- len = strlen(m->basename);
- while (len && m->basename[len-1] == '/')
- m->basename[--len] = '\0';
-
- m->basename = strrchr(m->basename, '/');
- if (!m->basename)
- errx(1, "I don't expect to be run from the root directory");
- m->basename++;
-
- add_files(m, "");
- return m;
-}
-
/**
* remove_comments - strip comments from a line, return copy.
static bool is_empty(const char *line)
{
- return strspn(line, " \t") == strlen(line);
+ return strspn(line, " \r\t") == strlen(line);
}
static bool continues(const char *line)
}
/* Get token if it's equal to token. */
-static bool get_token(const char **line, const char *token)
+bool get_token(const char **line, const char *token)
{
unsigned int toklen;
*line += strspn(*line, " \t");
- if (isalnum(token[0]) || token[0] == '_')
+ if (cisalnum(token[0]) || token[0] == '_')
toklen = strspn(*line, IDENT_CHARS);
else {
/* FIXME: real tokenizer handles ++ and other multi-chars. */
return false;
}
-static char *get_symbol_token(void *ctx, const char **line)
+char *get_symbol_token(void *ctx, const char **line)
{
unsigned int toklen;
char *ret;
return false;
if (!defined)
cond->type = PP_COND_IF;
+
+ /* FIXME: We just chain them, ignoring operators. */
+ if (get_token(line, "||") || get_token(line, "&&")) {
+ struct pp_conditions *sub = talloc(cond, struct pp_conditions);
+
+ sub->parent = cond->parent;
+ sub->type = PP_COND_IFDEF;
+ if (parse_hash_if(sub, line))
+ cond->parent = sub;
+ }
+
return true;
}
return f->line_info;
}
-enum line_compiled get_ccan_line_pp(struct pp_conditions *cond,
- const char *symbol,
- unsigned int value)
+struct symbol {
+ struct list_node list;
+ const char *name;
+ const unsigned int *value;
+};
+
+static struct symbol *find_symbol(struct list_head *syms, const char *sym)
{
- enum line_compiled ret;
+ struct symbol *i;
+
+ list_for_each(syms, i, list)
+ if (streq(sym, i->name))
+ return i;
+ return NULL;
+}
+
+static enum line_compiled get_pp(struct pp_conditions *cond,
+ struct list_head *syms)
+{
+ struct symbol *sym;
+ unsigned int val;
+ enum line_compiled parent, ret;
/* No conditions? Easy. */
if (!cond)
return COMPILED;
/* Check we get here at all. */
- ret = get_ccan_line_pp(cond->parent, symbol, value);
- if (ret != COMPILED)
- return ret;
+ parent = get_pp(cond->parent, syms);
+ if (parent == NOT_COMPILED)
+ return NOT_COMPILED;
+
+ if (cond->type == PP_COND_UNKNOWN)
+ return MAYBE_COMPILED;
+
+ sym = find_symbol(syms, cond->symbol);
+ if (!sym)
+ return MAYBE_COMPILED;
switch (cond->type) {
case PP_COND_IF:
- if (streq(cond->symbol, symbol)) {
- if (!value == cond->inverse)
- return COMPILED;
- else
- return NOT_COMPILED;
- }
- /* Unknown symbol, will be 0. */
- if (cond->inverse)
- return COMPILED;
- return NOT_COMPILED;
+ /* Undefined is 0. */
+ val = sym->value ? *sym->value : 0;
+ if (!val == cond->inverse)
+ ret = COMPILED;
+ else
+ ret = NOT_COMPILED;
+ break;
case PP_COND_IFDEF:
- if (streq(cond->symbol, symbol)) {
- if (cond->inverse)
- return NOT_COMPILED;
- else
- return COMPILED;
- }
- /* Unknown symbol, assume undefined. */
- if (cond->inverse)
- return COMPILED;
- return NOT_COMPILED;
-
- default: /* Unknown. */
- return MAYBE_COMPILED;
+ if (cond->inverse == !sym->value)
+ ret = COMPILED;
+ else
+ ret = NOT_COMPILED;
+ break;
+
+ default:
+ abort();
+ }
+
+ /* If parent didn't know, NO == NO, but YES == MAYBE. */
+ if (parent == MAYBE_COMPILED && ret == COMPILED)
+ ret = MAYBE_COMPILED;
+ return ret;
+}
+
+static void add_symbol(struct list_head *head,
+ const char *symbol, const unsigned int *value)
+{
+ struct symbol *sym = talloc(head, struct symbol);
+ sym->name = symbol;
+ sym->value = value;
+ list_add(head, &sym->list);
+}
+
+enum line_compiled get_ccan_line_pp(struct pp_conditions *cond,
+ const char *symbol,
+ const unsigned int *value,
+ ...)
+{
+ enum line_compiled ret;
+ struct list_head *head;
+ va_list ap;
+
+ head = talloc(NULL, struct list_head);
+ list_head_init(head);
+
+ va_start(ap, value);
+ add_symbol(head, symbol, value);
+
+ while ((symbol = va_arg(ap, const char *)) != NULL) {
+ value = va_arg(ap, const unsigned int *);
+ add_symbol(head, symbol, value);
}
+ ret = get_pp(cond, head);
+ talloc_free(head);
+ return ret;
+}
+
+void score_file_error(struct score *score, struct ccan_file *f, unsigned line,
+ const char *errorfmt, ...)
+{
+ va_list ap;
+
+ struct file_error *fe = talloc(score, struct file_error);
+ fe->file = f;
+ fe->line = line;
+ list_add_tail(&score->per_file_errors, &fe->list);
+
+ if (!score->error)
+ score->error = talloc_strdup(score, "");
+
+ if (verbose < 2 && strcount(score->error, "\n") > 5)
+ return;
+
+ if (line)
+ score->error = talloc_asprintf_append(score->error,
+ "%s:%u:",
+ f->fullname, line);
+ else
+ score->error = talloc_asprintf_append(score->error,
+ "%s:", f->fullname);
+
+ va_start(ap, errorfmt);
+ score->error = talloc_vasprintf_append(score->error, errorfmt, ap);
+ va_end(ap);
+ score->error = talloc_append_string(score->error, "\n");
+
+ if (verbose < 2 && strcount(score->error, "\n") > 5)
+ score->error = talloc_append_string(score->error,
+ "... more (use -vv to see them all)\n");
}
projects / ccan / blobdiff