#include <ccan/foreach/foreach.h>
#include <ccan/grab_file/grab_file.h>
#include <ccan/cast/cast.h>
+#include <ccan/tlist/tlist.h>
+#include <ccan/strmap/strmap.h>
+
+struct ccanlint_map {
+ STRMAP_MEMBERS(struct ccanlint *);
+};
int verbose = 0;
-static struct list_head compulsory_tests;
-static struct list_head normal_tests;
+static struct ccanlint_map tests;
bool safe_mode = false;
+static bool targeting = false;
static struct btree *cmdline_exclude;
static struct btree *info_exclude;
static unsigned int timeout;
+static struct dgraph_node all;
/* These are overridden at runtime if we can find config.h */
const char *compiler = NULL;
return NULL;
}
-static bool run_test(struct ccanlint *i,
- bool quiet,
- unsigned int *running_score,
- unsigned int *running_total,
- struct manifest *m,
- const char *prefix)
+static bool skip_node(struct dgraph_node *to, const char *failmsg)
+{
+ struct ccanlint *c = container_of(to, struct ccanlint, node);
+ if (!c->skip) {
+ if (failmsg) {
+ c->skip = failmsg;
+ c->skip_fail = true;
+ } else {
+ c->skip = "dependency was skipped";
+ }
+ }
+ return true;
+}
+
+struct run_info {
+ bool quiet;
+ unsigned int score, total;
+ struct manifest *m;
+ const char *prefix;
+ bool pass;
+};
+
+static bool run_test(struct dgraph_node *n, struct run_info *run)
{
+ struct ccanlint *i = container_of(n, struct ccanlint, node);
unsigned int timeleft;
- const struct dependent *d;
const char *skip;
struct score *score;
- //one less test to run through
- list_for_each(&i->dependencies, d, node)
- d->dependent->num_depends--;
+ if (i->done)
+ return true;
- score = talloc(m, struct score);
+ score = talloc(run->m, struct score);
list_head_init(&score->per_file_errors);
score->error = NULL;
score->pass = false;
score->score = 0;
score->total = 1;
- skip = should_skip(m, i);
+ skip = should_skip(run->m, i);
if (skip) {
skip:
- if (verbose && !streq(skip, "not relevant to target"))
- printf("%s%s: skipped (%s)\n", prefix, i->name, skip);
+ if (verbose)
+ printf("%s%s: skipped (%s)\n",
+ run->prefix, i->name, skip);
/* If we're skipping this because a prereq failed, we fail:
* count it as a score of 1. */
if (i->skip_fail)
- (*running_total)++;
-
- list_del(&i->list);
- list_for_each(&i->dependencies, d, node) {
- if (d->dependent->skip)
- continue;
- d->dependent->skip = "dependency was skipped";
- d->dependent->skip_fail = i->skip_fail;
- }
- return i->skip_fail ? false : true;
+ run->total++;
+
+ dgraph_traverse_from(&i->node, skip_node,
+ i->skip_fail ? "dependency failed" : NULL);
+ dgraph_clear_node(&i->node);
+ score->pass = i->skip_fail ? false : true;
+ goto out;
}
timeleft = timeout ? timeout : default_timeout_ms;
- i->check(m, i->keep_results, &timeleft, score);
+ i->check(run->m, i->keep_results, &timeleft, score);
if (timeout && timeleft == 0) {
skip = "timeout";
goto skip;
}
assert(score->score <= score->total);
- if ((!score->pass && !quiet)
+ if ((!score->pass && !run->quiet)
|| (score->score < score->total && verbose)
|| verbose > 1) {
printf("%s%s (%s): %s",
- prefix, i->name, i->key, score->pass ? "PASS" : "FAIL");
+ run->prefix, i->name, i->key,
+ score->pass ? "PASS" : "FAIL");
if (score->total > 1)
printf(" (+%u/%u)", score->score, score->total);
printf("\n");
}
- if ((!quiet && !score->pass) || verbose) {
+ if ((!run->quiet && !score->pass) || verbose) {
if (score->error) {
printf("%s%s", score->error,
strends(score->error, "\n") ? "" : "\n");
}
}
- if (!quiet && score->score < score->total && i->handle)
- i->handle(m, score);
-
- *running_score += score->score;
- *running_total += score->total;
+ if (!run->quiet && score->score < score->total && i->handle)
+ i->handle(run->m, score);
- list_del(&i->list);
+ run->score += score->score;
+ run->total += score->total;
if (!score->pass) {
/* Skip any tests which depend on this one. */
- list_for_each(&i->dependencies, d, node) {
- if (d->dependent->skip)
- continue;
- d->dependent->skip = "dependency failed";
- d->dependent->skip_fail = true;
- }
+ dgraph_traverse_from(&i->node, skip_node, "dependency failed");
+ }
+ dgraph_clear_node(&i->node);
+
+out:
+ /* FIXME: Free score. */
+ run->pass &= score->pass;
+ i->done = true;
+
+ if (!score->pass && i->compulsory) {
+ warnx("%s%s failed", run->prefix, i->name);
+ run->score = 0;
+ return false;
}
- return score->pass;
+ return true;
}
-static void register_test(struct list_head *h, struct ccanlint *test)
+static void register_test(struct ccanlint *test)
{
- list_add(h, &test->list);
+ if (!strmap_add(&tests, test->key, test))
+ err(1, "Adding test %s", test->key);
test->options = talloc_array(NULL, char *, 1);
test->options[0] = NULL;
- test->skip = NULL;
- test->skip_fail = false;
+ dgraph_init_node(&test->node);
+ dgraph_add_edge(&test->node, &all);
+ test->done = false;
+}
+
+static bool get_test(const char *member, struct ccanlint *i,
+ struct ccanlint **ret)
+{
+ if (tlist_empty(&i->node.edge[DGRAPH_TO])) {
+ *ret = i;
+ return false;
+ }
+ return true;
}
/**
* get_next_test - retrieves the next test to be processed
**/
-static inline struct ccanlint *get_next_test(struct list_head *test)
+static inline struct ccanlint *get_next_test(void)
{
- struct ccanlint *i;
+ struct ccanlint *i = NULL;
- if (list_empty(test))
+ strmap_iterate(&tests, get_test, &i);
+ if (i)
+ return i;
+
+ if (strmap_empty(&tests))
return NULL;
- list_for_each(test, i, list) {
- if (i->num_depends == 0)
- return i;
- }
errx(1, "Can't make process; test dependency cycle");
}
static struct ccanlint *find_test(const char *key)
{
- struct ccanlint *i;
-
- list_for_each(&compulsory_tests, i, list)
- if (streq(i->key, key))
- return i;
-
- list_for_each(&normal_tests, i, list)
- if (streq(i->key, key))
- return i;
-
- return NULL;
+ return strmap_get(&tests, key);
}
bool is_excluded(const char *name)
|| find_test(name)->skip != NULL;
}
+static bool reset_deps(const char *member, struct ccanlint *c, void *unused)
+{
+ char **deps = strsplit(NULL, c->needs, " ");
+ unsigned int i;
+
+ c->skip = NULL;
+ c->skip_fail = false;
+ for (i = 0; deps[i]; i++) {
+ struct ccanlint *dep;
+
+ dep = find_test(deps[i]);
+ if (!dep)
+ errx(1, "BUG: unknown dep '%s' for %s",
+ deps[i], c->key);
+ dgraph_add_edge(&dep->node, &c->node);
+ }
+ talloc_free(deps);
+ return true;
+}
+
+static bool check_names(const char *member, struct ccanlint *c,
+ struct ccanlint_map *names)
+{
+ if (!strmap_add(names, c->name, c))
+ err(1, "Duplicate name %s", c->name);
+ return true;
+}
+
#undef REGISTER_TEST
#define REGISTER_TEST(name, ...) extern struct ccanlint name
-#include "generated-normal-tests"
-#include "generated-compulsory-tests"
+#include "generated-testlist"
static void init_tests(void)
{
- struct ccanlint *c;
- struct btree *keys, *names;
- struct list_head *list;
+ struct ccanlint_map names;
- list_head_init(&normal_tests);
- list_head_init(&compulsory_tests);
+ /* This is the default target. */
+ dgraph_init_node(&all);
+
+ strmap_init(&tests);
#undef REGISTER_TEST
-#define REGISTER_TEST(name) register_test(&normal_tests, &name)
-#include "generated-normal-tests"
-#undef REGISTER_TEST
-#define REGISTER_TEST(name) register_test(&compulsory_tests, &name)
-#include "generated-compulsory-tests"
-
- /* Initialize dependency lists. */
- foreach_ptr(list, &compulsory_tests, &normal_tests) {
- list_for_each(list, c, list) {
- list_head_init(&c->dependencies);
- c->num_depends = 0;
- }
- }
+#define REGISTER_TEST(name) register_test(&name)
+#include "generated-testlist"
- /* Resolve dependencies. */
- foreach_ptr(list, &compulsory_tests, &normal_tests) {
- list_for_each(list, c, list) {
- char **deps = strsplit(NULL, c->needs, " ");
- unsigned int i;
-
- for (i = 0; deps[i]; i++) {
- struct ccanlint *dep;
- struct dependent *dchild;
-
- dep = find_test(deps[i]);
- if (!dep)
- errx(1, "BUG: unknown dep '%s' for %s",
- deps[i], c->key);
- dchild = talloc(NULL, struct dependent);
- dchild->dependent = c;
- list_add_tail(&dep->dependencies,
- &dchild->node);
- c->num_depends++;
- }
- talloc_free(deps);
- }
- }
+ strmap_iterate(&tests, reset_deps, NULL);
+
+ /* Check for duplicate names. */
+ strmap_init(&names);
+ strmap_iterate(&tests, check_names, &names);
+ strmap_clear(&names);
+}
- /* Self-consistency check: make sure no two tests
- have the same key or name. */
- keys = btree_new(btree_strcmp);
- names = btree_new(btree_strcmp);
- foreach_ptr(list, &compulsory_tests, &normal_tests) {
- list_for_each(list, c, list) {
- if (!btree_insert(keys, c->key))
- errx(1, "BUG: Duplicate test key '%s'",
- c->key);
- if (!btree_insert(names, c->name))
- errx(1, "BUG: Duplicate test name '%s'",
- c->name);
+static bool print_deps(const char *member, struct ccanlint *c, void *unused)
+{
+ if (!tlist_empty(&c->node.edge[DGRAPH_FROM])) {
+ struct dgraph_edge *e;
+
+ printf("These depend on %s:\n", c->key);
+ dgraph_for_each_edge(&c->node, e, DGRAPH_FROM) {
+ struct ccanlint *to = container_of(e->n[DGRAPH_TO],
+ struct ccanlint,
+ node);
+ printf("\t%s\n", to->key);
}
}
- btree_delete(keys);
- btree_delete(names);
+ return true;
}
static void print_test_depends(void)
{
- struct list_head *list;
-
- foreach_ptr(list, &compulsory_tests, &normal_tests) {
- struct ccanlint *c;
- printf("\%s Tests\n",
- list == &compulsory_tests ? "Compulsory" : "Normal");
+ printf("Tests:\n");
- list_for_each(list, c, list) {
- if (!list_empty(&c->dependencies)) {
- const struct dependent *d;
- printf("These depend on %s:\n", c->key);
- list_for_each(&c->dependencies, d, node)
- printf("\t%s\n", d->dependent->key);
- }
- }
- }
+ strmap_iterate(&tests, print_deps, NULL);
}
+
static int show_tmpdir(const char *dir)
{
printf("You can find ccanlint working files in '%s'\n", dir);
return 0;
}
-static char *keep_test(const char *testname, void *unused)
+static bool keep_one_test(const char *member, struct ccanlint *c, void *unused)
{
- struct ccanlint *i;
+ c->keep_results = true;
+ return true;
+}
- init_tests();
+static char *keep_test(const char *testname, void *unused)
+{
if (streq(testname, "all")) {
- struct list_head *list;
- foreach_ptr(list, &compulsory_tests, &normal_tests) {
- list_for_each(list, i, list)
- i->keep_results = true;
- }
+ strmap_iterate(&tests, keep_one_test, NULL);
} else {
- i = find_test(testname);
+ struct ccanlint *i = find_test(testname);
if (!i)
errx(1, "No test %s to --keep", testname);
- i->keep_results = true;
+ keep_one_test(testname, i, NULL);
}
/* Don't automatically destroy temporary dir. */
return NULL;
}
-static void print_tests(struct list_head *tests, const char *type)
+static char *list_tests(void *arg)
{
struct ccanlint *i;
- printf("%s tests:\n", type);
+ printf("Tests:\n");
/* This makes them print in topological order. */
- while ((i = get_next_test(tests)) != NULL) {
- const struct dependent *d;
+ while ((i = get_next_test()) != NULL) {
printf(" %-25s %s\n", i->key, i->name);
- list_del(&i->list);
- list_for_each(&i->dependencies, d, node)
- d->dependent->num_depends--;
+ dgraph_clear_node(&i->node);
+ strmap_del(&tests, i->key, NULL);
}
+ exit(0);
}
-static char *list_tests(void *arg)
+static bool draw_test(const char *member, struct ccanlint *c, const char *style)
{
- init_tests();
- print_tests(&compulsory_tests, "Compulsory");
- print_tests(&normal_tests, "Normal");
- exit(0);
+ /*
+ * todo: escape labels in case ccanlint test keys have
+ * characters interpreted as GraphViz syntax.
+ */
+ printf("\t\"%p\" [label=\"%s\"%s]\n", c, c->key, style);
+ return true;
+}
+
+static void test_dgraph_vertices(const char *style)
+{
+ strmap_iterate(&tests, draw_test, style);
}
-static void test_dgraph_vertices(struct list_head *tests, const char *style)
+static bool draw_edges(const char *member, struct ccanlint *c, void *unused)
{
- const struct ccanlint *i;
+ struct dgraph_edge *e;
- list_for_each(tests, i, list) {
- /*
- * todo: escape labels in case ccanlint test keys have
- * characters interpreted as GraphViz syntax.
- */
- printf("\t\"%p\" [label=\"%s\"%s]\n", i, i->key, style);
+ dgraph_for_each_edge(&c->node, e, DGRAPH_FROM) {
+ struct ccanlint *to = container_of(e->n[DGRAPH_TO],
+ struct ccanlint,
+ node);
+ printf("\t\"%p\" -> \"%p\"\n", c->name, to->name);
}
+ return true;
}
-static void test_dgraph_edges(struct list_head *tests)
+static void test_dgraph_edges(void)
{
- const struct ccanlint *i;
- const struct dependent *d;
-
- list_for_each(tests, i, list)
- list_for_each(&i->dependencies, d, node)
- printf("\t\"%p\" -> \"%p\"\n", d->dependent, i);
+ strmap_iterate(&tests, draw_edges, NULL);
}
static char *test_dependency_graph(void *arg)
{
- init_tests();
puts("digraph G {");
- test_dgraph_vertices(&compulsory_tests, ", style=filled, fillcolor=yellow");
- test_dgraph_vertices(&normal_tests, "");
-
- test_dgraph_edges(&compulsory_tests);
- test_dgraph_edges(&normal_tests);
+ test_dgraph_vertices("");
+ test_dgraph_edges();
puts("}");
memcpy(&test->options[num], options, (num_options + 1)*sizeof(char *));
}
-static void add_info_options(struct ccan_file *info, bool mark_fails)
+void add_info_options(struct ccan_file *info)
{
struct doc_section *d;
unsigned int i;
/* Known failure? */
if (strcasecmp(words[1], "FAIL") == 0) {
- if (mark_fails)
+ if (!targeting)
btree_insert(info_exclude, words[0]);
} else {
if (!test->takes_options)
return talloc_realloc(NULL, ret, char *, j + 1);
}
-static bool depends_on(struct ccanlint *i, struct ccanlint *target)
-{
- const struct dependent *d;
-
- if (i == target)
- return true;
-
- list_for_each(&i->dependencies, d, node) {
- if (depends_on(d->dependent, target))
- return true;
- }
- return false;
-}
-
-/* O(N^2), who cares? */
-static void skip_unrelated_tests(struct ccanlint *target)
-{
- struct ccanlint *i;
- struct list_head *list;
-
- foreach_ptr(list, &compulsory_tests, &normal_tests)
- list_for_each(list, i, list)
- if (!depends_on(i, target))
- i->skip = "not relevant to target";
-}
-
static char *demangle_string(char *string)
{
unsigned int i;
return opt_set_charp(arg, cast_const2(char **, p));
}
+static char *opt_set_target(const char *arg, struct ccanlint **t)
+{
+ *t = find_test(arg);
+ if (!*t)
+ return talloc_asprintf(NULL, "unknown --target %s", arg);
+ return NULL;
+}
+
+static bool run_tests(struct ccanlint *target,
+ bool summary,
+ struct manifest *m,
+ const char *prefix)
+{
+ struct run_info run;
+
+ run.quiet = summary;
+ run.m = m;
+ run.prefix = prefix;
+ run.score = run.total = 0;
+ run.pass = true;
+
+ if (target) {
+ dgraph_traverse_to(&target->node, run_test, &run);
+ if (run.pass)
+ run_test(&target->node, &run);
+ } else
+ dgraph_traverse_to(&all, run_test, &run);
+
+ printf("%sTotal score: %u/%u\n",
+ prefix, run.score, run.total);
+
+ return run.pass;
+}
+
int main(int argc, char *argv[])
{
bool summary = false, pass = true;
unsigned int i;
struct manifest *m;
- struct ccanlint *t;
+ struct ccanlint *target = NULL;
const char *prefix = "";
- char *dir = talloc_getcwd(NULL), *base_dir = dir, *target = NULL,
- *testlink;
+ char *dir = talloc_getcwd(NULL), *base_dir = dir, *testlink;
cmdline_exclude = btree_new(btree_strcmp);
info_exclude = btree_new(btree_strcmp);
+ opt_register_early_noarg("--verbose|-v", opt_inc_intval, &verbose,
+ "verbose mode (up to -vvvv)");
opt_register_noarg("-n|--safe-mode", opt_set_bool, &safe_mode,
"do not compile anything");
opt_register_noarg("-l|--list-tests", list_tests, NULL,
" (can be used multiple times, or 'all')");
opt_register_noarg("--summary|-s", opt_set_bool, &summary,
"simply give one line summary");
- opt_register_noarg("--verbose|-v", opt_inc_intval, &verbose,
- "verbose mode (up to -vvvv)");
opt_register_arg("-x|--exclude <testname>", skip_test, NULL, NULL,
"exclude <testname> (can be used multiple times)");
opt_register_arg("-t|--timeout <milleseconds>", opt_set_uintval,
NULL, &timeout,
"ignore (terminate) tests that are slower than this");
- opt_register_arg("--target <testname>", opt_set_charp,
+ opt_register_arg("--target <testname>", opt_set_target,
NULL, &target,
"only run one test (and its prerequisites)");
opt_register_arg("--compiler <compiler>", opt_set_const_charp,
" of CCAN modules.",
"This usage message");
+ /* Do verbose before anything else... */
+ opt_early_parse(argc, argv, opt_log_stderr_exit);
+
/* We move into temporary directory, so gcov dumps its files there. */
if (chdir(temp_dir(talloc_autofree_context())) != 0)
err(1, "Error changing to %s temporary dir", temp_dir(NULL));
- opt_parse(&argc, argv, opt_log_stderr_exit);
+ init_tests();
if (verbose >= 3) {
compile_verbose = true;
if (verbose >= 4)
tools_verbose = true;
+ opt_parse(&argc, argv, opt_log_stderr_exit);
+
/* This links back to the module's test dir. */
testlink = talloc_asprintf(NULL, "%s/test", temp_dir(NULL));
for (i = 1; i < argc; i++) {
unsigned int score, total_score;
+
dir = argv[i];
if (dir[0] != '/')
init_tests();
- if (target) {
- struct ccanlint *test;
-
- test = find_test(target);
- if (!test)
- errx(1, "Unknown test to run '%s'", target);
- skip_unrelated_tests(test);
- }
-
m = get_manifest(talloc_autofree_context(), dir);
/* FIXME: This has to come after we've got manifest. */
if (symlink(talloc_asprintf(m, "%s/test", dir), testlink) != 0)
err(1, "Creating test symlink in %s", temp_dir(NULL));
- /* If you don't pass the compulsory tests, score is 0. */
score = total_score = 0;
- while ((t = get_next_test(&compulsory_tests)) != NULL) {
- if (!run_test(t, summary, &score, &total_score, m,
- prefix)) {
- warnx("%s%s failed", prefix, t->name);
- printf("%sTotal score: 0/%u\n",
- prefix, total_score);
- pass = false;
- goto next;
- }
- }
-
- /* --target overrides known FAIL from _info */
- if (m->info_file)
- add_info_options(m->info_file, !target);
-
- while ((t = get_next_test(&normal_tests)) != NULL)
- pass &= run_test(t, summary, &score, &total_score, m,
- prefix);
-
- printf("%sTotal score: %u/%u\n", prefix, score, total_score);
- next: ;
+ if (!run_tests(target, summary, m, prefix))
+ pass = false;
}
return pass ? 0 : 1;
}