]> git.ozlabs.org Git - ccan/blobdiff - ccan/tdb2/transaction.c
tdb2: avoid C++ reserved words (ie. private)
[ccan] / ccan / tdb2 / transaction.c
index 2cab4655661768a80e44593211f152dd3c73175c..b80cede7581b9f1c177b4cbbb801dbca3de089c2 100644 (file)
@@ -347,14 +347,14 @@ static void transaction_write_existing(struct tdb_context *tdb, tdb_off_t off,
 static enum TDB_ERROR transaction_oob(struct tdb_context *tdb, tdb_off_t len,
                                      bool probe)
 {
-       if (len <= tdb->map_size) {
+       if (len <= tdb->file->map_size) {
                return TDB_SUCCESS;
        }
        if (!probe) {
                tdb_logerr(tdb, TDB_ERR_IO, TDB_LOG_ERROR,
                           "tdb_oob len %lld beyond transaction size %lld",
                           (long long)len,
-                          (long long)tdb->map_size);
+                          (long long)tdb->file->map_size);
        }
        return TDB_ERR_IO;
 }
@@ -369,9 +369,9 @@ static enum TDB_ERROR transaction_expand_file(struct tdb_context *tdb,
 
        /* add a write to the transaction elements, so subsequent
           reads see the zero data */
-       ecode = transaction_write(tdb, tdb->map_size, NULL, addition);
+       ecode = transaction_write(tdb, tdb->file->map_size, NULL, addition);
        if (ecode == TDB_SUCCESS) {
-               tdb->map_size += addition;
+               tdb->file->map_size += addition;
        }
        return ecode;
 }
@@ -430,15 +430,15 @@ static enum TDB_ERROR transaction_sync(struct tdb_context *tdb,
                return TDB_SUCCESS;
        }
 
-       if (fsync(tdb->fd) != 0) {
+       if (fsync(tdb->file->fd) != 0) {
                return tdb_logerr(tdb, TDB_ERR_IO, TDB_LOG_ERROR,
                                  "tdb_transaction: fsync failed: %s",
                                  strerror(errno));
        }
 #ifdef MS_SYNC
-       if (tdb->map_ptr) {
+       if (tdb->file->map_ptr) {
                tdb_off_t moffset = offset & ~(getpagesize()-1);
-               if (msync(moffset + (char *)tdb->map_ptr,
+               if (msync(moffset + (char *)tdb->file->map_ptr,
                          length + (offset - moffset), MS_SYNC) != 0) {
                        return tdb_logerr(tdb, TDB_ERR_IO, TDB_LOG_ERROR,
                                          "tdb_transaction: msync failed: %s",
@@ -467,7 +467,7 @@ static void _tdb_transaction_cancel(struct tdb_context *tdb)
                return;
        }
 
-       tdb->map_size = tdb->transaction->old_map_size;
+       tdb->file->map_size = tdb->transaction->old_map_size;
 
        /* free all the transaction blocks */
        for (i=0;i<tdb->transaction->num_blocks;i++) {
@@ -495,8 +495,8 @@ static void _tdb_transaction_cancel(struct tdb_context *tdb)
                }
        }
 
-       if (tdb->allrecord_lock.count)
-               tdb_allrecord_unlock(tdb, tdb->allrecord_lock.ltype);
+       if (tdb->file->allrecord_lock.count)
+               tdb_allrecord_unlock(tdb, tdb->file->allrecord_lock.ltype);
 
        /* restore the normal io methods */
        tdb->methods = tdb->transaction->io_methods;
@@ -519,32 +519,42 @@ enum TDB_ERROR tdb_transaction_start(struct tdb_context *tdb)
 
        /* some sanity checks */
        if (tdb->read_only || (tdb->flags & TDB_INTERNAL)) {
-               return tdb_logerr(tdb, TDB_ERR_EINVAL, TDB_LOG_USE_ERROR,
-                                 "tdb_transaction_start: cannot start a"
-                                 " transaction on a read-only or internal db");
+               return tdb->last_error = tdb_logerr(tdb, TDB_ERR_EINVAL,
+                                                   TDB_LOG_USE_ERROR,
+                                                   "tdb_transaction_start:"
+                                                   " cannot start a"
+                                                   " transaction on a "
+                                                   "read-only or internal db");
        }
 
        /* cope with nested tdb_transaction_start() calls */
        if (tdb->transaction != NULL) {
-               return tdb_logerr(tdb, TDB_ERR_IO, TDB_LOG_USE_ERROR,
-                                 "tdb_transaction_start:"
-                                 " already inside transaction");
+               return tdb->last_error = tdb_logerr(tdb, TDB_ERR_IO,
+                                                   TDB_LOG_USE_ERROR,
+                                                   "tdb_transaction_start:"
+                                                   " already inside"
+                                                   " transaction");
        }
 
        if (tdb_has_hash_locks(tdb)) {
                /* the caller must not have any locks when starting a
                   transaction as otherwise we'll be screwed by lack
                   of nested locks in POSIX */
-               return tdb_logerr(tdb, TDB_ERR_LOCK, TDB_LOG_USE_ERROR,
-                                 "tdb_transaction_start: cannot start a"
-                                 " transaction with locks held");
+               return tdb->last_error = tdb_logerr(tdb, TDB_ERR_LOCK,
+                                                   TDB_LOG_USE_ERROR,
+                                                   "tdb_transaction_start:"
+                                                   " cannot start a"
+                                                   " transaction with locks"
+                                                   " held");
        }
 
        tdb->transaction = (struct tdb_transaction *)
                calloc(sizeof(struct tdb_transaction), 1);
        if (tdb->transaction == NULL) {
-               return tdb_logerr(tdb, TDB_ERR_OOM, TDB_LOG_ERROR,
-                                 "tdb_transaction_start: cannot allocate");
+               return tdb->last_error = tdb_logerr(tdb, TDB_ERR_OOM,
+                                                   TDB_LOG_ERROR,
+                                                   "tdb_transaction_start:"
+                                                   " cannot allocate");
        }
 
        /* get the transaction write lock. This is a blocking lock. As
@@ -554,7 +564,7 @@ enum TDB_ERROR tdb_transaction_start(struct tdb_context *tdb)
        if (ecode != TDB_SUCCESS) {
                SAFE_FREE(tdb->transaction->blocks);
                SAFE_FREE(tdb->transaction);
-               return ecode;
+               return tdb->last_error = ecode;
        }
 
        /* get a read lock over entire file. This is upgraded to a write
@@ -566,20 +576,20 @@ enum TDB_ERROR tdb_transaction_start(struct tdb_context *tdb)
 
        /* make sure we know about any file expansions already done by
           anyone else */
-       tdb->methods->oob(tdb, tdb->map_size + 1, true);
-       tdb->transaction->old_map_size = tdb->map_size;
+       tdb->methods->oob(tdb, tdb->file->map_size + 1, true);
+       tdb->transaction->old_map_size = tdb->file->map_size;
 
        /* finally hook the io methods, replacing them with
           transaction specific methods */
        tdb->transaction->io_methods = tdb->methods;
        tdb->methods = &transaction_methods;
-       return TDB_SUCCESS;
+       return tdb->last_error = TDB_SUCCESS;
 
 fail_allrecord_lock:
        tdb_transaction_unlock(tdb, F_WRLCK);
        SAFE_FREE(tdb->transaction->blocks);
        SAFE_FREE(tdb->transaction);
-       return ecode;
+       return tdb->last_error = ecode;
 }
 
 
@@ -689,16 +699,16 @@ static enum TDB_ERROR tdb_recovery_allocate(struct tdb_context *tdb,
                = (((sizeof(rec) + *recovery_size) + getpagesize()-1)
                   & ~(getpagesize()-1))
                - sizeof(rec);
-       *recovery_offset = tdb->map_size;
+       *recovery_offset = tdb->file->map_size;
        recovery_head = *recovery_offset;
 
        /* Restore ->map_size before calling underlying expand_file.
           Also so that we don't try to expand the file again in the
           transaction commit, which would destroy the recovery
           area */
-       addition = (tdb->map_size - tdb->transaction->old_map_size) +
+       addition = (tdb->file->map_size - tdb->transaction->old_map_size) +
                sizeof(rec) + *recovery_max_size;
-       tdb->map_size = tdb->transaction->old_map_size;
+       tdb->file->map_size = tdb->transaction->old_map_size;
        ecode = methods->expand_file(tdb, addition);
        if (ecode != TDB_SUCCESS) {
                return tdb_logerr(tdb, ecode, TDB_LOG_ERROR,
@@ -709,7 +719,7 @@ static enum TDB_ERROR tdb_recovery_allocate(struct tdb_context *tdb,
        /* we have to reset the old map size so that we don't try to
           expand the file again in the transaction commit, which
           would destroy the recovery area */
-       tdb->transaction->old_map_size = tdb->map_size;
+       tdb->transaction->old_map_size = tdb->file->map_size;
 
        /* write the recovery header offset and sync - we can sync without a race here
           as the magic ptr in the recovery record has not been set */
@@ -797,7 +807,7 @@ static enum TDB_ERROR transaction_setup_recovery(struct tdb_context *tdb,
                if (offset >= old_map_size) {
                        continue;
                }
-               if (offset + length > tdb->map_size) {
+               if (offset + length > tdb->file->map_size) {
                        free(data);
                        return tdb_logerr(tdb, TDB_ERR_CORRUPT, TDB_LOG_ERROR,
                                          "tdb_transaction_setup_recovery:"
@@ -945,10 +955,12 @@ static enum TDB_ERROR _tdb_transaction_prepare_commit(struct tdb_context *tdb)
        tdb->transaction->prepared = true;
 
        /* expand the file to the new size if needed */
-       if (tdb->map_size != tdb->transaction->old_map_size) {
-               tdb_len_t add = tdb->map_size - tdb->transaction->old_map_size;
+       if (tdb->file->map_size != tdb->transaction->old_map_size) {
+               tdb_len_t add;
+
+               add = tdb->file->map_size - tdb->transaction->old_map_size;
                /* Restore original map size for tdb_expand_file */
-               tdb->map_size = tdb->transaction->old_map_size;
+               tdb->file->map_size = tdb->transaction->old_map_size;
                ecode = methods->expand_file(tdb, add);
                if (ecode != TDB_SUCCESS) {
                        tdb_logerr(tdb, ecode, TDB_LOG_ERROR,
@@ -981,27 +993,29 @@ enum TDB_ERROR tdb_transaction_commit(struct tdb_context *tdb)
        enum TDB_ERROR ecode;
 
        if (tdb->transaction == NULL) {
-               return tdb_logerr(tdb, TDB_ERR_EINVAL, TDB_LOG_USE_ERROR,
-                                 "tdb_transaction_commit: no transaction");
+               return tdb->last_error = tdb_logerr(tdb, TDB_ERR_EINVAL,
+                                                   TDB_LOG_USE_ERROR,
+                                                   "tdb_transaction_commit:"
+                                                   " no transaction");
        }
 
        tdb_trace(tdb, "tdb_transaction_commit");
 
        if (tdb->transaction->nesting != 0) {
                tdb->transaction->nesting--;
-               return TDB_SUCCESS;
+               return tdb->last_error = TDB_SUCCESS;
        }
 
        /* check for a null transaction */
        if (tdb->transaction->blocks == NULL) {
                _tdb_transaction_cancel(tdb);
-               return TDB_SUCCESS;
+               return tdb->last_error = TDB_SUCCESS;
        }
 
        if (!tdb->transaction->prepared) {
                ecode = _tdb_transaction_prepare_commit(tdb);
                if (ecode != TDB_SUCCESS)
-                       return ecode;
+                       return tdb->last_error = ecode;
        }
 
        methods = tdb->transaction->io_methods;
@@ -1036,7 +1050,7 @@ enum TDB_ERROR tdb_transaction_commit(struct tdb_context *tdb)
 
                        _tdb_transaction_cancel(tdb);
 
-                       return ecode;
+                       return tdb->last_error = ecode;
                }
                SAFE_FREE(tdb->transaction->blocks[i]);
        }
@@ -1045,9 +1059,9 @@ enum TDB_ERROR tdb_transaction_commit(struct tdb_context *tdb)
        tdb->transaction->num_blocks = 0;
 
        /* ensure the new data is on disk */
-       ecode = transaction_sync(tdb, 0, tdb->map_size);
+       ecode = transaction_sync(tdb, 0, tdb->file->map_size);
        if (ecode != TDB_SUCCESS) {
-               return ecode;
+               return tdb->last_error = ecode;
        }
 
        /*
@@ -1069,7 +1083,7 @@ enum TDB_ERROR tdb_transaction_commit(struct tdb_context *tdb)
           transaction locks */
        _tdb_transaction_cancel(tdb);
 
-       return TDB_SUCCESS;
+       return tdb->last_error = TDB_SUCCESS;
 }
 
 
@@ -1159,7 +1173,7 @@ enum TDB_ERROR tdb_transaction_recover(struct tdb_context *tdb)
 
        free(data);
 
-       ecode = transaction_sync(tdb, 0, tdb->map_size);
+       ecode = transaction_sync(tdb, 0, tdb->file->map_size);
        if (ecode != TDB_SUCCESS) {
                return tdb_logerr(tdb, ecode, TDB_LOG_ERROR,
                                  "tdb_transaction_recover:"