]> git.ozlabs.org Git - ccan/blobdiff - ccan/tally/tally.c
tally: Adapt tally_add to Samba coding conventions
[ccan] / ccan / tally / tally.c
index 1c471c1503ec51ff57177db1d71d0ffaa5019455..28a66a9f7fa0ebf384c62d69de8b04b396f71cad 100644 (file)
@@ -73,8 +73,9 @@ static ssize_t bucket_min(ssize_t min, unsigned step_bits, unsigned b)
 /* Does shifting by this many bits truncate the number? */
 static bool shift_overflows(size_t num, unsigned bits)
 {
-       if (bits == 0)
+       if (bits == 0) {
                return false;
+       }
 
        return ((num << bits) >> 1) != (num << (bits - 1));
 }
@@ -87,8 +88,9 @@ static void renormalize(struct tally *tally,
        unsigned int i, old_min;
 
        /* Uninitialized?  Don't do anything... */
-       if (tally->max < tally->min)
+       if (tally->max < tally->min) {
                goto update;
+       }
 
        /* If we don't have sufficient range, increase step bits until
         * buckets cover entire range of ssize_t anyway. */
@@ -136,15 +138,17 @@ void tally_add(struct tally *tally, ssize_t val)
                new_max = val;
                need_renormalize = true;
        }
-       if (need_renormalize)
+       if (need_renormalize) {
                renormalize(tally, new_min, new_max);
+       }
 
        /* 128-bit arithmetic!  If we didn't want exact mean, we could just
         * pull it out of counts. */
-       if (val > 0 && tally->total[0] + val < tally->total[0])
+       if (val > 0 && tally->total[0] + val < tally->total[0]) {
                tally->total[1]++;
-       else if (val < 0 && tally->total[0] + val > tally->total[0])
+       } else if (val < 0 && tally->total[0] + val > tally->total[0]) {
                tally->total[1]--;
+       }
        tally->total[0] += val;
        tally->counts[bucket_of(tally->min, tally->step_bits, val)]++;
 }