]> git.ozlabs.org Git - ccan/blobdiff - ccan/io/poll.c
Merge branch 'io'
[ccan] / ccan / io / poll.c
index 9f9bb4a256168699eecec1dc062855475766e899..31a56600fe487b836e8bf1b8bdb88ecfa75953e0 100644 (file)
@@ -7,11 +7,55 @@
 #include <sys/types.h>
 #include <sys/socket.h>
 #include <limits.h>
+#include <errno.h>
 
 static size_t num_fds = 0, max_fds = 0, num_closing = 0, num_waiting = 0;
 static struct pollfd *pollfds = NULL;
 static struct fd **fds = NULL;
 static struct timers timeouts;
+#ifdef DEBUG
+static unsigned int io_loop_level;
+static struct io_conn *free_later;
+static void io_loop_enter(void)
+{
+       io_loop_level++;
+}
+static void io_loop_exit(void)
+{
+       io_loop_level--;
+       if (io_loop_level == 0) {
+               /* Delayed free. */
+               while (free_later) {
+                       struct io_conn *c = free_later;
+                       free_later = c->finish_arg;
+                       free(c);
+               }
+       }
+}
+static void free_conn(struct io_conn *conn)
+{
+       /* Only free on final exit: chain via finish. */
+       if (io_loop_level > 1) {
+               struct io_conn *c;
+               for (c = free_later; c; c = c->finish_arg)
+                       assert(c != conn);
+               conn->finish_arg = free_later;
+               free_later = conn;
+       } else
+               free(conn);
+}
+#else
+static void io_loop_enter(void)
+{
+}
+static void io_loop_exit(void)
+{
+}
+static void free_conn(struct io_conn *conn)
+{
+       free(conn);
+}
+#endif
 
 static bool add_fd(struct fd *fd, short events)
 {
@@ -31,8 +75,12 @@ static bool add_fd(struct fd *fd, short events)
                max_fds = num;
        }
 
-       pollfds[num_fds].fd = fd->fd;
        pollfds[num_fds].events = events;
+       /* In case it's idle. */
+       if (!events)
+               pollfds[num_fds].fd = -fd->fd;
+       else
+               pollfds[num_fds].fd = fd->fd;
        pollfds[num_fds].revents = 0; /* In case we're iterating now */
        fds[num_fds] = fd;
        fd->backend_info = num_fds;
@@ -79,7 +127,13 @@ bool add_listener(struct io_listener *l)
 
 void backend_plan_changed(struct io_conn *conn)
 {
-       struct pollfd *pfd = &pollfds[conn->fd.backend_info];
+       struct pollfd *pfd;
+
+       /* This can happen with debugging and delayed free... */
+       if (conn->fd.backend_info == -1)
+               return;
+
+       pfd = &pollfds[conn->fd.backend_info];
 
        if (pfd->events)
                num_waiting--;
@@ -91,8 +145,11 @@ void backend_plan_changed(struct io_conn *conn)
                assert(!mask || pfd->events != mask);
                pfd->events |= mask;
        }
-       if (pfd->events)
+       if (pfd->events) {
                num_waiting++;
+               pfd->fd = conn->fd.fd;
+       } else
+               pfd->fd = -conn->fd.fd;
 
        if (!conn->plan.next)
                num_closing++;
@@ -115,10 +172,12 @@ bool add_duplex(struct io_conn *c)
        return true;
 }
 
-static void del_conn(struct io_conn *conn)
+void backend_del_conn(struct io_conn *conn)
 {
-       if (conn->finish)
+       if (conn->finish) {
+               errno = conn->plan.u.close.saved_errno;
                conn->finish(conn, conn->finish_arg);
+       }
        if (timeout_active(conn))
                backend_del_timeout(conn);
        free(conn->timeout);
@@ -126,9 +185,11 @@ static void del_conn(struct io_conn *conn)
                /* In case fds[] pointed to the other one. */
                fds[conn->fd.backend_info] = &conn->duplex->fd;
                conn->duplex->duplex = NULL;
+               conn->fd.backend_info = -1;
        } else
                del_fd(&conn->fd);
        num_closing--;
+       free_conn(conn);
 }
 
 void del_listener(struct io_listener *l)
@@ -153,7 +214,7 @@ static void accept_conn(struct io_listener *l)
 }
 
 /* It's OK to miss some, as long as we make progress. */
-static void finish_conns(void)
+static bool finish_conns(struct io_conn **ready)
 {
        unsigned int i;
 
@@ -168,12 +229,16 @@ static void finish_conns(void)
                c = (void *)fds[i];
                for (duplex = c->duplex; c; c = duplex, duplex = NULL) {
                        if (!c->plan.next) {
-                               del_conn(c);
-                               free(c);
+                               if (doing_debug_on(c) && ready) {
+                                       *ready = c;
+                                       return true;
+                               }
+                               backend_del_conn(c);
                                i--;
                        }
                }
        }
+       return false;
 }
 
 void backend_add_timeout(struct io_conn *conn, struct timespec duration)
@@ -193,13 +258,16 @@ void backend_del_timeout(struct io_conn *conn)
 }
 
 /* This is the main loop. */
-void *io_loop(void)
+void *do_io_loop(struct io_conn **ready)
 {
        void *ret;
 
+       io_loop_enter();
+
        while (!io_loop_return) {
                int i, r, timeout = INT_MAX;
                struct timespec now;
+               bool some_timeouts = false;
 
                if (timeouts.base) {
                        struct timespec first;
@@ -214,7 +282,9 @@ void *io_loop(void)
                                struct io_conn *conn = t->conn;
                                /* Clear, in case timer re-adds */
                                t->conn = NULL;
+                               set_current(conn);
                                set_plan(conn, t->next(conn, t->next_arg));
+                               some_timeouts = true;
                        }
 
                        /* Now figure out how long to wait for the next one. */
@@ -226,11 +296,17 @@ void *io_loop(void)
                }
 
                if (num_closing) {
-                       finish_conns();
+                       /* If this finishes a debugging con, return now. */
+                       if (finish_conns(ready))
+                               return NULL;
                        /* Could have started/finished more. */
                        continue;
                }
 
+               /* debug can recurse on io_loop; anything can change. */
+               if (doing_debug() && some_timeouts)
+                       continue;
+
                if (num_fds == 0)
                        break;
 
@@ -258,27 +334,55 @@ void *io_loop(void)
                                if (c->duplex) {
                                        int mask = c->duplex->plan.pollflag;
                                        if (events & mask) {
+                                               if (doing_debug_on(c->duplex)
+                                                       && ready) {
+                                                       *ready = c->duplex;
+                                                       return NULL;
+                                               }
                                                io_ready(c->duplex);
                                                events &= ~mask;
+                                               /* debug can recurse;
+                                                * anything can change. */
+                                               if (doing_debug())
+                                                       break;
                                                if (!(events&(POLLIN|POLLOUT)))
                                                        continue;
                                        }
                                }
+                               if (doing_debug_on(c) && ready) {
+                                       *ready = c;
+                                       return NULL;
+                               }
                                io_ready(c);
-                       } else if (events & POLLHUP) {
+                               /* debug can recurse; anything can change. */
+                               if (doing_debug())
+                                       break;
+                       } else if (events & (POLLHUP|POLLNVAL|POLLERR)) {
                                r--;
-                               set_plan(c, io_close(c, NULL));
-                               if (c->duplex)
-                                       set_plan(c->duplex,
-                                                io_close(c->duplex, NULL));
+                               set_current(c);
+                               errno = EBADF;
+                               set_plan(c, io_close());
+                               if (c->duplex) {
+                                       set_current(c->duplex);
+                                       set_plan(c->duplex, io_close());
+                               }
                        }
                }
        }
 
-       while (num_closing)
-               finish_conns();
+       while (num_closing && !io_loop_return) {
+               if (finish_conns(ready))
+                       return NULL;
+       }
 
        ret = io_loop_return;
        io_loop_return = NULL;
+
+       io_loop_exit();
        return ret;
 }
+
+void *io_loop(void)
+{
+       return do_io_loop(NULL);
+}