A void * could point to anything, but a void ** can't point to any pointer.
So we use a void * and memcpy, which I believe is safe.
void _talloc_set(void *ptr, const void *ctx, size_t size, const char *name)
{
void ***child;
void _talloc_set(void *ptr, const void *ctx, size_t size, const char *name)
{
void ***child;
- *pptr = talloc_named_const(ctx, size, name);
- if (unlikely(!*pptr))
- return;
+ p = talloc_named_const(ctx, size, name);
+ if (unlikely(!p))
+ goto set_ptr;
- child = talloc(*pptr, void **);
+ child = talloc(p, void **);
- talloc_free(*pptr);
- *pptr = NULL;
- return;
+ talloc_free(p);
+ p = NULL;
+ goto set_ptr;
talloc_set_name_const(child, "talloc_set destructor");
talloc_set_destructor(child, talloc_destroy_pointer);
talloc_set_name_const(child, "talloc_set destructor");
talloc_set_destructor(child, talloc_destroy_pointer);
+
+set_ptr:
+ /* memcpy rather than cast avoids aliasing problems. */
+ memcpy(ptr, &p, sizeof(p));