Don't implicitly cast away const in the tests.
int main(int argc, char *argv[])
{
int main(int argc, char *argv[])
{
+ char str[] = "hello world";
#ifdef FAIL
int *p;
#if !HAVE_TYPEOF||!HAVE_BUILTIN_CHOOSE_EXPR||!HAVE_BUILTIN_TYPES_COMPATIBLE_P
#ifdef FAIL
int *p;
#if !HAVE_TYPEOF||!HAVE_BUILTIN_CHOOSE_EXPR||!HAVE_BUILTIN_TYPES_COMPATIBLE_P
p = NULL;
/* This should work always. */
p = NULL;
/* This should work always. */
- register_callback(my_callback, "hello world");
+ register_callback(my_callback, str);
/* This will fail with FAIL defined */
register_callback(my_callback, p);
/* This will fail with FAIL defined */
register_callback(my_callback, p);
/* NULL args for callback function should be OK for _exact and _def. */
/* NULL args for callback function should be OK for _exact and _def. */
-static void _register_callback(void (*cb)(void *arg), void *arg)
+static void _register_callback(void (*cb)(const void *arg), const void *arg)
int main(int argc, char *argv[])
{
int main(int argc, char *argv[])
{
- register_callback(my_callback, "hello world");
- register_callback_def(my_callback, "hello world");
- register_callback_pre(my_callback_pre, "hello world");
- register_callback_post(my_callback_post, "hello world");
+ char p[] = "hello world";
+ register_callback(my_callback, p);
+ register_callback_def(my_callback, p);
+ register_callback_pre(my_callback_pre, p);
+ register_callback_post(my_callback_post, p);
int main(int argc, char *argv[])
{
int main(int argc, char *argv[])
{
- register_callback(my_callback, "hello world");
- register_callback_pre(my_callback_pre, "hello world");
- register_callback_post(my_callback_post, "hello world");
+ char p[] = "hello world";
+ register_callback(my_callback, p);
+ register_callback_pre(my_callback_pre, p);
+ register_callback_post(my_callback_post, p);
int main(int argc, char *argv[])
{
int main(int argc, char *argv[])
{
- register_callback(my_callback, "hello world");
- register_callback_pre(my_callback_pre, "hello world");
- register_callback_post(my_callback_post, "hello world");
+ char p[] = "hello world";
+ register_callback(my_callback, p);
+ register_callback_pre(my_callback_pre, p);
+ register_callback_post(my_callback_post, p);
#include <ccan/typesafe_cb/typesafe_cb.h>
#include <string.h>
#include <ccan/typesafe_cb/typesafe_cb.h>
#include <string.h>
#include <ccan/tap/tap.h>
static char dummy = 0;
#include <ccan/tap/tap.h>
static char dummy = 0;
static void my_callback_onearg_volatile(volatile char *p)
{
static void my_callback_onearg_volatile(volatile char *p)
{
- ok1(strcmp((char *)p, "hello world") == 0);
+ /* Double cast avoids warning on gcc's -Wcast-qual */
+ ok1(strcmp((char *)(intptr_t)p, "hello world") == 0);
}
static void my_callback_preargs(int a, int b, char *p)
}
static void my_callback_preargs(int a, int b, char *p)
struct callback_onearg
{
void (*fn)(void *arg);
struct callback_onearg
{
void (*fn)(void *arg);
};
struct callback_onearg cb_onearg
};
struct callback_onearg cb_onearg
-= { typesafe_cb(void, my_callback_onearg, "hello world"), "hello world" };
+= { typesafe_cb(void, my_callback_onearg, (char *)(intptr_t)"hello world"),
+ "hello world" };
struct callback_preargs
{
void (*fn)(int a, int b, void *arg);
struct callback_preargs
{
void (*fn)(int a, int b, void *arg);
};
struct callback_preargs cb_preargs
};
struct callback_preargs cb_preargs
-= { typesafe_cb_preargs(void, my_callback_preargs, "hi", int, int), "hi" };
+= { typesafe_cb_preargs(void, my_callback_preargs,
+ (char *)(intptr_t)"hi", int, int), "hi" };
struct callback_postargs
{
void (*fn)(void *arg, int a, int b);
struct callback_postargs
{
void (*fn)(void *arg, int a, int b);
};
struct callback_postargs cb_postargs
};
struct callback_postargs cb_postargs
-= { typesafe_cb_postargs(void, my_callback_postargs, "hi", int, int), "hi" };
+= { typesafe_cb_postargs(void, my_callback_postargs,
+ (char *)(intptr_t)"hi", int, int), "hi" };
int main(int argc, char *argv[])
{
void *p = &dummy;
unsigned long l = (unsigned long)p;
int main(int argc, char *argv[])
{
void *p = &dummy;
unsigned long l = (unsigned long)p;
+ char str[] = "hello world";
plan_tests(2 + 3 + 3 + 3);
set_some_value(p);
set_some_value(l);
plan_tests(2 + 3 + 3 + 3);
set_some_value(p);
set_some_value(l);
- callback_onearg(my_callback_onearg, "hello world");
- callback_onearg(my_callback_onearg_const, "hello world");
- callback_onearg(my_callback_onearg_volatile, "hello world");
+ callback_onearg(my_callback_onearg, str);
+ callback_onearg(my_callback_onearg_const, str);
+ callback_onearg(my_callback_onearg_volatile, str);
- callback_preargs(my_callback_preargs, "hello world");
+ callback_preargs(my_callback_preargs, str);
- callback_preargs(my_callback_preargs_const, "hello world");
- callback_preargs(my_callback_preargs_volatile, "hello world");
+ callback_preargs(my_callback_preargs_const, str);
+ callback_preargs(my_callback_preargs_volatile, str);
- callback_postargs(my_callback_postargs, "hello world");
+ callback_postargs(my_callback_postargs, str);
- callback_postargs(my_callback_postargs_const, "hello world");
- callback_postargs(my_callback_postargs_volatile, "hello world");
+ callback_postargs(my_callback_postargs_const, str);
+ callback_postargs(my_callback_postargs_volatile, str);
#endif
return exit_status();
#endif
return exit_status();