1 #include <tools/ccanlint/ccanlint.h>
2 #include <tools/tools.h>
3 #include <ccan/str/str.h>
4 #include <ccan/take/take.h>
5 #include <ccan/foreach/foreach.h>
6 #include <ccan/tal/grab_file/grab_file.h>
7 #include "tests_pass.h"
20 /* Note: we already test safe_mode in run_tests.c */
21 static const char *can_run_vg(struct manifest *m)
24 return tal_fmt(m, "No valgrind support");
28 static void do_leakcheck_vg(struct manifest *m,
29 unsigned int *timeleft,
32 static struct ccanlint tests_pass_valgrind_noleaks = {
33 .key = "tests_pass_valgrind_noleaks",
34 .name = "Module's run and api tests have no memory leaks",
35 .check = do_leakcheck_vg,
36 .takes_options = true,
37 .needs = "tests_pass_valgrind"
39 REGISTER_TEST(tests_pass_valgrind_noleaks);
43 ==2749== Conditional jump or move depends on uninitialised value(s)
44 ==2749== at 0x4026C60: strnlen (mc_replace_strmem.c:263)
45 ==2749== by 0x40850E3: vfprintf (vfprintf.c:1614)
46 ==2749== by 0x408EACF: printf (printf.c:35)
47 ==2749== by 0x8048465: main (in /tmp/foo)
49 ==2749== 1 bytes in 1 blocks are definitely lost in loss record 1 of 1
50 ==2749== at 0x4025BD3: malloc (vg_replace_malloc.c:236)
51 ==2749== by 0x8048444: main (in /tmp/foo)
55 static bool blank_line(const char *line)
57 return line[strspn(line, "=0123456789 ")] == '\0';
60 /* Removes matching lines from lines array, returns them. FIXME: Hacky. */
61 static char **extract_matching(const char *prefix, char *lines[])
63 unsigned int i, num_ret = 0;
64 char **ret = tal_arr(lines, char *, tal_count(lines));
66 for (i = 0; i < tal_count(lines) - 1; i++) {
67 if (strstarts(lines[i], prefix)) {
68 ret[num_ret++] = tal_strdup(ret, lines[i]);
69 lines[i] = (char *)"";
72 ret[num_ret++] = NULL;
74 /* Make sure tal_count is correct! */
75 tal_resize(&ret, num_ret);
79 static char *get_leaks(char *lines[], char **errs)
81 char *leaks = tal_strdup(lines, "");
84 for (i = 0; i < tal_count(lines) - 1; i++) {
85 if (strstr(lines[i], " lost ")) {
87 if (strstr(lines[i], " definitely lost ")) {
88 /* Definite leak, report. */
89 while (lines[i] && !blank_line(lines[i])) {
90 tal_append_fmt(&leaks, "%s\n",
95 /* Not definite, ignore. */
96 while (lines[i] && !blank_line(lines[i]))
100 while (lines[i] && !blank_line(lines[i])) {
102 *errs = tal_fmt(NULL, "%s\n", lines[i]);
104 tal_append_fmt(errs, "%s\n", lines[i]);
112 /* Returns leaks, and sets errs[] */
113 static char *analyze_output(const char *output, char **errs)
115 char *leaks = tal_strdup(output, "");
117 char **lines = tal_strsplit(output, output, "\n", STR_EMPTY_OK);
119 *errs = tal_strdup(output, "");
120 for (i = 0; i < tal_count(lines) - 1; i++) {
121 unsigned int preflen = strspn(lines[i], "=0123456789");
122 char *prefix, **sublines;
124 /* Ignore erased lines, or weird stuff. */
128 prefix = tal_strndup(output, lines[i], preflen);
129 sublines = extract_matching(prefix, lines);
131 leaks = tal_strcat(output, take(leaks),
132 take(get_leaks(sublines, errs)));
146 static const char *concat(struct score *score, char *bits[])
149 char *ret = tal_strdup(score, "");
151 for (i = 0; bits[i]; i++) {
153 ret = tal_strcat(score, take(ret), " ");
154 ret = tal_strcat(score, take(ret), bits[i]);
159 /* FIXME: Run examples, too! */
160 static void do_run_tests_vg(struct manifest *m,
161 unsigned int *timeleft,
165 struct list_head *list;
167 /* This is slow, so we run once but grab leak info. */
170 foreach_ptr(list, &m->run_tests, &m->api_tests) {
171 list_for_each(list, i, list) {
176 options = concat(score,
177 per_file_options(&tests_pass_valgrind,
179 if (streq(options, "FAIL")) {
184 output = grab_file(i, i->valgrind_log);
185 /* No valgrind errors? */
186 if (!output || output[0] == '\0') {
190 i->leak_info = analyze_output(output, &err);
193 score_file_error(score, i, 0, "%s", err);
201 static void do_leakcheck_vg(struct manifest *m,
202 unsigned int *timeleft,
206 struct list_head *list;
210 foreach_ptr(list, &m->run_tests, &m->api_tests) {
211 list_for_each(list, i, list) {
212 options = per_file_options(&tests_pass_valgrind_noleaks,
215 if (streq(options[0], "FAIL")) {
219 errx(1, "Unknown leakcheck options '%s'",
224 score_file_error(score, i, 0, "%s",
231 /* FIXME: We don't fail for this, since many tests leak. */
238 /* Gcc's warn_unused_result is fascist bullshit. */
239 #define doesnt_matter()
241 static void run_under_debugger_vg(struct manifest *m, struct score *score)
243 struct file_error *first;
246 /* Don't ask anything if they suppressed tests. */
250 if (!ask("Should I run the first failing test under the debugger?"))
253 first = list_top(&score->per_file_errors, struct file_error, list);
254 command = tal_fmt(m, "valgrind --leak-check=full --db-attach=yes%s %s %s",
255 concat(score, per_file_options(&tests_pass_valgrind,
257 valgrind_suppress, first->file->compiled[COMPILE_NORMAL]);
262 struct ccanlint tests_pass_valgrind = {
263 .key = "tests_pass_valgrind",
264 .name = "Module's run and api tests succeed under valgrind",
265 .can_run = can_run_vg,
266 .check = do_run_tests_vg,
267 .handle = run_under_debugger_vg,
268 .takes_options = true,
269 .needs = "tests_pass"
271 REGISTER_TEST(tests_pass_valgrind);