1 #include <tools/ccanlint/ccanlint.h>
2 #include <tools/tools.h>
3 #include <ccan/talloc/talloc.h>
4 #include <ccan/str/str.h>
17 static bool have_dep(struct manifest *m, const char *dep)
21 list_for_each(&m->deps, i, list)
22 if (streq(i->modname, dep + strlen("ccan/")))
28 static bool add_dep(struct manifest *m,
29 struct list_head *deplist,
30 const char *dep, struct score *score)
33 struct manifest *subm;
34 char *dir = talloc_asprintf(m, "%s/%s", ccan_dir, dep);
36 /* FIXME: get_manifest has a tendency to exit. */
37 if (stat(dir, &st) != 0) {
40 "Could not stat dependency %s: %s",
41 dir, strerror(errno));
44 subm = get_manifest(m, dir);
45 list_add_tail(deplist, &subm->list);
49 /* FIXME: check this is still true once we reduce features. */
50 static void check_depends_exist(struct manifest *m,
51 unsigned int *timeleft, struct score *score)
57 deps = get_safe_ccan_deps(m, m->dir, "depends", true);
59 deps = get_deps(m, m->dir, "depends", true,
62 for (i = 0; deps[i]; i++) {
63 if (!strstarts(deps[i], "ccan/"))
66 if (!add_dep(m, &m->deps, deps[i], score))
71 score->score = score->total;
74 static void check_test_depends_exist(struct manifest *m,
75 unsigned int *timeleft,
82 /* We may need libtap for testing, unless we're "tap" */
83 if (streq(m->modname, "tap")) {
85 } else if (list_empty(&m->run_tests) && list_empty(&m->api_tests)) {
92 deps = get_safe_ccan_deps(m, m->dir, "testdepends", true);
94 deps = get_deps(m, m->dir, "testdepends", true,
97 for (i = 0; deps[i]; i++) {
98 if (!strstarts(deps[i], "ccan/"))
101 /* Don't add dependency twice: we can only be on one list! */
102 if (!have_dep(m, deps[i])
103 && !add_dep(m, &m->test_deps, deps[i], score))
106 if (streq(deps[i], "ccan/tap")) {
111 if (needs_tap && !have_dep(m, "ccan/tap")
112 && !add_dep(m, &m->test_deps, "ccan/tap", score)) {
117 score->score = score->total;
120 struct ccanlint depends_exist = {
121 .key = "depends_exist",
122 .name = "Module's CCAN dependencies can be found",
124 .check = check_depends_exist,
125 .needs = "info_exists"
128 REGISTER_TEST(depends_exist);
130 struct ccanlint test_depends_exist = {
131 .key = "test_depends_exist",
132 .name = "Module's CCAN test dependencies can be found",
134 .check = check_test_depends_exist,
135 .needs = "depends_exist"
138 REGISTER_TEST(test_depends_exist);