1 #include <tools/ccanlint/ccanlint.h>
2 #include <tools/tools.h>
3 #include <ccan/str/str.h>
4 #include <ccan/take/take.h>
5 #include <ccan/foreach/foreach.h>
18 static bool has_dep(struct manifest *m, char **deps, bool *used,
23 /* We can include ourselves, of course. */
24 if (streq(depname + strlen("ccan/"), m->modname))
27 for (i = 0; deps[i]; i++) {
28 if (streq(deps[i], depname)) {
36 static bool check_dep_includes(struct manifest *m,
37 char **deps, bool *used,
42 char **lines = get_ccan_file_lines(f);
43 struct line_info *li = get_ccan_line_info(f);
46 for (i = 0; lines[i]; i++) {
48 if (!tal_strreg(f, lines[i],
49 "^[ \t]*#[ \t]*include[ \t]*[<\"]"
50 "(ccan/+.+)/+[^/]+\\.h", &mod))
53 if (has_dep(m, deps, used, mod))
56 /* FIXME: we can't be sure about
57 * conditional includes, so don't
60 score_file_error(score, f, i+1,
61 "%s not listed in _info", mod);
68 static void check_depends_accurate(struct manifest *m,
69 unsigned int *timeleft, struct score *score)
71 struct list_head *list;
72 unsigned int i, core_deps, test_deps;
77 /* Get the *direct* dependencies. */
79 deps = get_safe_ccan_deps(m, m->dir, "depends", false);
80 tdeps = get_safe_ccan_deps(m, m->dir, "testdepends", false);
82 deps = get_deps(m, m->dir, "depends", false,
84 tdeps = get_deps(m, m->dir, "testdepends", false,
88 core_deps = tal_count(deps) - 1;
89 test_deps = tal_count(tdeps) - 1;
91 used = tal_arrz(m, bool, core_deps + test_deps + 1);
93 foreach_ptr(list, &m->c_files, &m->h_files) {
96 list_for_each(list, f, list)
97 ok &= check_dep_includes(m, deps, used, score, f);
100 for (i = 0; i < core_deps; i++) {
101 if (!used[i] && strstarts(deps[i], "ccan/"))
102 score_file_error(score, m->info_file, 0,
103 "%s is an unused dependency",
107 /* Now remove NUL and append test dependencies to deps. */
108 deps = tal_dup(m, char *, take(deps), core_deps, test_deps + 2);
109 memcpy(deps + core_deps, tdeps, sizeof(tdeps[0]) * test_deps);
110 /* ccan/tap is given a free pass. */
111 deps[core_deps + test_deps] = (char *)"ccan/tap";
112 deps[core_deps + test_deps + 1] = NULL;
114 foreach_ptr(list, &m->run_tests, &m->api_tests,
115 &m->compile_ok_tests, &m->compile_fail_tests,
116 &m->other_test_c_files) {
119 list_for_each(list, f, list)
120 ok &= check_dep_includes(m, deps, used, score, f);
123 for (i = core_deps; i < test_deps; i++) {
125 score_file_error(score, m->info_file, 0,
126 "%s is an unused test dependency",
131 score->score = score->total;
133 /* We don't count unused dependencies as an error (yet!) */
137 struct ccanlint depends_accurate = {
138 .key = "depends_accurate",
139 .name = "Module's CCAN dependencies are the only CCAN files #included",
140 .check = check_depends_accurate,
141 .needs = "depends_exist test_depends_exist"
144 REGISTER_TEST(depends_accurate);