prom_getchar eats characters
authorAnton Blanchard <anton@samba.org>
Sat, 10 Apr 2010 18:05:59 +0000 (18:05 +0000)
committerTony Breeds <tony@bakeyournoodle.com>
Fri, 16 Jul 2010 05:39:07 +0000 (15:39 +1000)
commit4eb6ac2f80d2469e912e85a0962989d5e97ed3dd
tree8412f673ac11bf038591aa415fee20f1d1375f87
parentada23a5a94474a1bc0b6f72fb81aa5d2a5fa9e7f
prom_getchar eats characters

This bug has been annoying me for a long time. If you copy and paste a
string into the yaboot prompt, or even type too fast, characters get
dropped.

It turns out we were asking OF for 4 characters, but only using the first one.
There is strange logic to look for \e[, and then oring the third character with
0x100. I haven't been able to find anyone that knows why that was there in the
first place, so just remove it and fix this bug once and for all.

Automated test infrastructures the world over will thank us for fixing this
bug!

Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>
second/prom.c