]> git.ozlabs.org Git - petitboot/commit
lib/file: Fix errors found by Coverity scan
authorSamuel Mendoza-Jonas <sam@mendozajonas.com>
Wed, 7 Sep 2016 05:36:40 +0000 (15:36 +1000)
committerSamuel Mendoza-Jonas <sam@mendozajonas.com>
Tue, 11 Oct 2016 03:39:38 +0000 (14:39 +1100)
commitde2f990a98718d15bff074b9ae65f2eb92a2f938
tree357bdb7dd29f2fcb91ee9ff594b2e89908461a36
parentff09391bd6294cce5cfc294ce34148f464a8cf3a
lib/file: Fix errors found by Coverity scan

Fix several errors in copy_file_secure_dest() found by Coverity and some
minor formatting issues:

143603: Correctly handle mkstemp() return value
143605: Avoid accessing dest_filename[-1] on readlink() error
143606, 143610: Avoid accessing dest_filename[sizeof(dest_filename)]
143607: Fix incorrectly passing sizeof(pointer) to fread()
143608, 143611: Cleanup resources on early exit
143609: Explicitly set umask before calling mkstemp()

Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
lib/file/file.c