discover/boot: Fix stale boot cancellation code v1.7.1
authorSamuel Mendoza-Jonas <sam@mendozajonas.com>
Tue, 6 Mar 2018 05:44:44 +0000 (16:44 +1100)
committerSamuel Mendoza-Jonas <sam@mendozajonas.com>
Wed, 7 Mar 2018 05:24:31 +0000 (16:24 +1100)
commitc208aa42024fddc74682742bec12735e432a5510
treec6b16cc68f5813f9a2b3cfea1d2119885d829598
parent47d0601affe80d7f98a2053749f5e1d479f902f4
discover/boot: Fix stale boot cancellation code

In dc85de97 "Allow load_async_url() to call callback for local paths"
several load_url_result fields of the boot_task struct were deprecated
but were accidentally left in the struct. This caused the now out of
date code in cleanup_cancellations() to go unnoticed since it can return
safely if these fields are NULL. However freeing the boot task can free
the memory associated with each load before it is complete, resulting in
a confusing segfault.

This brings cleanup_cancellations() up to date and along the way
implicitly includes the signature resources in cleanup which were missed
originally.

Signed-off-by: Samuel Mendoza-Jonas <sam@mendozajonas.com>
discover/boot.c
discover/boot.h