]> git.ozlabs.org Git - petitboot/blobdiff - discover/ipmi.c
discover: Nicely format IPMI response buffers
[petitboot] / discover / ipmi.c
index 54d4e0636f37093b089fc4a7748ca9e7db8533d4..ae02bb0a69291000fb9f204dc2a674a96e61c77c 100644 (file)
@@ -4,6 +4,7 @@
 #include <poll.h>
 #include <string.h>
 #include <unistd.h>
+#include <arpa/inet.h>
 
 #include <sys/ioctl.h>
 #include <sys/time.h>
@@ -183,7 +184,8 @@ int ipmi_transaction(struct ipmi *ipmi, uint8_t netfn, uint8_t cmd,
 
 out:
        lock.l_type = F_UNLCK;
-       fcntl(ipmi->fd, F_SETLKW, &lock);
+       if (fcntl(ipmi->fd, F_SETLKW, &lock) == -1)
+               pb_log("IPMI: error unlocking IPMI device: %m\n");
        return rc ? -1 : 0;
 }
 
@@ -199,7 +201,7 @@ struct ipmi *ipmi_open(void *ctx)
        struct ipmi *ipmi;
        int fd;
 
-       fd = open(ipmi_devnode, O_RDWR);
+       fd = open(ipmi_devnode, O_RDWR | O_CLOEXEC);
        if (fd < 0) {
                pb_log("IPMI: can't open IPMI device %s: %m\n", ipmi_devnode);
                return NULL;
@@ -219,3 +221,222 @@ bool ipmi_present(void)
        return !access(ipmi_devnode, R_OK | W_OK);
 }
 
+/* Reads and applies an IPMI interface config override, which closely follows
+ * the format of an interface config struct as described in lib/types */
+int parse_ipmi_interface_override(struct config *config, uint8_t *buf,
+                               uint16_t len)
+{
+       struct interface_config *ifconf;
+       char *ipstr, *gatewaystr;
+       uint8_t hwsize, ipsize;
+       int addr_type, i = 0;
+       socklen_t addr_len;
+
+       /* Get 1-byte hardware address size and ip address size */
+       memcpy(&hwsize, &buf[i], sizeof(hwsize));
+       i += sizeof(hwsize);
+       memcpy(&ipsize, &buf[i], sizeof(ipsize));
+       i += sizeof(ipsize);
+
+       if (!hwsize || !ipsize) {
+               pb_log_fn("Empty response\n");
+               return -1;
+       }
+
+       /* At the moment only support 6-byte MAC addresses */
+       if (hwsize != sizeof(ifconf->hwaddr)) {
+               pb_log("Unsupported HW address size in network override: %u\n",
+                      hwsize);
+               return -1;
+       }
+
+       /* Sanity check the IP address size */
+       if (ipsize == 4) {
+               addr_type = AF_INET;
+               addr_len = INET_ADDRSTRLEN;
+       } else if (ipsize == 16) {
+               addr_type = AF_INET6;
+               addr_len = INET6_ADDRSTRLEN;
+       } else {
+               pb_log("Unsupported IP address size: %u\n", ipsize);
+               return -1;
+       }
+
+       /* Everything past here is the interface config */
+       ifconf = talloc_zero(config, struct interface_config);
+       if (!ifconf) {
+               pb_log("Failed to allocate network override\n");
+               return -1;
+       }
+
+       /* Hardware Address */
+       memcpy(ifconf->hwaddr, &buf[i], hwsize);
+       i += hwsize;
+
+       /* Check 1-byte ignore and method flags */
+       ifconf->ignore = !!buf[i++];
+       ifconf->method = !!buf[i++];
+
+       if (ifconf->method == CONFIG_METHOD_STATIC) {
+               if (ipsize + ipsize  + 1 > len - i) {
+                       pb_log("Expected data greater than buffer size\n");
+                       talloc_free(ifconf);
+                       return -1;
+               }
+
+               /* IP address */
+               ipstr = talloc_array(ifconf, char, addr_len);
+               if (!inet_ntop(addr_type, &buf[i], ipstr, addr_len)) {
+                       pb_log("Failed to convert ipaddr: %m\n");
+                       talloc_free(ifconf);
+                       return -1;
+               }
+               i += ipsize;
+
+               /* IP address subnet */
+               ifconf->static_config.address = talloc_asprintf(ifconf,
+                                               "%s/%u", ipstr, buf[i]);
+               i++;
+
+               /* Gateway address */
+               gatewaystr = talloc_array(ifconf, char, addr_len);
+               if (!inet_ntop(addr_type, &buf[i], gatewaystr, addr_len)) {
+                       pb_log("Failed to convert gateway: %m\n");
+                       talloc_free(ifconf);
+                       return -1;
+               }
+               ifconf->static_config.gateway = gatewaystr;
+               i += ipsize;
+       }
+
+       ifconf->override = true;
+       pb_log("Applying IPMI network interface override\n");
+
+       /* Replace any existing interface config */
+       talloc_free(config->network.interfaces);
+       config->network.n_interfaces = 1;
+       config->network.interfaces = talloc(config, struct interface_config *);
+       config->network.interfaces[0] = ifconf;
+
+       return 0;
+}
+
+void ipmi_get_bmc_mac(struct ipmi *ipmi, uint8_t *buf)
+{
+       uint16_t resp_len = 8;
+       uint8_t resp[8];
+       uint8_t req[] = { 0x1, 0x5, 0x0, 0x0 };
+       char *debug_buf;
+       int i, rc;
+
+       rc = ipmi_transaction(ipmi, IPMI_NETFN_TRANSPORT,
+                       IPMI_CMD_TRANSPORT_GET_LAN_PARAMS,
+                       req, sizeof(req),
+                       resp, &resp_len,
+                       ipmi_timeout);
+
+       debug_buf = format_buffer(ipmi, resp, resp_len);
+       pb_debug_fn("BMC MAC resp [%d][%d]:\n%s\n",
+                       rc, resp_len, debug_buf);
+       talloc_free(debug_buf);
+
+       if (rc == 0 && resp_len > 0) {
+               for (i = 2; i < resp_len; i++) {
+                       buf[i - 2] = resp[i];
+               }
+       }
+
+}
+
+/*
+ * Retrieve info from the "Get Device ID" IPMI commands.
+ * See Chapter 20.1 in the IPMIv2 specification.
+ */
+void ipmi_get_bmc_versions(struct ipmi *ipmi, struct system_info *info)
+{
+       uint16_t resp_len = 16;
+       uint8_t resp[16], bcd;
+       char *debug_buf;
+       int rc;
+
+       /* Retrieve info from current side */
+       rc = ipmi_transaction(ipmi, IPMI_NETFN_APP,
+                       IPMI_CMD_APP_GET_DEVICE_ID,
+                       NULL, 0,
+                       resp, &resp_len,
+                       ipmi_timeout);
+
+       debug_buf = format_buffer(ipmi, resp, resp_len);
+       pb_debug_fn("BMC version resp [%d][%d]:\n%s\n",
+                       rc, resp_len, debug_buf);
+       talloc_free(debug_buf);
+
+       if (rc == 0 && (resp_len == 12 || resp_len == 16)) {
+               info->bmc_current = talloc_array(info, char *, 4);
+               info->n_bmc_current = 4;
+
+               info->bmc_current[0] = talloc_asprintf(info, "Device ID: 0x%x",
+                                               resp[1]);
+               info->bmc_current[1] = talloc_asprintf(info, "Device Rev: 0x%x",
+                                               resp[2]);
+               bcd = resp[4] & 0x0f;
+               bcd += 10 * (resp[4] >> 4);
+               /* rev1.rev2.aux_revision */
+               info->bmc_current[2] = talloc_asprintf(info,
+                               "Firmware version: %u.%02u",
+                               resp[3], bcd);
+               if (resp_len == 16) {
+                       info->bmc_current[2] = talloc_asprintf_append(
+                                       info->bmc_current[2],
+                                       ".%02x%02x%02x%02x",
+                                       resp[12], resp[13], resp[14], resp[15]);
+               }
+               bcd = resp[5] & 0x0f;
+               bcd += 10 * (resp[5] >> 4);
+               info->bmc_current[3] = talloc_asprintf(info, "IPMI version: %u",
+                                               bcd);
+       } else
+               pb_debug_fn("Failed to retrieve Device ID from IPMI\n");
+
+       /* Retrieve info from golden side */
+       memset(resp, 0, sizeof(resp));
+       resp_len = 16;
+       rc = ipmi_transaction(ipmi, IPMI_NETFN_AMI,
+                       IPMI_CMD_APP_GET_DEVICE_ID_GOLDEN,
+                       NULL, 0,
+                       resp, &resp_len,
+                       ipmi_timeout);
+
+       debug_buf = format_buffer(ipmi, resp, resp_len);
+       pb_debug_fn("BMC golden resp [%d][%d]:\n%s\n",
+                       rc, resp_len, debug_buf);
+       talloc_free(debug_buf);
+
+       if (rc == 0 && (resp_len == 12 || resp_len == 16)) {
+               info->bmc_golden = talloc_array(info, char *, 4);
+               info->n_bmc_golden = 4;
+
+               info->bmc_golden[0] = talloc_asprintf(info, "Device ID: 0x%x",
+                                               resp[1]);
+               info->bmc_golden[1] = talloc_asprintf(info, "Device Rev: 0x%x",
+                                               resp[2]);
+               bcd = resp[4] & 0x0f;
+               bcd += 10 * (resp[4] >> 4);
+               /* rev1.rev2.aux_revision */
+               info->bmc_golden[2] = talloc_asprintf(info,
+                               "Firmware version: %u.%02u",
+                               resp[3], bcd);
+               if (resp_len == 16) {
+                       info->bmc_golden[2] = talloc_asprintf_append(
+                                       info->bmc_golden[2],
+                                       ".%02x%02x%02x%02x",
+                                       resp[12], resp[13], resp[14], resp[15]);
+               }
+               bcd = resp[5] & 0x0f;
+               bcd += 10 * (resp[5] >> 4);
+               info->bmc_golden[3] = talloc_asprintf(info, "IPMI version: %u",
+                                               bcd);
+       } else
+               pb_debug_fn("Failed to retrieve Golden Device ID from IPMI\n");
+}
+