ccanlint: get rid of separate class of compulsory tests.

[ccan] / tools / ccanlint / tests / no_trailing_whitespace.c

diff --git a/tools/ccanlint/tests/no_trailing_whitespace.c b/tools/ccanlint/tests/no_trailing_whitespace.c
index a66fd74c3c57a8fdd7f42f352975bbe681366665..5d3b5ca19d0b10f1b76fbda3fd2cdfcaa72426b7 100644 (file)
--- a/tools/ccanlint/tests/no_trailing_whitespace.c
+++ b/tools/ccanlint/tests/no_trailing_whitespace.c
@@ -30,21 +30,21 @@ static void check_trailing_whitespace(struct manifest *m,
        struct ccan_file *f;
        unsigned int i;
 
+       /* We don't fail ccanlint for this. */
+       score->pass = true;
+
        foreach_ptr(list, &m->c_files, &m->h_files) {
                list_for_each(list, f, list) {
                        char **lines = get_ccan_file_lines(f);
                        for (i = 0; i < f->num_lines; i++) {
                                char *err = get_trailing_whitespace(lines[i]);
-                               if (err) {
-                                       score->error = "Trailing whitespace"
-                                               " found";
-                                       score_file_error(score, f, i+1, err);
-                               }
+                               if (err)
+                                       score_file_error(score, f, i+1,
+                                                        "%s", err);
                        }
                }
        }
        if (!score->error) {
-               score->pass = true;
                score->score = score->total;
        }
 }
@@ -53,7 +53,7 @@ struct ccanlint no_trailing_whitespace = {
        .key = "no_trailing_whitespace",
        .name = "Module's source code has no trailing whitespace",
        .check = check_trailing_whitespace,
-       .needs = ""
+       .needs = "info_exists"
 };