]> git.ozlabs.org Git - ccan/blobdiff - tools/ccanlint/tests/no_trailing_whitespace.c
ccanlint: remove argument to -k/--keep
[ccan] / tools / ccanlint / tests / no_trailing_whitespace.c
index a66fd74c3c57a8fdd7f42f352975bbe681366665..5c5cf35bb68769ea1276756ac7a34c99147f5b1d 100644 (file)
@@ -22,7 +22,6 @@ static char *get_trailing_whitespace(const char *line)
 }
 
 static void check_trailing_whitespace(struct manifest *m,
-                                     bool keep,
                                      unsigned int *timeleft,
                                      struct score *score)
 {
@@ -30,21 +29,21 @@ static void check_trailing_whitespace(struct manifest *m,
        struct ccan_file *f;
        unsigned int i;
 
+       /* We don't fail ccanlint for this. */
+       score->pass = true;
+
        foreach_ptr(list, &m->c_files, &m->h_files) {
                list_for_each(list, f, list) {
                        char **lines = get_ccan_file_lines(f);
                        for (i = 0; i < f->num_lines; i++) {
                                char *err = get_trailing_whitespace(lines[i]);
-                               if (err) {
-                                       score->error = "Trailing whitespace"
-                                               " found";
-                                       score_file_error(score, f, i+1, err);
-                               }
+                               if (err)
+                                       score_file_error(score, f, i+1,
+                                                        "%s", err);
                        }
                }
        }
        if (!score->error) {
-               score->pass = true;
                score->score = score->total;
        }
 }
@@ -53,7 +52,7 @@ struct ccanlint no_trailing_whitespace = {
        .key = "no_trailing_whitespace",
        .name = "Module's source code has no trailing whitespace",
        .check = check_trailing_whitespace,
-       .needs = ""
+       .needs = "info_exists"
 };