time: add time_check() call and test.

[ccan] / ccan / time / time.c

diff --git a/ccan/time/time.c b/ccan/time/time.c
index 65a257b3fe0a28d6ceb01ffa323262237fd21467..a6960335a50c814610ec1548a041644da4f81948 100644 (file)
--- a/ccan/time/time.c
+++ b/ccan/time/time.c
@@ -1,7 +1,14 @@
 /* Licensed under BSD-MIT - see LICENSE file for details */
 #include <ccan/time/time.h>
 #include <stdlib.h>
-#include <assert.h>
+#include <stdio.h>
+
+#ifdef DEBUG
+#include <ccan/str/str.h>
+#define TIME_CHECK(t) time_check((t), __FILE__ ":" stringify(__LINE__))
+#else
+#define TIME_CHECK(t) (t)
+#endif
 
 #if !HAVE_CLOCK_GETTIME && !HAVE_CLOCK_GETTIME_IN_LIBRT
 #include <sys/time.h>
@@ -13,7 +20,7 @@ struct timespec time_now(void)
        gettimeofday(&now, NULL);
        ret.tv_sec = now.tv_sec;
        ret.tv_nsec = now.tv_usec * 1000;
-       return ret;
+       return TIME_CHECK(ret);
 }
 #else
 #include <time.h>
@@ -21,13 +28,13 @@ struct timespec time_now(void)
 {
        struct timespec ret;
        clock_gettime(CLOCK_REALTIME, &ret);
-       return ret;
+       return TIME_CHECK(ret);
 }
 #endif /* HAVE_CLOCK_GETTIME || HAVE_CLOCK_GETTIME_IN_LIBRT */
 
 bool time_greater(struct timespec a, struct timespec b)
 {
-       if (a.tv_sec > b.tv_sec)
+       if (TIME_CHECK(a).tv_sec > TIME_CHECK(b).tv_sec)
                return true;
        else if (a.tv_sec < b.tv_sec)
                 return false;
@@ -37,7 +44,7 @@ bool time_greater(struct timespec a, struct timespec b)
 
 bool time_less(struct timespec a, struct timespec b)
 {
-       if (a.tv_sec < b.tv_sec)
+       if (TIME_CHECK(a).tv_sec < TIME_CHECK(b).tv_sec)
                return true;
        else if (a.tv_sec > b.tv_sec)
                 return false;
@@ -47,35 +54,34 @@ bool time_less(struct timespec a, struct timespec b)
 
 bool time_eq(struct timespec a, struct timespec b)
 {
-       return a.tv_sec == b.tv_sec && a.tv_nsec == b.tv_nsec;
+       return TIME_CHECK(a).tv_sec == TIME_CHECK(b).tv_sec && a.tv_nsec == b.tv_nsec;
 }
 
 struct timespec time_sub(struct timespec recent, struct timespec old)
 {
        struct timespec diff;
 
-       diff.tv_sec = recent.tv_sec - old.tv_sec;
+       diff.tv_sec = TIME_CHECK(recent).tv_sec - TIME_CHECK(old).tv_sec;
        if (old.tv_nsec > recent.tv_nsec) {
                diff.tv_sec--;
                diff.tv_nsec = 1000000000 + recent.tv_nsec - old.tv_nsec;
        } else
                diff.tv_nsec = recent.tv_nsec - old.tv_nsec;
 
-       assert(diff.tv_sec >= 0);
-       return diff;
+       return TIME_CHECK(diff);
 }
 
 struct timespec time_add(struct timespec a, struct timespec b)
 {
        struct timespec sum;
 
-       sum.tv_sec = a.tv_sec + b.tv_sec;
+       sum.tv_sec = TIME_CHECK(a).tv_sec + TIME_CHECK(b).tv_sec;
        sum.tv_nsec = a.tv_nsec + b.tv_nsec;
        if (sum.tv_nsec >= 1000000000) {
                sum.tv_sec++;
                sum.tv_nsec -= 1000000000;
        }
-       return sum;
+       return TIME_CHECK(sum);
 }
 
 struct timespec time_divide(struct timespec t, unsigned long div)
@@ -84,7 +90,7 @@ struct timespec time_divide(struct timespec t, unsigned long div)
        uint64_t rem, ns;
 
        /* Dividing seconds is simple. */
-       res.tv_sec = t.tv_sec / div;
+       res.tv_sec = TIME_CHECK(t).tv_sec / div;
        rem = t.tv_sec % div;
 
        /* If we can't fit remainder * 1,000,000,000 in 64 bits? */
@@ -104,7 +110,7 @@ struct timespec time_divide(struct timespec t, unsigned long div)
                ns = rem * 1000000000 + t.tv_nsec;
                res.tv_nsec = ns / div;
        }
-       return res;
+       return TIME_CHECK(res);
 }
 
 struct timespec time_multiply(struct timespec t, unsigned long mult)
@@ -124,15 +130,15 @@ struct timespec time_multiply(struct timespec t, unsigned long mult)
                res.tv_nsec = nsec % 1000000000;
                res.tv_sec = nsec / 1000000000;
        }
-       res.tv_sec += t.tv_sec * mult;
-       return res;
+       res.tv_sec += TIME_CHECK(t).tv_sec * mult;
+       return TIME_CHECK(res);
 }
 
 uint64_t time_to_msec(struct timespec t)
 {
        uint64_t msec;
 
-       msec = t.tv_nsec / 1000000 + (uint64_t)t.tv_sec * 1000;
+       msec = TIME_CHECK(t).tv_nsec / 1000000 + (uint64_t)t.tv_sec * 1000;
        return msec;
 }
 
@@ -140,7 +146,7 @@ uint64_t time_to_usec(struct timespec t)
 {
        uint64_t usec;
 
-       usec = t.tv_nsec / 1000 + (uint64_t)t.tv_sec * 1000000;
+       usec = TIME_CHECK(t).tv_nsec / 1000 + (uint64_t)t.tv_sec * 1000000;
        return usec;
 }
 
@@ -148,7 +154,7 @@ uint64_t time_to_nsec(struct timespec t)
 {
        uint64_t nsec;
 
-       nsec = t.tv_nsec + (uint64_t)t.tv_sec * 1000000000;
+       nsec = TIME_CHECK(t).tv_nsec + (uint64_t)t.tv_sec * 1000000000;
        return nsec;
 }
 
@@ -158,7 +164,7 @@ struct timespec time_from_msec(uint64_t msec)
 
        t.tv_nsec = (msec % 1000) * 1000000;
        t.tv_sec = msec / 1000;
-       return t;
+       return TIME_CHECK(t);
 }
 
 struct timespec time_from_usec(uint64_t usec)
@@ -167,7 +173,7 @@ struct timespec time_from_usec(uint64_t usec)
 
        t.tv_nsec = (usec % 1000000) * 1000;
        t.tv_sec = usec / 1000000;
-       return t;
+       return TIME_CHECK(t);
 }
 
 struct timespec time_from_nsec(uint64_t nsec)
@@ -176,5 +182,32 @@ struct timespec time_from_nsec(uint64_t nsec)
 
        t.tv_nsec = nsec % 1000000000;
        t.tv_sec = nsec / 1000000000;
+       return TIME_CHECK(t);
+}
+
+struct timespec time_check(struct timespec t, const char *abortstr)
+{
+       if (t.tv_sec < 0 || t.tv_nsec >= 1000000000) {
+               if (abortstr) {
+                       fprintf(stderr, "%s: malformed time %li.%09li\n",
+                               abortstr,
+                               (long)t.tv_sec, (long)t.tv_nsec);
+                       abort();
+               } else {
+                       struct timespec old = t;
+
+                       if (t.tv_nsec >= 1000000000) {
+                               t.tv_sec += t.tv_nsec / 1000000000;
+                               t.tv_nsec %= 1000000000;
+                       }
+                       if (t.tv_sec < 0)
+                               t.tv_sec = 0;
+
+                       fprintf(stderr, "WARNING: malformed time"
+                               " %li seconds %li ns converted to %li.%09li.\n",
+                               (long)old.tv_sec, (long)old.tv_nsec,
+                               (long)t.tv_sec, (long)t.tv_nsec);
+               }
+       }
        return t;
 }