alloc: avoid arithmetic on void pointers.

[ccan] / ccan / daemonize / daemonize.c

diff --git a/ccan/daemonize/daemonize.c b/ccan/daemonize/daemonize.c
index 861b0fc79cb961d5754899c23b31f0532f8edd32..ff12bfce3f7d15dfcab1053f7a673cae23963125 100644 (file)
--- a/ccan/daemonize/daemonize.c
+++ b/ccan/daemonize/daemonize.c
@@ -3,6 +3,7 @@
 #include <stdlib.h>
 #include <sys/types.h>
 #include <sys/stat.h>
+#include <fcntl.h>
 
 /* This code is based on Stevens Advanced Programming in the UNIX
  * Environment. */
@@ -21,10 +22,20 @@ bool daemonize(void)
        close(STDOUT_FILENO);
        close(STDERR_FILENO);
 
+       /* Many routines write to stderr; that can cause chaos if used
+        * for something else, so set it here. */
+       if (open("/dev/null", O_WRONLY) != 0)
+               return false;
+       if (dup2(0, STDERR_FILENO) != STDERR_FILENO)
+               return false;
+       close(0);
+
        /* Session leader so ^C doesn't whack us. */
        setsid();
        /* Move off any mount points we might be in. */
-       chdir("/");
+       if (chdir("/") != 0)
+               return false;
+
        /* Discard our parent's old-fashioned umask prejudices. */
        umask(0);
        return true;