It leads to a memory leak if the allocation fails (as we reparent onto NULL).
Also, the extra allocation in the failure path increases test time for
failtest (under valgrind) by a factor of 2.
#include <ccan/rbtree/rbtree.h>
static void
#include <ccan/rbtree/rbtree.h>
static void
-tree_destructor_traverse_node(TALLOC_CTX *mem_ctx, trbt_node_t *node)
+tree_destructor_traverse_node(trbt_node_t *node)
{
talloc_set_destructor(node, NULL);
if (node->left) {
{
talloc_set_destructor(node, NULL);
if (node->left) {
- tree_destructor_traverse_node(mem_ctx, node->left);
+ tree_destructor_traverse_node(node->left);
- tree_destructor_traverse_node(mem_ctx, node->right);
+ tree_destructor_traverse_node(node->right);
- talloc_steal(mem_ctx, node);
*/
static int tree_destructor(trbt_tree_t *tree)
{
*/
static int tree_destructor(trbt_tree_t *tree)
{
trbt_node_t *node;
if (tree == NULL) {
trbt_node_t *node;
if (tree == NULL) {
- /* traverse the tree and remove the node destructor and steal
- the node to the temporary context.
+ /* traverse the tree and remove the node destructor then delete it.
we dont want to use the existing destructor for the node
since that will remove the nodes one by one from the tree.
since the entire tree will be completely destroyed we dont care
if it is inconsistent or unbalanced while freeing the
individual nodes
*/
we dont want to use the existing destructor for the node
since that will remove the nodes one by one from the tree.
since the entire tree will be completely destroyed we dont care
if it is inconsistent or unbalanced while freeing the
individual nodes
*/
- tmp_ctx = talloc_new(NULL);
- tree_destructor_traverse_node(tmp_ctx, node);
- talloc_free(tmp_ctx);
+ tree_destructor_traverse_node(node);