#include <err.h>
#include <ccan/talloc/talloc.h>
-extern struct ccanlint tests_exist;
+REGISTER_TEST(tests_exist);
static void handle_no_tests(struct manifest *m, struct score *score)
{
FILE *run;
struct ccan_file *i;
- char *test_dir = talloc_asprintf(m, "%s/test", m->dir);
+ char *test_dir = talloc_asprintf(m, "%s/test", m->dir), *run_file;
printf(
"CCAN modules have a directory called test/ which contains tests.\n"
err(1, "Creating test/ directory");
}
- run = fopen("test/run.c", "w");
+ run_file = talloc_asprintf(test_dir, "%s/run.c", test_dir);
+ run = fopen(run_file, "w");
if (!run)
err(1, "Trying to create a test/run.c");
if (errno != ENOENT)
err(1, "statting %s", test_dir);
tests_exist.handle = handle_no_tests;
+ /* We "pass" this. */
+ score->pass = true;
return;
}
if (list_empty(&m->api_tests)
&& list_empty(&m->run_tests)
- && list_empty(&m->compile_ok_tests)) {
- if (list_empty(&m->compile_fail_tests)) {
- score->error = talloc_strdup(score,
+ && list_empty(&m->compile_ok_tests)
+ && list_empty(&m->compile_fail_tests)) {
+ score->error = talloc_strdup(score,
"No tests in test directory");
- tests_exist.handle = handle_no_tests;
- } else
- score->error = talloc_strdup(score,
- "No positive tests in test directory");
+ tests_exist.handle = handle_no_tests;
return;
}
score->pass = true;
.key = "tests_exist",
.name = "Module has test directory with tests in it",
.check = check_tests_exist,
- .needs = ""
+ .needs = "info_exists"
};
-REGISTER_TEST(tests_exist);