start of shellcheck fixes

[next-scripts] / check_left

diff --git a/check_left b/check_left
index bcdf81e75ed42dc44d09042792c6d287eb315e09..27c8ad3394f84b862cd8ffec367e999bdbd1ca48 100755 (executable)
--- a/check_left
+++ b/check_left
@@ -2,28 +2,23 @@
 
 LOG_FILE="../left_over.log"
 
-cp /dev/null $LOG_FILE
-
-log()
-{
-       echo "$@" | tee -a $LOG_FILE
-}
+cp /dev/null "$LOG_FILE"
 
 heads=$(grep -v '^#' ../etc/control | awk -F ' ' '$2=="quilt" { printf("quilt/%s ", $3); } $2=="git" { printf("%s/%s ", $3, $5); }')
 
 for h in $heads; do
-       echo $h
-       mb=$(git merge-base origin/master $h)
-       rh=$(git rev-parse $h)
+       echo "$h"
+       mb=$(git merge-base origin/master "$h")
+       rh=$(git rev-parse "$h")
        [ "$mb" = "$rh" ] &&
                continue
 
-       c=$(git rev-list --pretty='format:%m%H' --no-merges --left-right --cherry-pick origin/master...$h | sed -n 's/^>//p')
+       c=$(git rev-list --pretty='format:%m%H' --no-merges --left-right --cherry-pick origin/master..."$h" | sed -n 's/^>//p')
        [ -z "$c" ] &&
                continue
 
-       log $h "$(echo $c | wc -w)" | tee -a $LOG_FILE
-       git shortlog --no-walk $c 2>&1 | tee -a $LOG_FILE
+       echo "$h" $(echo "$c" | wc -w) | tee -a "$LOG_FILE"
+       git shortlog --no-walk "$c" 2>&1 | tee -a "$LOG_FILE"
 
 #      gitk stable..$h