/* Does shifting by this many bits truncate the number? */
static bool shift_overflows(size_t num, unsigned bits)
{
- if (bits == 0)
+ if (bits == 0) {
return false;
+ }
return ((num << bits) >> 1) != (num << (bits - 1));
}
unsigned int i, old_min;
/* Uninitialized? Don't do anything... */
- if (tally->max < tally->min)
+ if (tally->max < tally->min) {
goto update;
+ }
/* If we don't have sufficient range, increase step bits until
* buckets cover entire range of ssize_t anyway. */
new_max = val;
need_renormalize = true;
}
- if (need_renormalize)
+ if (need_renormalize) {
renormalize(tally, new_min, new_max);
+ }
/* 128-bit arithmetic! If we didn't want exact mean, we could just
* pull it out of counts. */
- if (val > 0 && tally->total[0] + val < tally->total[0])
+ if (val > 0 && tally->total[0] + val < tally->total[0]) {
tally->total[1]++;
- else if (val < 0 && tally->total[0] + val > tally->total[0])
+ } else if (val < 0 && tally->total[0] + val > tally->total[0]) {
tally->total[1]--;
+ }
tally->total[0] += val;
tally->counts[bucket_of(tally->min, tally->step_bits, val)]++;
}