2 * ccanlint: assorted checks and advice for a ccan package
3 * Copyright (C) 2008 Rusty Russell, Idris Soule
5 * This program is free software; you can redistribute it and/or modify it
6 * under the terms of the GNU General Public License as published by the Free
7 * Software Foundation; either version 2 of the License, or (at your option)
10 * This program is distributed in the hope that it will be useful, but
11 * WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY
12 * or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
15 * You should have received a copy of the GNU General Public License along with
16 * this program; if not, write to the Free Software Foundation, Inc., 51
17 * Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
29 #include <ccan/btree/btree.h>
30 #include <ccan/str/str.h>
31 #include <ccan/str_talloc/str_talloc.h>
32 #include <ccan/talloc/talloc.h>
34 static unsigned int verbose = 0;
35 static LIST_HEAD(compulsory_tests);
36 static LIST_HEAD(normal_tests);
37 static LIST_HEAD(finished_tests);
38 bool safe_mode = false;
39 static struct btree *exclude;
40 static unsigned int timeout;
42 static void usage(const char *name)
44 fprintf(stderr, "Usage: %s [-s] [-n] [-v] [-t <ms>] [-d <dirname>] [-x <tests>] [-k <test>]*\n"
46 " -s: simply give one line summary\n"
47 " -d: use this directory instead of the current one\n"
48 " -n: do not compile anything\n"
49 " -l: list tests ccanlint performs\n"
50 " -k: keep results of this test (can be used multiple times)\n"
51 " -x: exclude tests (e.g. -x trailing_whitespace,valgrind)\n"
52 " -t: ignore (terminate) tests that are slower than this\n",
58 static void indent_print(const char *string)
61 unsigned int line = strcspn(string, "\n");
62 printf("\t%.*s", line, string);
63 if (string[line] == '\n') {
72 bool ask(const char *question)
76 printf("%s ", question);
79 return fgets(reply, sizeof(reply), stdin) != NULL
80 && toupper(reply[0]) == 'Y';
83 static const char *should_skip(struct manifest *m, struct ccanlint *i)
85 if (btree_lookup(exclude, i->key))
86 return "excluded on command line";
89 return "dependency failed";
92 return "dependency was skipped";
99 static bool run_test(struct ccanlint *i,
102 unsigned int *total_score,
106 unsigned int this_score, timeleft;
107 const struct dependent *d;
110 //one less test to run through
111 list_for_each(&i->dependencies, d, node)
112 d->dependent->num_depends--;
114 skip = should_skip(m, i);
119 printf(" %s: skipped (%s)\n", i->name, skip);
121 /* If we're skipping this because a prereq failed, we fail. */
123 *total_score += i->total_score;
126 list_add_tail(&finished_tests, &i->list);
127 list_for_each(&i->dependencies, d, node) {
128 d->dependent->skip = true;
129 d->dependent->skip_fail = i->skip_fail;
134 timeleft = timeout ? timeout : default_timeout_ms;
135 result = i->check(m, i->keep_results, &timeleft);
136 if (timeout && timeleft == 0) {
142 printf(" %s: OK", i->name);
145 i->total_score, i->total_score);
148 if (i->total_score) {
149 *score += i->total_score;
150 *total_score += i->total_score;
154 list_add_tail(&finished_tests, &i->list);
159 this_score = i->score(m, result);
164 list_add_tail(&finished_tests, &i->list);
166 *total_score += i->total_score;
167 *score += this_score;
169 printf(" %s: FAIL (+%u/%u)\n",
170 i->name, this_score, i->total_score);
173 printf("%s\n", i->describe(m, result));
176 i->handle(m, result);
179 /* Skip any tests which depend on this one. */
180 list_for_each(&i->dependencies, d, node) {
181 d->dependent->skip = true;
182 d->dependent->skip_fail = true;
188 static void register_test(struct list_head *h, struct ccanlint *test, ...)
191 struct ccanlint *depends;
192 struct dependent *dchild;
194 list_add(h, &test->list);
197 /* Careful: we might have been initialized by a dependent. */
198 if (test->dependencies.n.next == NULL)
199 list_head_init(&test->dependencies);
201 //dependent(s) args (if any), last one is NULL
202 while ((depends = va_arg(ap, struct ccanlint *)) != NULL) {
203 dchild = malloc(sizeof(*dchild));
204 dchild->dependent = test;
205 /* The thing we depend on might not be initialized yet! */
206 if (depends->dependencies.n.next == NULL)
207 list_head_init(&depends->dependencies);
208 list_add_tail(&depends->dependencies, &dchild->node);
215 * get_next_test - retrieves the next test to be processed
217 static inline struct ccanlint *get_next_test(struct list_head *test)
221 if (list_empty(test))
224 list_for_each(test, i, list) {
225 if (i->num_depends == 0)
228 errx(1, "Can't make process; test dependency cycle");
231 static void init_tests(void)
233 const struct ccanlint *i;
234 struct btree *keys, *names;
237 #define REGISTER_TEST(name, ...) register_test(&normal_tests, &name, __VA_ARGS__)
238 #include "generated-normal-tests"
240 #define REGISTER_TEST(name, ...) register_test(&compulsory_tests, &name, __VA_ARGS__)
241 #include "generated-compulsory-tests"
243 /* Self-consistency check: make sure no two tests
244 have the same key or name. */
245 keys = btree_new(btree_strcmp);
246 names = btree_new(btree_strcmp);
247 list_for_each(&compulsory_tests, i, list) {
248 if (!btree_insert(keys, i->key))
249 errx(1, "BUG: Duplicate test key '%s'", i->key);
250 if (!btree_insert(keys, i->name))
251 errx(1, "BUG: Duplicate test name '%s'", i->name);
253 list_for_each(&normal_tests, i, list) {
254 if (!btree_insert(keys, i->key))
255 errx(1, "BUG: Duplicate test key '%s'", i->key);
256 if (!btree_insert(keys, i->name))
257 errx(1, "BUG: Duplicate test name '%s'", i->name);
265 printf("\nCompulsory Tests\n");
266 list_for_each(&compulsory_tests, i, list) {
267 printf("%s depends on %u others\n", i->name, i->num_depends);
268 if (!list_empty(&i->dependencies)) {
269 const struct dependent *d;
270 printf("These depend on us:\n");
271 list_for_each(&i->dependencies, d, node)
272 printf("\t%s\n", d->dependent->name);
276 printf("\nNormal Tests\n");
277 list_for_each(&normal_tests, i, list) {
278 printf("%s depends on %u others\n", i->name, i->num_depends);
279 if (!list_empty(&i->dependencies)) {
280 const struct dependent *d;
281 printf("These depend on us:\n");
282 list_for_each(&i->dependencies, d, node)
283 printf("\t%s\n", d->dependent->name);
288 static struct ccanlint *find_test(const char *key)
292 list_for_each(&compulsory_tests, i, list)
293 if (streq(i->key, key))
296 list_for_each(&normal_tests, i, list)
297 if (streq(i->key, key))
303 static void keep_test(const char *testname)
305 struct ccanlint *i = find_test(testname);
307 errx(1, "No test %s to --keep", testname);
308 i->keep_results = true;
311 static void print_tests(struct list_head *tests, const char *type)
315 printf("%s tests:\n", type);
316 /* This makes them print in topological order. */
317 while ((i = get_next_test(tests)) != NULL) {
318 const struct dependent *d;
319 printf(" %-25s %s\n", i->key, i->name);
321 list_for_each(&i->dependencies, d, node)
322 d->dependent->num_depends--;
326 static void list_tests(void)
328 print_tests(&compulsory_tests, "Compulsory");
329 print_tests(&normal_tests, "Normal");
333 int main(int argc, char *argv[])
336 bool summary = false;
337 unsigned int score = 0, total_score = 0;
340 const char *prefix = "", *dir = ".";
344 exclude = btree_new(btree_strcmp);
346 /* I'd love to use long options, but that's not standard. */
347 /* FIXME: getopt_long ccan package? */
348 while ((c = getopt(argc, argv, "sd:vnlx:t:k:")) != -1) {
352 prefix = talloc_append_string(talloc_basename(NULL,
371 char **exclude_strs = strsplit(NULL, optarg, ",", NULL);
373 for (i = 0; exclude_strs[i]; i++)
374 btree_insert(exclude, exclude_strs[i]);
377 timeout = atoi(optarg);
379 errx(1, "Invalid timeout %s: 1 ms minumum",
390 m = get_manifest(talloc_autofree_context(), dir);
392 /* If you don't pass the compulsory tests, you don't even get a score */
394 printf("Compulsory tests:\n");
396 while ((i = get_next_test(&compulsory_tests)) != NULL) {
397 if (!run_test(i, summary, &score, &total_score, m)) {
398 errx(1, "%s%s failed", prefix, i->name);
403 printf("\nNormal tests:\n");
404 while ((i = get_next_test(&normal_tests)) != NULL)
405 run_test(i, summary, &score, &total_score, m);
407 printf("%sTotal score: %u/%u\n", prefix, score, total_score);