From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Date: Thu, 31 Dec 2020 04:49:09 +0000 (+0100)
Subject: pppd: Make _PATH_CONNERRS world readable (#194)
X-Git-Tag: ppp-2.4.9~25
X-Git-Url: https://git.ozlabs.org/?p=ppp.git;a=commitdiff_plain;h=dd6e17e16ffecb25d5e2a08a852244d67af56ef1

pppd: Make _PATH_CONNERRS world readable (#194)

From https://bugs.debian.org/341853

There is nothing security-sensitive there.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

Co-authored-by: Marco d'Itri <md@linux.it>
---

diff --git a/pppd/main.c b/pppd/main.c
index aaaa5c8..87a5d29 100644
--- a/pppd/main.c
+++ b/pppd/main.c
@@ -1642,7 +1642,7 @@ device_script(char *program, int in, int out, int dont_wait)
     if (log_to_fd >= 0)
 	errfd = log_to_fd;
     else
-	errfd = open(_PATH_CONNERRS, O_WRONLY | O_APPEND | O_CREAT, 0600);
+	errfd = open(_PATH_CONNERRS, O_WRONLY | O_APPEND | O_CREAT, 0644);
 
     ++conn_running;
     pid = safe_fork(in, out, errfd);