]> git.ozlabs.org Git - ppp.git/commit
radius: Fix MPPE key decryption for the second-half of the key block (#463)
authorJaco Kroon <jaco@uls.co.za>
Thu, 21 Dec 2023 19:50:58 +0000 (21:50 +0200)
committerGitHub <noreply@github.com>
Thu, 21 Dec 2023 19:50:58 +0000 (19:50 +0000)
commit04f851936555d7157e2d518fa233778eb96d3f23
tree98da35d622b1e5e8ada90620e7189d7b6e5f0103
parent0c131e9942c46cf29ecf69b63dc29b63dd2e05fd
radius: Fix MPPE key decryption for the second-half of the key block (#463)

During he refactor in commit 4cb90c1 the key material used to decrypt
the second-half of the encrypted block was accidentally updated from:

MD5(radius_secret + crypt[0..15]); to:

MD5(radius_secret + crypt[0..15] + salt)

Which would obviously mismatch.

This also refactors back into what I believe to be a more readable block
with lower nesting and more comprehensive error reporting.

Closes: #453
Signed-off-by: Jaco Kroon <jaco@uls.co.za>
pppd/plugins/radius/radius.c