]> git.ozlabs.org Git - ppp.git/commit
Fix several issues uncovered by Coverity (#397)
authorEivind Næss <eivnaes@yahoo.com>
Thu, 16 Mar 2023 23:13:25 +0000 (16:13 -0700)
committerGitHub <noreply@github.com>
Thu, 16 Mar 2023 23:13:25 +0000 (10:13 +1100)
commita20059a09c56555f6c2006a7193de4c1676b477a
tree59dbb2eae2f1b52abdf63db82390cb2a6a4678be
parent5c9f2d0e37f7b761e7d966385028f32cb0cca0cf
Fix several issues uncovered by Coverity (#397)

* Fix for coverity issue 436265, we should cap copy to size of destination buffer

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fix for coverity issue 436262, llv6_ntoa() returns a pointer to a buffer that can be up to 64 bytes long; likely not a problem, but this will quiet coverity

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fix for coverity issue 436251, not freeing path in the normal flow of the code

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fixing coverity issue #436258, Digest maybe uninitialized in some paths of this code

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fix for coverity issue 436254, forgot to free 's' before returning from the function?

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fixing coverity issue #436251, memory leak in put_string() function

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fixing coverity issue 436215, should copy at most sizeof(devname) bytes

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fixing coverity issue #436203, if no authentication (or no accounting) server was found, we still need to free the allocated local instance

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fixing coverity issue #436171, use of uninitialized variable

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Use of signed vs unsigned variable in printf for MD4Update

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fixing coverity issue #436182, fixing possible buffer overrun in handling of PW_CLASS attribute

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Fixing coverity issue #436156

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
* Compile errors

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
[paulus@ozlabs.org - Squashed to avoid breaking bisection]

Signed-off-by: Eivind Næss <eivnaes@yahoo.com>
Signed-off-by: Paul Mackerras <paulus@ozlabs.org>
chat/chat.c
pppd/auth.c
pppd/chap_ms.c
pppd/eap.c
pppd/ipv6cp.c
pppd/options.c
pppd/plugins/pppoatm/pppoatm.c
pppd/plugins/pppoe/plugin.c
pppd/plugins/radius/radius.c
pppd/plugins/radius/radrealms.c
pppd/ppp-md4.c